8000 UI: Selector to choose how many rows to display, in each report footer · Issue #2461 · matomo-org/matomo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

UI: Selector to choose how many rows to display, in each report footer #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattab opened this issue Jun 1, 2011 · 15 comments
Closed

UI: Selector to choose how many rows to display, in each report footer #2461

mattab opened this issue Jun 1, 2011 · 15 comments
Assignees
@sgiehl
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.7.1

Comments

@mattab
Copy link
Member
mattab commented Jun 1, 2011

Users have asked that, on the Report page (Top websites/referrer/search engine), we could show more than the default 10 rows, since users are explicitely asking for this report, rather than just looking at it from the dashboard. Maybe we could show 20 by default for the keywords/websites/campaigns.

Note: we would show more than 10 when the report is not loaded "as a widget".
@mattab
Copy link
Member Author
mattab commented Feb 19, 2012

To allow to display more rows for any report in Piwik, maybe there could be a small SELECT element, in the datatable footer, aligned on the right, next to the current footer icons that are left aligned?

Such selector could have the options to show 25, 50, 100, 250, all rows.

It would be cool if the user preference was saved, but it shouldn't be done as part of this ticket but see: #1915

@sgiehl
Copy link
Member
sgiehl commented Feb 24, 2012

(In [5891]) refs #1915, fixes #2461 added new limitation select to all datatables. users can now select how many rows to display. limit changes to widgets on dashboard will automaticly be stored within layout and restored on reload. changed default limits to referer datatables to 25

@mattab
Copy link
Member Author
mattab commented Feb 24, 2012

(In [5893]) Refs #2461 - resetting offset when switching number of rows to display.

This is to work around problem: Display 5 rows, click Next, click next, then click display 50 rows, it should show from the start

@mattab
Copy link
Member Author
mattab commented Feb 24, 2012

(In [5894]) Refs #2461

  • Small CSS adjustements (less wide, border lighter grey (reusing grey from menu)
  • Only display the selector when the table has the pagination and offset details displayed. For example for Visitors > Engagement reports, because we know the number of rows is always the same (fixed reports), then we keep things simple and do not allow to paginate and/or change number of rows to display
  • Adding "title" to explain what the controller does on hover (all browsers display it which is nice)

@mattab
Copy link
Member Author
mattab commented Feb 24, 2012

(In [5896]) Refs #2461

  • Fix Visitor Log bug that when changing rows limit, it would paginate through because the maxIdVisit is passed automatically. Using a hack to fix a hack.
  • Put the arrow in lighter grey as to attract attention less

@mattab
Copy link
Member Author
mattab commented Feb 24, 2012

Excell 8000 ent work SteveG, again a small but great improvement to Piwik usability, which makes the UI much more efficient and less frustrating in terms of data analysis... :)

And it is extremely cool to view 500 visits at once in the visitor log!

@mattab
Copy link
Member Author
mattab commented Feb 24, 2012

(In [5899]) Refs #2461

  • Enabling new controller for ecommerce product/category reports

@mattab
Copy link
Member Author
mattab commented Feb 25, 2012

(In [5907]) Refs #2461

  • Fixing bug for Pages > tables, where a click to load a sub directory would trigger handleLimit and add the controller multiple times below each other
  • Adding possibility to select 500 rows
  • Disabling controller for the plugins report

@mattab
Copy link
Member Author
mattab commented Feb 26, 2012

(In [5918]) Refs #2461

  • Previous commit disabled the selector on non actions tables by mistake

@timo-bes
Copy link
Collaborator

That's an awesome feature! Makes the reports much more usable and also looks nice. People have been asking me for this a number of times.

Only one minor suggestion: Wouldn't it be cool if the arrow flipped upwards when the selection is opened?

@timo-bes
Copy link
Collaborator

I noticed some problems with the JS.

  • The body mouseup event registered in datatable.js for the feature is never unbound. Shouldn't it be only bound after opening the dialog and unbound after closing it?
  • Binding the event to the body is problematic in Chrome. The body does not strech over the entire window but only as far as there is content. If you click the lower area of the window, the boxes don't close. You could use document instead of body.
  • The box can be opened on two tables if there are two on the page. This is connected to the overall event handling I already commented on.

@mattab
Copy link
Member Author
mattab commented May 7, 2012

@timo should we reopen the ticket, or open a different for the small changes/bugs you reported?

@timo-bes
Copy link
Collaborator
timo-bes commented May 7, 2012

I would reopen it.

@mattab
Copy link
Member Author
mattab commented May 24, 2012

I prefer not to reopen since feature works OK and is already released, but created a ticket with your suggestions in: #3150

@mattab
Copy link
Member Author
mattab commented Jun 3, 2012

(In [Refs #2461 Reverting 2 parts of 5891) which caused this bug: Fixes #3167

It seems widgets don't need to default to filter_limit=10 ?

@mattab mattab added this to the 1.7.x - Piwik 1.7.1 milestone Jul 8, 2014
@mattab mattab mentioned this issue Dec 16, 2012
Closed
This was referenced Mar 10, 2012
Closed
Closed
This was referenced May 24, 2012
Closed
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.7.1
Development

No branches or pull requests
3 participants
@timo-bes @mattab @sgiehl
0