8000 UI: small code improvements to selector to choose number of rows · Issue #3150 · matomo-org/matomo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

UI: small code improvements to selector to choose number of rows #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattab opened this issue May 24, 2012 · 1 comment
Closed

UI: small code improvements to selector to choose number of rows #3150

mattab opened this issue May 24, 2012 · 1 comment
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.12.x

Comments

@mattab
Copy link
Member
mattab commented May 24, 2012

Reported by Timo in the original ticket #2461

  • The body mouseup event registered in datatable.js for the feature is never unbound. Shouldn't it be only bound after opening the dialog and unbound after closing it?
  • Binding the event to the body is problematic in Chrome. The body does not strech over the entire window but only as far as there is content. If you click the lower area of the window, the boxes don't close. You could use document instead of body.
  • The box can be opened on two tables if there are two on the page. This is connected to the overall event handling I already commented on.
@sgiehl
Copy link
Member
sgiehl commented May 24, 2012

(In [6308]) fixes #3150 fixed problems with events

@mattab mattab added this to the 1.12.x - Piwik 1.12.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.12.x
Development

No branches or pull requests
2 participants
@mattab @sgiehl
0