next tracking PR for 3.1.0
#229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to run `local` or `remote` when either have never ran
`start` or when the local server is not running, the error that the
users face is not great.
This should improve the understanding of what is wrong.
### Current errors
When calling before an initial `start`:
```
Error: Failed to read state file
```
When calling with local server stopped:
```
Error: WorkerClientErr(Reqwest(reqwest::Error { kind: Request, url: "http://localhost:8080/linkup/local-session", source: hyper_util::client::legacy::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) }))
```
### New errors
When calling before an initial `start`:
```
Seems like you don't have any state yet to point to local.
Have you run `linkup start` at least once?
```
When calling with local server stopped:
```
Seems like your local Linkup server is not running. Please run `linkup start` first.
```
Closes SHIP-2024
This should improve the feedback when running `status` and `health` for the first time. Instead of erroring out when missing the state, this should point the users to the reason why information is wrong/missing. Closes SHIP-2060 --------- Co-authored-by: Charlotte Andersson <charlotte.andersson@mentimeter.com>
This should make it easier to see from which version to which version you are going when updating.
The update message was previously interfering with j 9426 son outputs, for example. This changes so that the message doesn't show on cases where it is not relevant. Those being: - `completion` command. - `health` command when the json output is requested. - `status` command when the json output is requested. - `uninstall` command, since the user is already uninstalling. - `update` command, since the user is already updating. Closes SHIP-2028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be merged to release 3.1.0.
Changelog: