8000 fix: only shows update message where it makes sense by augustoccesar · Pull Request #231 · mentimeter/linkup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: only shows update message where it makes sense #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub < 8000 /div>

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix: only shows update message where it makes sense #231

merged 1 commit into from
Apr 14, 2025

Conversation

augustoccesar
Copy link
Collaborator

The update message was previously interfering with json outputs, for example. This changes so that the message doesn't show on cases where it is not relevant. Those being:

  • completion command.
  • health command when the json output is requested.
  • status command when the json output is requested.
  • uninstall command, since the user is already uninstalling.
  • update command, since the user is already updating.

Closes SHIP-2028

@augustoccesar
fix: only shows update message where it makes sense
1a92726 
The update message was previously interfering with json outputs, for example.
This changes so that the message doesn't show on cases where it is not relevant. Those being:
- `completion` command.
- `health` command when the json output is requested.
- `status` command when the json output is requested.
- `uninstall` command, since the user is already uninstalling.
- `update` command, since the user is already updating.

Closes SHIP-2028
@augustoccesar augustoccesar requested review from a team and Copilot 8000 April 14, 2025 06:22
@augustoccesar augustoccesar self-assigned this Apr 14, 2025
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@augustoccesar augustoccesar mentioned this pull request Apr 14, 2025
Merged
@augustoccesar augustoccesar merged commit 3223e60 into next Apr 14, 2025
6 checks passed
@augustoccesar augustoccesar deleted the augustoccesar/hide-update-message-on-cases-that-makes-sense branch April 14, 2025 06:58
augustoccesar added a commit that referenced this pull request Apr 14, 2025
@augustoccesar @charlottea98
Release 3.1.0 (#229)
5ee51b0 
This will be merged to release 3.1.0.

Changelog:
- #227 
- #228
- #230 
- #231

---------

Co-authored-by: Charlotte Andersson <charlotte.andersson@mentimeter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@charlottea98 charlottea98 charlottea98 approved these changes

Assignees

@augustoccesar augustoccesar

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustoccesar @charlottea98
0