feat(cli): set port binding capability on binary for Linux #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
linkup-cli/src/commands/update.rs:74
- Consider waiting for the setcap process to complete (e.g., using .wait() or .status()) to verify that the capability was successfully applied before proceeding.
.spawn()?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
augustoccesar
added a commit
that referenced
this pull request
May 5, 2025
This release gets the Linux version closer to the macOS. We are testing it with Ubuntu. Main changes: - Ensure that Linkup can bind to 80/443 on Linux - #232 (fixes: 34f5282, 7e8cef5, b6fac77) - Manage self-signed certificates on Linux - #234 - Fix `health` command output on Linux - #236 Other changes: - Fix install script link on docs (8e6009d) - Use Ruff formatting on install script (e39de86) - Don't propagate `baggage` header (#237 ) --------- Co-authored-by: Roman Prudnikov <stillerr@yandex.ru> Co-authored-by: Oliver Stenbom <oliver@stenbom.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done
setcapin Linux to be able to bind ports