8000 `next` tracking PR for 3.2.0 by augustoccesar · Pull Request #233 · mentimeter/linkup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

next tracking PR for 3.2.0 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 5, 2025
Merged

next tracking PR for 3.2.0 #233

merged 11 commits into from
May 5, 2025

Conversation

augustoccesar
Copy link
Collaborator
@augustoccesar augustoccesar commented Apr 17, 2025

Main focus of this release is to get the Linux version closer to the macOS one. We are testing it with Ubuntu.

Main changes:

Other changes:

**What's done**
- using `setcap` in Linux to be able to bind ports
  - for install
  - for update
- changed the Heath command to say whether the capability is set or not

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RayProud and others added 3 commits April 28, 2025 10:28
There's no such cli tool like `security` on Ubuntu, so everything is
mostly manual.

**Where do certs live in Linux**
Certs live in `/etc/ssl/certs`, but this directory is mostly a
collection of symlinks that shouldn't be updated directly.
Instead, we copy our cert to `/usr/local/share/ca-certificates` and then
run `update-ca-certificates` to update the symlinks.

**Where do Firefox certs live in Linux**
Depends!
I found three places depending on how Firefox was installed and what
your Linux is.
```
    let profile_dirs = [
        ".mozilla/firefox",
        "snap/firefox/common/.mozilla/firefox",
        ".var/app/org.mozilla.firefox/.mozilla/firefox",
    ];
```

**How to test**
- pull the branch on a Ubuntu machine
- `cd linkup-cli && cargo install --path .`
- `cd ..` — get back to the root of the repo
- `sudo setcap cap_net_bind_service=+ep ~/.cargo/bin/linkup`
- `export LINKUP_CONFIG=~/linkup/linkup-config.yaml`
- `export PATH=$PATH:~/.cargo/bin/linkup >> ~/.bashrc`
- `source ~/.bashrc`
- `linkup start`
- `linkup local-dns install`
- `linkup health`


**Resourses:**
-
https://documentation.ubuntu.com/server/how-to/security/install-a-root-ca-certificate-in-the-trust-store/index.html
-
https://superuser.com/questions/437330/how-do-you-add-a-certificate-authority-ca-to-ubuntu

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ns (#236)

macOS doesn’t expose each thread as a “full” process.
However, Linux does. Which results in lots of thread-duplicates on
`linkup health` on Linux.

[From the Apple
documentation](https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Multithreading/CreatingThreads/CreatingThreads.html?utm_source=chatgpt.com)
> Each process (application) in OS X or iOS is made up of one or more
threads, each of which represents a single path of execution through the
application's code.

Whereas in Linux, a thread is a process on its own.
- baggage headers will still be _forwarded_ -> linkup forwards headers
by default
- this header is currently not used - tracestate should continue to be
the primary method of linkup state propogation
- less things to think about - more simple
@augustoccesar augustoccesar marked this pull request as ready for review May 5, 2025 07:08
@augustoccesar augustoccesar requested review from ostenbom and a team May 5, 2025 07:08
Copy link
Contributor
@ostenbom ostenbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! :shipit:

@augustoccesar augustoccesar merged commit 7a36b42 into main May 5, 2025
11 checks passed
@augustoccesar augustoccesar deleted the next branch May 5, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0