-
Notifications
You must be signed in to change notification settings - Fork 3
next
tracking PR for 3.2.0
#233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What's done** - using `setcap` in Linux to be able to bind ports - for install - for update - changed the Heath command to say whether the capability is set or not --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
augustoccesar
commented
Apr 17, 2025
Co-authored-by: Augusto César <augusto.silva@mentimeter.com>
There's no such cli tool like `security` on Ubuntu, so everything is mostly manual. **Where do certs live in Linux** Certs live in `/etc/ssl/certs`, but this directory is mostly a collection of symlinks that shouldn't be updated directly. Instead, we copy our cert to `/usr/local/share/ca-certificates` and then run `update-ca-certificates` to update the symlinks. **Where do Firefox certs live in Linux** Depends! I found three places depending on how Firefox was installed and what your Linux is. ``` let profile_dirs = [ ".mozilla/firefox", "snap/firefox/common/.mozilla/firefox", ".var/app/org.mozilla.firefox/.mozilla/firefox", ]; ``` **How to test** - pull the branch on a Ubuntu machine - `cd linkup-cli && cargo install --path .` - `cd ..` — get back to the root of the repo - `sudo setcap cap_net_bind_service=+ep ~/.cargo/bin/linkup` - `export LINKUP_CONFIG=~/linkup/linkup-config.yaml` - `export PATH=$PATH:~/.cargo/bin/linkup >> ~/.bashrc` - `source ~/.bashrc` - `linkup start` - `linkup local-dns install` - `linkup health` **Resourses:** - https://documentation.ubuntu.com/server/how-to/security/install-a-root-ca-certificate-in-the-trust-store/index.html - https://superuser.com/questions/437330/how-do-you-add-a-certificate-authority-ca-to-ubuntu --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ns (#236) macOS doesn’t expose each thread as a “full” process. However, Linux does. Which results in lots of thread-duplicates on `linkup health` on Linux. [From the Apple documentation](https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Multithreading/CreatingThreads/CreatingThreads.html?utm_source=chatgpt.com) > Each process (application) in OS X or iOS is made up of one or more threads, each of which represents a single path of execution through the application's code. Whereas in Linux, a thread is a process on its own.
- baggage headers will still be _forwarded_ -> linkup forwards headers by default - this header is currently not used - tracestate should continue to be the primary method of linkup state propogation - less things to think about - more simple
ostenbom
approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main focus of this release is to get the Linux version closer to the macOS one. We are testing it with Ubuntu.
Main changes:
health
command output on LinuxOther changes:
baggage
header (refactor: remove baggage from linkup state propogation #237 )