refactor: reimplement download of latest versions #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason that prompted this reimplementation was rate limits from GitHub. If we got rate-limited by GitHub, we should block checking again until the rate limit resets. The time of when it will be reset is in the header `x-ratelimit-reset`. References: - https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#checking-the-status-of-your-rate-limit
b084f55 to
938bb79
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the version checking and update mechanisms to address GitHub rate limit issues by implementing new API calls and error handling improvements. Key changes include:
- Adding serialization support (Serialize/Deserialize) to VersionChannel and Version structures.
- Renaming API calls from available_update to check_for_update and updating cache clearing logic.
- Changing the download flow to use update.binary.download() with improved error context.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linkup/src/versioning.rs | Added Serialize and Deserialize derives to VersionChannel and Version for consistency. |
| linkup-cli/src/commands/update.rs | Updated update logic to use new API methods and improved error context when downloading. |
Comments suppressed due to low confidence (2)
linkup-cli/src/commands/update.rs:55
- Ensure that the new update.binary.download() method returns a decompressed binary equivalent to the previous update.linkup.download_decompressed('linkup') method, to avoid any unintended behavior changes.
let new_linkup_path = update
linkup-cli/src/commands/update.rs:38
- Verify that CachedReleases::clear() effectively clears the same cache as the previous clear_cache() implementation to ensure consistent update behavior.
release::CachedReleases::clear();
Druue
approved these changes
Jun 17, 2025
augustoccesar
added a commit
that referenced
this pull request
Jun 18, 2025
augustoccesar
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason that prompted this reimplementation was rate limits from GitHub. If we got rate-limited by GitHub, we should block checking again until the rate limit resets.
The time of when it will be reset is in the header
x-ratelimit-reset.Closes SHIP-2147
References: