8000 Improve header management on websocket proxying by ostenbom · Pull Request #241 · mentimeter/linkup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve header management on websocket proxying #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Improve header management on websocket proxying #241

merged 1 commit into from
Jun 9, 2025

Conversation

ostenbom
Copy link
Contributor
@ostenbom ostenbom commented Jun 6, 2025 •
edited
Loading
  • In order for websockets to work well, they must respect websocket headers like sec-websocket-key
  • One way to do this as a proxy is to "not" and just pass all headers along
  • This modifies the local server websocket implementation to pass more headers upstream and downstream, so that more gets through the proxy

There may be problems with the remote worker also after the last websocket refactor - websocket proxying is hard.
Bit unclear though, the implementation there is significantly different.

@ostenbom
Improve header management on websocket proxying
c63405d 
- In order for websockets to work well, they must respect websocket headers like `sec-websocket-key`
- The best way to do this as a proxy is to "not" and just pass all headers along
- This modifies the local server websocket implementation to pass more headers upstream _and_ downstream, so that more gets through the proxy
@ostenbom ostenbom force-pushed the oliver/improve-websocket-header-proxying branch from 0c6f205 to c63405d Compare June 6, 2025 15:26
ostenbom
ostenbom commented Jun 9, 2025
View reviewed changes
linkup-cli/src/services/local_server.rs
Comment on lines +62 to +65
command.env(
"RUST_LOG",
"info,hickory_server=warn,hyper_util=warn,h2=warn,tower_http=info",
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently stderr is very noisy, this makes it slightly less noisy

@augustoccesar augustoccesar changed the base branch from main to next June 9, 2025 10:59
@augustoccesar augustoccesar merged commit acff3fd into mentimeter:next Jun 9, 2025
6 checks passed
@augustoccesar augustoccesar mentioned this pull request Jun 9, 2025
Merged
augustoccesar added a commit that referenced this pull request Jun 18, 2025
@augustoccesar @ostenbom
next tracking PR for version 3.4.0 (#242)
6d5f18b 
Changelog:
- #241 
- #244
- #245 
- #246 
- #243 
- #248

---------

Co-authored-by: Oliver Stenbom <oliver@stenbom.eu>
augustoccesar added a commit that referenced this pull request Jun 18, 2025
@augustoccesar @ostenbom
Release 3.4.0 (#242)
78e037f 
Changelog:
- #241
- #244
- #245
- #246
- #243
- #248

---------

Co-authored-by: Oliver Stenbom <oliver@stenbom.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoccesar augustoccesar augustoccesar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostenbom @augustoccesar
0