8000 Enable static analysis by atifaziz · Pull Request #924 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable static analysis #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jan 17, 2023
Merged

Enable static analysis #924

merged 30 commits into from
Jan 17, 2023

Conversation

atifaziz
Copy link
Member

This PR enables static code analysis through the solution and addresses the issues/warnings/errors (see individual commits) highlighted by the .NET analyzers.

atifaziz added 22 commits January 15, 2023 14:22
@atifaziz
Enable static code analysis
a5f52fa
@atifaziz
Address CA issues in extensions generator project
7f1a1f1
@atifaziz
Fix CA2201: Do not raise reserved exception types
c3d1597 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2201
@atifaziz
Fix CA1852: Seal internal types
6abf996 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1852
@atifaziz
Fix CA1062: Validate arguments of public methods
f3c1159 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1062
@atifaziz
Fix CA5394: Do not use insecure randomness
76b372f 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5394
@atifaziz
Fix CA2208: Instantiate argument exceptions correctly
a35dff9 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2208
@atifaziz
Fix CA1031: Do not catch general exception types
1c4d3ca 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1031
@atifaziz
Fix CA2007: Do not directly await a Task
251d3ca 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2007
@atifaziz
Fix CA1825: Avoid zero-length array allocations
493e74e 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1825
@atifaziz
Fix CA1812: Avoid uninstantiated internal classes
26d90f8 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1812
@atifaziz
Fix CA1851: Possible multiple enumerations of sequence
ad6f5b1 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1851
@atifaziz
Fix CA1810: Initialize reference type static fields inline
1d9d4f3 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1810
@atifaziz
Fix CA1720: Identifier contains type name
4a9119b 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1720
@atifaziz
Fix CA1305: Specify IFormatProvider
ddfe468 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1305
@atifaziz
Fix CA2213: Disposable fields should be disposed
f6ef9ec 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2213
@atifaziz
Fix CA2211: Non-constant fields should not be visible
2da9058 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2211
@atifaziz
Fix CA1805: Do not initialize unnecessarily
bd09724 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1805
@atifaziz
Fix CA1834: Use "StringBuilder.Append(char)" for single character str…
fdc19da 
…ings

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1834
@atifaziz
Fix CA1822: Mark members as static
9def9dd 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1822
@atifaziz
Fix CA2000: Dispose objects before losing scope
4914b18 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000
@atifaziz
Refresh generated code
9bf9eb7
@codecov
Copy link
codecov bot commented Jan 15, 2023 •
edited
Loading

Codecov Report

Merging #924 (53b36c2) into master (f4806f5) will increase coverage by 0.01%.
The diff coverage is 94.11%.

❗ Current head 53b36c2 differs from pull request most recent head 4f53d4c. Consider uploading reports for the commit 4f53d4c to get more accurate results

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   92.39%   92.41%   +0.01%     
==========================================
  Files         112      112              
  Lines        3421     3426       +5     
  Branches     1017     1017              
==========================================
+ Hits         3161     3166       +5     
  Misses        199      199              
  Partials       61       61
Impacted Files Coverage Δ
MoreLinq/Fold.cs 97.87% <ø> (ø)
MoreLinq/From.cs 88.00% <ø> (ø)
MoreLinq/MaxBy.cs 93.39% <ø> (ø)
MoreLinq/PendNode.cs 98.48% <0.00%> (ø)
MoreLinq/Random.cs 91.89% <ø> (ø)
MoreLinq/RandomSubset.cs 100.00% <ø> (ø)
MoreLinq/EmptyArray.cs 100.00% <100.00%> (ø)
MoreLinq/GlobalRandom.cs 66.66% <100.00%> (ø)
MoreLinq/Permutations.cs 96.42% <100.00%> (ø)
MoreLinq/Repeat.cs 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
viceroypenguin
viceroypenguin reviewed Jan 15, 2023
View reviewed changes
@atifaziz atifaziz mentioned this pull request Jan 15, 2023
Merged
viceroypenguin
viceroypenguin approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor
@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With formatting changes addressed in #929, approved.

@atifaziz atifaziz merged commit 18dcf2c into morelinq:master Jan 17, 2023
@atifaziz atifaziz deleted the enable-static-analysis branch January 17, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceroypenguin viceroypenguin viceroypenguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atifaziz @viceroypenguin
0