Fix exception thrown by current buffer index implementation #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 112 112
Lines 3436 3436
Branches 1019 1019
=======================================
Hits 3176 3176
Misses 199 199
Partials 61 61 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
viceroypenguin
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
ICurrentBuffer<>indexer implementation, used inBatch, to throwIndexOutOfRangeExceptioninstead ofArgumentOutOfRangeException. This is to respect the contract ofIList<T>[index], which should throwArgumentOutOfRangeExceptionfor an index index.This is a follow-up to a review comment by @viceroypenguin on PR #924.