[Processor] Support statistics in async mode with multiple workers #3614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Apr 25, 2025
Comment on lines
+251
to
+252
| for _, object := range nba.objects { | ||
| stats := object.GetAllocationStatistics() |
There was a problem hiding this comment.
Is this function called in a critical path? If so, we might consider to do this concurrently.
There was a problem hiding this comment.
@TomerShor no, it's not a critical path. And since GetAllocationStatistics() is lightweight, introducing concurrency might only add unnecessary overhead and complexity.
TomerShor
approved these changes
Apr 27, 2025
TomerShor
pushed a commit
that referenced
this pull request
Apr 30, 2025
Jira - https://iguazio.atlassian.net/browse/NUC-402 This was implemented in the following PRs: - #3608 - #3614 - #3615 - #3621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support statistics in async mode with multiple workers + test for it.
Also, added mock-ed eventProcessor and moved all test to use it in case we need something to Mock.
Jira - https://iguazio.atlassian.net/browse/NUC-411