[Dashboard] Support multiple workers in asynchronous mode #3623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira - https://iguazio.atlassian.net/browse/NUC-410 The base branch is [feature/nuc-201-phase2](https://github.com/nuclio/nuclio/tree/feature/nuc-201-phase2), so we will merge to develop only when everything is ready. Implements a new non-blocking pool allocator that allocates objects using a round-robin strategy. The round-robin mechanism is driven by an atomic index, which is incremented with each allocation. Additionally, the shared pool logic has been refactored into an abstract base class, `abstractPoolAllocator`. The `BenchmarkParallelAllocation` test has also been made generic for different allocator implementations. This allows us to pass in a constructor and benchmark any allocator, which is valuable since the allocator component is a critical part of overall performance.
…3614) Adds support statistics in async mode with multiple workers + test for it. Also, added mock-ed eventProcessor and moved all test to use it in case we need something to Mock. Jira - https://iguazio.atlassian.net/browse/NUC-411
…iple workers (#3615) * Add support for multiple workers in async mode * Add a new test for multiple worker configuration in async mode Jira - https://iguazio.atlassian.net/browse/NUC-412
Improves the allocation method in the non-blocking pool so that it checks the state of the allocated object. If the object is not ready, it will retry N times, where N is the number of objects in the allocator. Also, replaced `Equal` with `Same` in allocator test. When mocks like MockEventProcessor are compared, identical internal state can cause them to be seen as equal even if they are distinct instances. What needs to be verified in the tests is whether two different instances are returned, not just objects with matching fields. With Same, a comparison based on memory address is performed, ensuring that true object identity is validated. For this reason, Same (or NotSame) is preferred over Equal (or NotEqual) when verifying allocation behavior with mocks. Jira - https://iguazio.atlassian.net/browse/NUC-413
TomerShor
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira - https://iguazio.atlassian.net/browse/NUC-402
This was implemented in the following PRs: