WS2812FX: Add network support #421
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
Bumps [cryptography](https://github.com/pyca/cryptography) from 3.3 to 3.3.2. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.3...3.3.2) Signed-off-by: dependabot[bot] <support@github.com>
|
Refer to this link for build results (access rights to CI server needed): |
…ulse duration value on zigbee layer
1e98fd2 to
41b666c
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
|
||
| QString interface = thing->paramValue(nymeaLightThingAddressParamTypeId).toString(); | ||
| NymeaLight *light = nullptr; | ||
| if (thing->paramValue(nymeaLightThingConnectionTypeParamTypeId).toString() == "Serial") { |
There was a problem hiding this comment.
Interesting approach to use one device with 2 possible connection interfaces! Nice idea
|
|
||
| if (!hardwareManager()->zeroConfController()->available()) { | ||
| qCWarning(dcWs2812fx()) << "ZeroConfController not available"; | ||
| } |
There was a problem hiding this comment.
Maybe add info->finish(Thing::ThingErrorNoError); here and return, no need to proceed.
| qCWarning(dcWs2812fx()) << "ZeroConfController not available"; | ||
| } | ||
|
|
||
| Q_FOREACH (const ZeroConfServiceEntry &service, m_serviceBrowser->serviceEntries()) { |
There was a problem hiding this comment.
Better use forach, since the Q_FOREACH macro has been deprecated and will not be supported in future Qt versions.
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.25.10 to 1.26.5. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.25.10...1.26.5) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.3 to 1.26.5. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.3...1.26.5) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ments and add trigger button
…and not by hostname
f3381f7 to
7e90843
Compare
|
|
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
678ce54 to
7ff6686
Compare
|
Refer to this link for build results (access rights to CI server needed): |
nymea-plugins pull request checklist:
Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"
Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.
Did you update the plugin's README.md accordingly?
Did you update translations (
cd builddir && make lupdate)?If you added a new plugin, should it be added to nymea-plugins-all or nymea-plugins-maker?