8000 Release/5.1.0 by x4v13r64 · Pull Request #401 · nccgroup/ScoutSuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release/5.1.0 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
May 22, 2019
Merged

Release/5.1.0 #401

merged 47 commits into from
May 22, 2019

Conversation

x4v13r64
Copy link
Collaborator
@x4v13r64 x4v13r64 commented May 8, 2019 •
edited
Loading

Changes:

  • Updates styling to NCC's standards
  • Changes to the CLI
    • Removes the --vpc and --resume CLI arguments as they aren't implemented
    • Adds the following options:
      • --quiet flag to suppress CLI output
      • --logfile param to specify an additional file path to store output (supports --debug flag)
  • Update the "Execution Details" section to be more generic and work with programatic executions.
  • Updates to rulesets and findings
  • Bug fixes

Oliver Smelik and others added 14 commits May 1, 2019 16:59
@codecov-io
Copy link
codecov-io commented May 8, 2019 •
edited
Loading

Codecov Report

Merging #401 into master will increase coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   34.42%   34.43%   +<.01%     
==========================================
  Files         192      192              
  Lines        6338     6343       +5     
==========================================
+ Hits         2182     2184       +2     
- Misses       4156     4159       +3
Impacted Files Coverage Δ
ScoutSuite/core/cli_parser.py 11.84% <0%> (ø) ⬆️
...coutSuite/providers/gcp/resources/gce/instances.py 27.45% <0%> (ø) ⬆️
...azure/resources/network/network_security_groups.py 10% <0%> (+0.32%) ⬆️
ScoutSuite/__init__.py 100% <100%> (ø) ⬆️
ScoutSuite/__main__.py 20.22% <20%> (-0.23%) ⬇️
ScoutSuite/core/console.py 27.96% <44.44%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a498fb...db0ab2d. Read the comment docs.

@thommor
Copy link
Contributor 8000
thommor commented May 13, 2019

Any timeframe on the release of this?

@x4v13r64
Copy link
Collaborator Author

Any timeframe on the release of this?

Not at this point, as there are a number of features planned for this milestone (https://github.com/nccgroup/ScoutSuite/milestone/14). Open to pushing them back to the next if it's a requirement.

x4v13r64 and others added 20 commits May 16, 2019 19:53
@x4v13r64
Add the --no-logging flag to suppress CLI output
d852f5d
@x4v13r64
Add the --logfile CLI parameter
88abed8 
Rename `--no-logging` to `--quiet`
@x4v13r64
Fix tests
e9aa009
@x4v13r64
Merge pull request #412 from /issues/408
7d6b44c 
Suppress output #408
@x4v13r64
Merge branch 'issues/408' into release/5.1.0
5265ab9
@x4v13r64
Fix for #396
f051b8b
@x4v13r64
Merge pull request #413 from /issues/396
3186424 
Fix for #396
@x4v13r64
Change cmd to arguments and show as table
0454814
@x4v13r64
Only include desired parameters
ddf3485
@x4v13r64
Add rationale
bc605dc
@x4v13r64
Update level to danger
01c1928
@x4v13r64
Add CIS Cloud Storage issues to ruleset
7fc1e56
@x4v13r64
Merge pull request #415 from nccgroup/improvement/gcp/storage/cis_and…
1175d35 
…_rationales

GCP Cloud Storage
@x4v13r64
Update "about" for default rulesets
d0dcca8
@x4v13r64
Merge pull request #416 from nccgroup/improvement/default-rulesets
6473e14 
Update "about" for default rulesets
@x4v13r64
Merge branch 'develop' into release/5.1.0
23dfd70
@x4v13r64
Merge branch 'develop' into release/5.1.0
db0ab2d
@x4v13r64
Make default about content more generic.
ac8fc8b
@x4v13r64
Merge pull request #414 from /issues/407
db17698 
Update execution details to work when Scout is run programatically
@x4v13r64
Merge pull request #426 from nccgroup/develop
f9fe9e6 
Merge Develop into 5.1.0
@x4v13r64 x4v13r64 merged commit 1ac89eb into master May 22, 2019
@x4v13r64 x4v13r64 deleted the release/5.1.0 branch May 22, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x4v13r64 @codecov-io @thommor
0