Release v4.1.0 #142
Merged
Release v4.1.0 #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect-html Incorrect HTML for VPC Network ACLs
Improvement/60 light dark themes
The loop was iterating over the instances ids instead of over the resources
…nterfaces, closes #10 Bugfix/10 missing ec2 network interfaces
Master to develop
…torageaccounts-access-keys-not-rotated feature/#30-new-finding-azure-storageaccounts-access-keys-not-rotated
zer0x64
reviewed
Feb 4, 2019
x4v13r64
approved these changes
Feb 4, 2019
|
I would wait until the CLI has been refactored (i.e. until https://github.com/nccgroup/ScoutSuite/tree/refactor/127-cli-refactoring is merged) before making the 4.1.0 release. Main reason is to that Azure authentication doesn't change too much from 4.1.0 to 4.2.0. Sounds good? |
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 30.46% 30.36% -0.11%
==========================================
Files 63 64 +1
Lines 4034 4206 +172
==========================================
+ Hits 1229 1277 +48
- Misses 2805 2929 +124
Continue to review full report at Codecov.
|
Feature/145 Azure switches for credentials
misg
approved these changes
Feb 4, 2019
|
Tested it with Azure and GCP and everything looks fine. 💯 |
Looks fine to me 🥇 |
vifor2
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v4.1.0.
Please also see the proprietary PR.