1.0.0 release of nf-core/rnasplice pipeline #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hisat-stringtie chrX test data which should reach all tools for testing pipeline.
SL-93 refactor rmarts input checks
…atter SL-95 format bin python files
…l-behaviour Sl 96 refactor aligner conditional behaviour
…ats-to-groovy-script Sl 102 add condition check for rmats to groovy script
…ce-checker SL-101 add suppa parameter check
Merging template updates
Fixes MISO scratch/launch directory and gffread issue
…e-entry-in-contrast-sheet keep contrasts as array when only one level
suppa fix attempt 1
…g-with-multiple-contrasts-filenamebam-not-found-in-rmats-files replace across with combine to mimic SQL join
refactor rmats contrasts
chris-cheshire
approved these changes
Sep 1, 2023
|
Great work! My comment still stands about potentially moving some of your modules into nf-core at some point, but I don't think this needs to hold up release. |
Potential fix for MISO index issue
maxulysse
reviewed
Sep 25, 2023
docs/rnasplice_map.png
Outdated
There was a problem hiding this comment.
Could we have only rounded corners, like in the box 3, and not a mixture of straight and rounded corners?
Not blocking the release though
maxulysse
reviewed
Sep 25, 2023
|
|
||
| conda "bioconda::htseq=2.0.2" | ||
| container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | ||
| 'https://depot.galaxyproject.org/singularity/htseq:2.0.2--py310ha14a713_0' : |
There was a problem hiding this comment.
Suggested change
| 'https://depot.galaxyproject.org/singularity/htseq:2.0.2--py310ha14a713_0' : | |
| 'https://depot.galaxyproject.org/singularity/htseq:2.0.2--py310ha14a713_0' : |
There was a problem hiding this comment.
actually it's the following one that should be indented more, not this one indented less
maxulysse
approved these changes
Sep 25, 2023
Important! Template update for nf-core/tools v2.10
pre-release fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting core pipeline review for 1.0.0 release, as required in the documentation.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).