8000 nf-core modules update changed md5sum of skipped module in modules.json · Issue #2014 · nf-core/tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

nf-core modules update changed md5sum of skipped module in modules.json #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FriederikeHanssen opened this issue Nov 9, 2022 · 3 comments
Closed

nf-core modules update changed md5sum of skipped module in modules.json #2014

FriederikeHanssen opened this issue Nov 9, 2022 · 3 comments
Labels
bug Something isn't working high-priority

Comments

@FriederikeHanssen
Copy link
Contributor

Description of the bug

Hey!

I ran nf-core modules update -a and then selected the second option (show diff and y/N before applying it). For two modules the md5sum was changed, even though I selected N and skipped the update:

see here:

https://github.com/nf-core/sarek/pull/822/files#diff-97c7fe3fe8f628d2435d00b93af4cb47052e8e1f3d33b7334d1a031fd15415d7

Command used and terminal output

nf-core modules update -a

System information

Using nf-core/tools 2.6
@FriederikeHanssen FriederikeHanssen added the bug Something isn't working label Nov 9, 2022
@mirpedrol mirpedrol mentioned this issue Nov 10, 2022
Merged
4 tasks
@mirpedrol
Copy link
Member

Fixed by #2017

@FriederikeHanssen
Copy link
Contributor Author
FriederikeHanssen commented Jun 14, 2023 •
edited
Loading

Hey! Sorry to bring this up again, but it just happened again. I am on 2.8. I ran

nf-core/modules update

? Update all modules or a single named module? All modules
? Do you want to view diffs of the proposed changes? Preview diff in terminal, choose whether to update files

? Update module 'controlfreec/makegraph'? No

Yet the markgraph checksum was updated.:

                    "controlfreec/makegraph": {
                        "branch": "master",
-                        "git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
+                        "git_sha": "83ddd598664e16f74e0b5c728e9f81285c37e893",
                        "installed_by": ["modules"]
                    },

Will fix it there manually now.

@FriederikeHanssen FriederikeHanssen mentioned this issue Jun 14, 2023
Merged
10 tasks
@mirpedrol mirpedrol mentioned this issue Jun 14, 2023
Merged
4 tasks
@mirpedrol
Copy link
Member

Now yes, fixed by #2323 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ewels @mirpedrol @FriederikeHanssen
0