8000 don't write file when applying a patch during update by mirpedrol · Pull Request #2017 · nf-core/tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

don't write file when applying a patch during update #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 14, 2022
Merged

don't write file when applying a patch during update #2017

merged 10 commits into from
Nov 14, 2022

Conversation

mirpedrol
Copy link
Member

Close #2014

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link
codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #2017 (800d180) into dev (8e81fe8) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2017      +/-   ##
==========================================
+ Coverage   63.84%   63.86%   +0.02%     
==========================================
  Files          41       41              
  Lines        4923     4923              
==========================================
+ Hits         3143     3144       +1     
+ Misses       1780     1779       -1
Impacted Files Coverage Δ
nf_core/modules/modules_differ.py 84.92% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mashehu
Copy link
Contributor
mashehu commented Nov 10, 2022

Could you maybe add a test for this?

@mirpedrol
Copy link
Member Autho 8000 r

Could you maybe add a test for this?

good idea :) I will add it before merging

mashehu
mashehu approved these changes Nov 11, 2022
View reviewed changes
mirpedrol and others added 3 commits November 11, 2022 15:41
@mirpedrol mirpedrol merged commit 564868f into nf-core:dev Nov 14, 2022
@mirpedrol mirpedrol deleted the update-sha branch November 14, 2022 10:06
@mirpedrol mirpedrol mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @mashehu
0