8000 Set zooms of non-aggressively denoised image by tsalo · Pull Request #120 · nipreps/fmripost-aroma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set zooms of non-aggressively denoised image #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Set zooms of non-aggressively denoised image #120

merged 2 commits into from
May 5, 2025

Conversation

tsalo
Copy link
Collaborator
@tsalo tsalo commented May 5, 2025

Closes #119.

Changes proposed in this pull request

  • Grab the zooms and associated units from the preprocessed BOLD image to patch into the non-aggressively denoised BOLD image. Non-aggressive denoising is the only one that doesn't rely on nilearn's NiftiMasker, which should set the zooms correctly automatically, so it's the only one that needs a special fix.

@tsalo tsalo added the bug Something isn't working label May 5, 2025
@codecov Codecov
Copy link
codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.60%. Comparing base (861303e) to head (bd47d3c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/interfaces/confounds.py 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   30.65%   30.60%   -0.06%     
==========================================
  Files          30       30              
  Lines        2424     2428       +4     
  Branches      298      298              
==========================================
  Hits          743      743              
- Misses       1658     1662       +4     
  Partials       23       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo merged commit 8988dc8 into main May 5, 2025
10 of 12 checks passed
@tsalo tsalo deleted the patch-tr branch May 9, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
4ABC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TR is not set in denoised BOLD files
1 participant
@tsalo
0