8000 CI: Simplify GitHub actions checks and update action versions by effigies · Pull Request #1141 · nipreps/mriqc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI: Simplify GitHub actions checks and update action versions #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 13, 2023
Merged

CI: Simplify GitHub actions checks and update action versions #1141

merged 9 commits into from
Sep 13, 2023

Conversation

effigies
Copy link
Member

This drops old pip and use of venv for build, and uses pipx for tools to eliminate some pip installs altogether.

It also drops the pip cache. This is generally not a bottleneck, and I'm guessing it's the cause of the space limitations @celprov mentioned in #1137.

@effigies
Copy link
Member Author

I was wrong, the cache was not the bottleneck, the 3 venvs with massive wheels unpacked into them were.

@effigies
Copy link
Member Author

On the other hand, the majority of the time of pip install does not seem to be downloading. Installation seems to take 2-3 minutes regardless of caching, and caching itself takes about 2 minutes. I'm a little inclined to re-disable it.

@effigies effigies requested a review from celprov September 12, 2023 10:29
@effigies
Copy link
Member Author

Canceling CircleCI since that seems broken and irrelevant to this PR.

@effigies effigies mentioned this pull request Sep 13, 2023
Merged
@oesteban oesteban merged commit d61bd8d into nipreps:master Sep 13, 2023
@effigies effigies deleted the ci/update-gha branch September 13, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celprov celprov Awaiting requested review from celprov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @oesteban
0