8000 refactor!: remove firebase functions in favor of firebase app hosting by Yuangwang · Pull Request #3215 · nitrojs/nitro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor!: remove firebase functions in favor of firebase app hosting #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 21, 2025
Merged

refactor!: remove firebase functions in favor of firebase app hosting #3215

merged 9 commits into from
Mar 21, 2025

Conversation

Yuangwang
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Uncomment the previously commented out firebase app hosting documentation

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Yuangwang Yuangwang requested a review from pi0 as a code owner March 11, 2025 19:04
pi0
pi0 reviewed Mar 12, 2025
View reviewed changes
pi0
pi0 reviewed Mar 12, 2025
View reviewed changes
Copy link
Member
@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, i think you might want to open a PR also against v2 (current docs) to show firebase app hosting section and we can later discuss for v3 to drop other firebase-functions variant

@Yuangwang
Copy link
Contributor Author

Thanks for PR, i think you might want to open a PR also against v2 (current docs) to show firebase app hosting section and we can later discuss for v3 to drop other firebase-functions variant

Good call, I didn't catch that earlier I have a new pr out against v2 #3217. Lets continue there

@Yuangwang Yuangwang closed this Mar 12, 2025
@Yuangwang Yuangwang mentioned this pull request Mar 12, 2025
Merged
8 tasks
@Yuangwang Yuangwang reopened this Mar 17, 2025
@pi0 pi0 changed the title docs: uncomment docs for firebase-app-hosting refactor!: remove firebase Mar 18, 2025
@pi0 pi0 changed the title refactor!: remove firebase refactor!: remove firebase functions in favor of firebase app hosting Mar 18, 2025
@pi0
Copy link
Member
pi0 commented Mar 21, 2025 •
edited
Loading

Note: We are removing legacy preset for Nitro v3 as it is on outdated versions and not actively maintained.

If in the future there is user request to add it back, we can definitely do this.

@pi0 pi0 merged commit 3845524 into nitrojs:v3 Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuangwang @pi0
0