8000 docs(firebase): add firebase-app-hosting by Yuangwang Β· Pull Request #3217 Β· nitrojs/nitro Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(firebase): add firebase-app-hosting #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Conversation

Yuangwang
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Uncomment the previously commented out firebase app hosting documentation

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.


-->

## Firebase hosting
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuing #3215 (comment)
@pi0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding deprecated notice seems good idea (note that current docs will soon be moved to v2.nitro.build as legacy)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the old docs with a new deprecated note! I'm also going to reopen the old pr and copy over these changes too. That way the changes will be reflected in the new docs too

Copy link
Member
@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❀️

@pi0 pi0 changed the title docs: uncomment docs for firebase-app-hosting docs(firebase): add firebase-app-hosting Mar 17, 2025
@pi0 pi0 merged commit 0f89254 into nitrojs:v2 Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0