8000 fix(language_server): diable nested configuration when config path is provided by Sysix · Pull Request #10385 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(language_server): diable nested configuration when config path is provided #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sysix
Copy link
Member
@Sysix Sysix commented Apr 13, 2025

This is the same behavior as oxlint:

let use_nested_config = !disable_nested_config &&
// If the `--config` option is explicitly passed, we should not search for nested config files
// as the passed config file takes absolute precedence.
basic_options.config.is_none();

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Apr 13, 2025
Copy link
Member Author
Sysix commented Apr 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review April 13, 2025 20:50
Copy link
codspeed-hq bot commented Apr 13, 2025

CodSpeed Instrumentation Performance Report

Merging #10385 will not alter performance

Comparing 04-13-fix_language_server_diable_nested_configuration_when_config_path_is_provided (664342b) with main (7508a43)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
Copy link
Member
Boshen commented Apr 14, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-13-test_editor_refactor_tests_to_use_fixtures branch from 29073d8 to 62f7d76 Compare April 14, 2025 03:08
@graphite-app graphite-app bot force-pushed the 04-13-fix_language_server_diable_nested_configuration_when_config_path_is_provided branch from bc84417 to 664342b Compare April 14, 2025 03:09
Base automatically changed from 04-13-test_editor_refactor_tests_to_use_fixtures to main April 14, 2025 03:13
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
@graphite-app graphite-app bot merged commit 664342b into main Apr 14, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-13-fix_language_server_diable_nested_configuration_when_config_path_is_provided branch April 14, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0