8000 perf(langage_server): prebuild `IsolatedLintHandler` by Sysix · Pull Request #10406 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf(langage_server): prebuild IsolatedLintHandler #10406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Sysix
Copy link
Member
@Sysix Sysix commented Apr 14, 2025

Now we build the linter on init_linter_config and not when we are linting one file in handle_file_update.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 14, 2025
Copy link
Member Author
Sysix commented Apr 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
codspeed-hq bot commented Apr 14, 2025

CodSpeed Instrumentation Performance Report

Merging #10406 will not alter performance

Comparing 04-14-perf_langage_server_prebuild_isolatedlinthandler_ (21f3175) with main (af635fb)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
Copy link
Member
Boshen commented Apr 16, 2025

Merge activity

  • Apr 16, 2:58 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 16, 2:58 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Apr 16, 7:27 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
  • Apr 16, 12:47 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 16, 2:42 PM EDT: shulaoda added this pull request to the Graphite merge queue.
  • Apr 16, 2:42 PM EDT: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 04-06-feat_language_server_use_linter_runtime branch from b3b3054 to bb8a078 Compare April 16, 2025 06:59
graphite-app bot pushed a commit that referenced this pull request Apr 16, 2025
Now we build the linter on `init_linter_config` and not when we are linting one file in `handle_file_update`.
@graphite-app graphite-app bot force-pushed the 04-14-perf_langage_server_prebuild_isolatedlinthandler_ branch from 7ef3bc5 to 3f9bcd2 Compare April 16, 2025 07:00
Base automatically changed from 04-06-feat_language_server_use_linter_runtime to main April 16, 2025 07:06
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
@shulaoda shulaoda added the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
Now we build the linter on `init_linter_config` and not when we are linting one file in `handle_file_update`.
@Sysix Sysix force-pushed the 04-14-perf_langage_server_prebuild_isolatedlinthandler_ branch from 3f9bcd2 to 21f3175 Compare April 16, 2025 18:37
@graphite-app graphite-app bot merged commit 21f3175 into main Apr 16, 2025
30 checks passed
@graphite-app graphite-app bot deleted the 04-14-perf_langage_server_prebuild_isolatedlinthandler_ branch April 16, 2025 18:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0