Add JSON/YAML output options to namespace list #4719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in output, and fixed unit tests Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
|
Tests done: Sample of plain output Sample with JSON output: Sample with YAML output: Output when wrong output option is specified (the same that happens with namespace list command): |
There was a problem hiding this comment.
Pull Request Overview
Adds support for JSON/YAML output modes to the okteto namespace list command, including flag parsing, output formatting, and corresponding unit tests.
- Introduces a new
--outputflag with validation forjsonandyaml - Implements
displayListNamespacesandgetNamespaceOutputto render in table, JSON, or YAML - Adds unit tests for output validation and formatted output cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/namespace/list.go | Add --output flag, validate formats, implement JSON/YAML/table output functions |
| cmd/namespace/list_test.go | Update existing test for new signature and add tests for validateNamespaceListOutput and displayListNamespaces |
Comments suppressed due to low confidence (1)
cmd/namespace/list_test.go:78
- Add a test case that calls
executeListNamespaceswith an invalid format (for example, "xml") to assert that it returnserrInvalidOutput.
err := nsCmd.executeListNamespaces(ctx, "")
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
|
Closing in favor of #4722 to make the CI pass as CI secrets are not injected on PRs coming from a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--outputflag forokteto namespace listTesting
make test(fails: cannot download modules)