Fixes #4714. Added output option to namespace list command to specify json or yaml #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… json or yaml Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4722 +/- ##
==========================================
+ Coverage 48.80% 48.83% +0.02%
==========================================
Files 354 354
Lines 29638 29683 +45
==========================================
+ Hits 14466 14496 +30
- Misses 14019 14030 +11
- Partials 1153 1157 +4 🚀 New features to boost your workflow:
|
jLopezbarb
approved these changes
May 26, 2025
cmd/namespace/list.go
Outdated
| switch output { | ||
| case "json": | ||
| if len(namespaces) == 0 { | ||
| fmt.Println("[]") |
There was a problem hiding this comment.
NIT: Should we use our own implementation of ioCtrl?
There was a problem hiding this comment.
I did it in the last commit. I have to add a lot of changes to leave all the namespace commands ready to use the io.Controller: 60016a1
…e-list-output-option Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
jLopezbarb
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #4714
Added an
outputoption in the namespace list command analogous to the one we have inpreview listcommand. Possible values arejsonoryaml, and it changes the output accordinglyHow to validate
Connect with an Okteto instance and run
okteto namespace listwith the CLI built from this branch to verify that the expected output is returned. If no output is specified, we return the plain output as we were doing until nowSamples of outputs: