-
Notifications
You must be signed in to change notification settings - Fork 10
[feat] Add Stateful
trait
#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0950c6
to
8005259
Compare
jonathanpwang
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trait seems fine, let's discuss naming a little
8005259
to
db5d51e
Compare
db5d51e
to
6465d0b
Compare
Stateful
trait
@nyunyunyunyu merge? |
hmm @nyunyunyunyu I wonder if we want |
jonathanpwang
added a commit
that referenced
this pull request
Jun 3, 2025
leonardoalt
pushed a commit
to powdr-labs/stark-backend
that referenced
this pull request
Jun 3, 2025
* perf: cpu `TraceCommitter` should reserve capacity for LDE (openvm-org#68) * perf: avoid needless clones in permutation trace commit (openvm-org#69) * perf: `transmute_to_base` to avoid needless clones * chore: add note about p3 PR * chore: add debug asserts for safety * feat!: drop main trace earlier for lower peak memory (openvm-org#71) * feat: drop main trace earlier for lower peak memory * fix: trace_metrics * chore: log quotient poly cells (openvm-org#72) * feat: reserve capacity for perm & quotient LDE; avoid copy for quotient split (openvm-org#73) * chore: log quotient poly cells * feat: perm trace reserve extra capacity * feat: quotient no-resize and no-copy * fix: small trace heights * fix: misunderstanding of vertical striding * chore: clarify comment * chore: bump workspace version to `1.0.1` (openvm-org#74) * release: v1.1.0 (openvm-org#76) * feat: update security parameters (openvm-org#20) * chore: update status in readme (openvm-org#21) closes INT-4015 * fix: account for poles in log up security calculation (openvm-org#22) * chore: update readme * fix(plonky3): update plonky3 commit for security fix --------- Co-authored-by: Zach Langley <zblangley@gmail.com> * perf: optimize `compute_quotient_values` (openvm-org#75) * chore: rename keccak example to keccakf * feat: add example to bench compute_quotient and readme * chore: add bench script * chore: update profile script to use perf on linux * feat: `parallelize_chunks` * feat: allocate once per thread * feat: share alpha_powers and avoid `Vec::push` * chore: bump workspace version * feat: Export metrics to Prometheus server (openvm-org#70) * Add metrics exporter * Add tracing context * Fix tokio * Revert "Fix tokio" This reverts commit fdd16a8. * Install crypto provider * Increase interval length * Feature gate * Small fixes * chore: remove unused modules (openvm-org#77) --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Zach Langley <zblangley@gmail.com> Co-authored-by: Manh Dinh <manh9203@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.