8000 [feat] Add `Stateful` trait by nyunyunyunyu · Pull Request #20 · openvm-org/stark-backend · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[feat] Add Stateful trait #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2025
Merged

[feat] Add Stateful trait #20

merged 2 commits into from
Jan 12, 2025

Conversation

nyunyunyunyu
Copy link
Contributor

No description provided.

@nyunyunyunyu nyunyunyunyu force-pushed the feat/state-persist branch 2 times, most recently from a0950c6 to 8005259 Compare January 8, 2025 16:37
@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review January 8, 2025 16:37
Copy link
Contributor
@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trait seems fine, let's discuss naming a little

@jonathanpwang jonathanpwang changed the title [feat] Add PersistStateChip trait [feat] Add Stateful trait Jan 9, 2025
@jonathanpwang
Copy link
Contributor

@nyunyunyunyu merge?

@jonathanpwang
Copy link
Contributor

hmm @nyunyunyunyu I wonder if we want load_state to take in a deserializer so we don't require global changes to switch bincode to bitcode etc?

@nyunyunyunyu nyunyunyunyu merged commit 25265e7 into main Jan 12, 2025
3 checks passed
@nyunyunyunyu nyunyunyunyu deleted the feat/state-persist branch January 12, 2025 07:32
jonathanpwang added a commit that referenced this pull request Jun 3, 2025
jonathanpwang added a commit that referenced this pull request Jun 3, 2025
* feat: update security parameters (#20)

* chore: update status in readme (#21)

closes INT-4015

* fix: account for poles in log up security calculation (#22)

* chore: update readme

* fix(plonky3): update plonky3 commit for security fix

---------

Co-authored-by: Zach Langley <zblangley@gmail.com>
leonardoalt pushed a commit to powdr-labs/stark-backend that referenced this pull request Jun 3, 2025
* perf: cpu `TraceCommitter` should reserve capacity for LDE (openvm-org#68)

* perf: avoid needless clones in permutation trace commit (openvm-org#69)

* perf: `transmute_to_base` to avoid needless clones

* chore: add note about p3 PR

* chore: add debug asserts for safety

* feat!: drop main trace earlier for lower peak memory (openvm-org#71)

* feat: drop main trace earlier for lower peak memory

* fix: trace_metrics

* chore: log quotient poly cells (openvm-org#72)

* feat: reserve capacity for perm & quotient LDE; avoid copy for quotient split (openvm-org#73)

* chore: log quotient poly cells

* feat: perm trace reserve extra capacity

* feat: quotient no-resize and no-copy

* fix: small trace heights

* fix: misunderstanding of vertical striding

* chore: clarify comment

* chore: bump workspace version to `1.0.1` (openvm-org#74)

* release: v1.1.0 (openvm-org#76)

* feat: update security parameters (openvm-org#20)

* chore: update status in readme (openvm-org#21)

closes INT-4015

* fix: account for poles in log up security calculation (openvm-org#22)

* chore: update readme

* fix(plonky3): update plonky3 commit for security fix

---------

Co-authored-by: Zach Langley <zblangley@gmail.com>

* perf: optimize `compute_quotient_values` (openvm-org#75)

* chore: rename keccak example to keccakf

* feat: add example to bench compute_quotient and readme

* chore: add bench script

* chore: update profile script to use perf on linux

* feat: `parallelize_chunks`

* feat: allocate once per thread

* feat: share alpha_powers and avoid `Vec::push`

* chore: bump workspace version

* feat: Export metrics to Prometheus server (openvm-org#70)

* Add metrics exporter

* Add tracing context

* Fix tokio

* Revert "Fix tokio"

This reverts commit fdd16a8.

* Install crypto provider

* Increase interval length

* Feature gate

* Small fixes

* chore: remove unused modules (openvm-org#77)

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Co-authored-by: Zach Langley <zblangley@gmail.com>
Co-authored-by: Manh Dinh <manh9203@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0