feat!: drop main trace earlier for lower peak memory #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaxiom
approved these changes
Apr 30, 2025
leonardoalt
pushed a commit
to powdr-labs/stark-backend
that referenced
this pull request
Jun 3, 2025
* perf: cpu `TraceCommitter` should reserve capacity for LDE (openvm-org#68) * perf: avoid needless clones in permutation trace commit (openvm-org#69) * perf: `transmute_to_base` to avoid needless clones * chore: add note about p3 PR * chore: add debug asserts for safety * feat!: drop main trace earlier for lower peak memory (openvm-org#71) * feat: drop main trace earlier for lower peak memory * fix: trace_metrics * chore: log quotient poly cells (openvm-org#72) * feat: reserve capacity for perm & quotient LDE; avoid copy for quotient split (openvm-org#73) * chore: log quotient poly cells * feat: perm trace reserve extra capacity * feat: quotient no-resize and no-copy * fix: small trace heights * fix: misunderstanding of vertical striding * chore: clarify comment * chore: bump workspace version to `1.0.1` (openvm-org#74) * release: v1.1.0 (openvm-org#76) * feat: update security parameters (openvm-org#20) * chore: update status in readme (openvm-org#21) closes INT-4015 * fix: account for poles in log up security calculation (openvm-org#22) * chore: update readme * fix(plonky3): update plonky3 commit for security fix --------- Co-authored-by: Zach Langley <zblangley@gmail.com> * perf: optimize `compute_quotient_values` (openvm-org#75) * chore: rename keccak example to keccakf * feat: add example to bench compute_quotient and readme * chore: add bench script * chore: update profile script to use perf on linux * feat: `parallelize_chunks` * feat: allocate once per thread * feat: share alpha_powers and avoid `Vec::push` * chore: bump workspace version * feat: Export metrics to Prometheus server (openvm-org#70) * Add metrics exporter * Add tracing context * Fix tokio * Revert "Fix tokio" This reverts commit fdd16a8. * Install crypto provider * Increase interval length * Feature gate * Small fixes * chore: remove unused modules (openvm-org#77) --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Zach Langley <zblangley@gmail.com> Co-authored-by: Manh Dinh <manh9203@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the traits slightly so that traces are passed without borrowing. The main reason is the realization that preprocessed and main traces are only used to generate the permutation trace, so they can be dropped immediately after this step (in
partially_prove). Afterwards, only LDEs need to be used.There is some improvement in how the handling of preprocessed / cached trace is done: sometimes you may want to not drop these (so they really stay in memory) and sometimes you may want to drop it to lower peak memory. Maybe some
Shared**type may make this clearer, but for now I just opted to use owned versions of everything because in practice we are using smart pointers (Arc) around everything, so one can get around sharing with some cloning if necessary.Note that right now the preprocessed trace is never dropped, because the proving key holds onto a copy until
Openingis called. We could get around this with some extraOptionusage, but since the size of preprocessed trace is currently small I'll leave it for later.https://github.com/axiom-crypto/openvm-reth-benchmark/actions/runs/14749714037/job/41404170207