10000 Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Macs by andylin2004 · Pull Request #22315 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Macs #22315

Merged
merged 6 commits into from
May 12, 2021
Merged

Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Macs #22315

merged 6 commits into from
May 12, 2021

Conversation

andylin2004
Copy link
Contributor
@andylin2004 andylin2004 commented Apr 30, 2021 •
edited
Loading

Issue or RFC Endorsed by Atom's Maintainers

#21128

Description of the Change

I replaced the older default icon for Atom with the Big Sur-style icon for Atom for Macs only. Windows icons is still the same.

Alternate Designs

  • Keeping the icon as is: it would fail to fit within the Apple icon design for Big Sur.
  • Replacing all icons: there has not been any major icon overhaul on Windows that necessitate an icon change for Windows too.
  • Separating the icon based on what macOS version the user is using: there isn't an implementation of this in Electron.

Possible Drawbacks

  • Mac users using macOS Catalina and below will see the Big Sur-esque icon instead of the OS X Yosemite-esque icon.

Verification Process

The verification process is not needed, as this is just an icon swap with the same file extension (between the icon being replaced and replacement icon).

Release Notes

The app icon on macOS has been changed to reflect the style in macOS Big Sur.

@andylin2004 andylin2004 changed the title Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Max Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Macs Apr 30, 2021
@chiss22
Copy link
chiss22 commented May 6, 2021

Thank you! It looks beautiful!

sadick254
sadick254 reviewed May 11, 2021
View reviewed changes
Copy link
Contributor
@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I would be glad if you could also add icons for nightly and beta versions of Atom.

sadick254
sadick254 reviewed May 12, 2021
View reviewed changes
Copy link
Contributor
@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for deleting beta/atom.icns

@andylin2004
Copy link
Contributor Author

Screen Shot 2021-05-12 at 10 09 45 AM It was not deleted--I think that because I changed the beta icon to look more like the Big Sur icons, the file size became smaller. Refer to the screenshot of my local git of Atom that have already been pushed to my remote.

@sadick254 sadick254 closed this May 12, 2021
@sadick254 sadick254 reopened this May 12, 2021
@sadick254 sadick254 merged commit 91a70c7 into atom:master May 12, 2021
This was referenced Jul 28, 2021
Open
Open
@jasoncoker925
Copy link

I want to invest in your company 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadick254 sadick254 sadick254 approved these changes

Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andylin2004 @chiss22 @jasoncoker925 @sadick254
0