8000 feat: add new extension registry functions by moritzraho · Pull Request #28 · adobe/aio-cli-lib-console · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add new extension registry functions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jul 28, 2021
Merged

feat: add new extension registry functions #28

merged 23 commits into from
Jul 28, 2021

Conversation

moritzraho
Copy link
Member
@moritzraho moritzraho commented Jun 29, 2021 •
edited by shazron
Loading

Description

required for adobe/aio-cli-plugin-app#417
depends on adobe/aio-lib-console#22
Minor version bump since we only added functionality and there are no breaking changes.

Before merge, revert these commits

  • re-enable unit tests (git revert 4d160aa)
  • update dependencies version of @adobe/aio-lib-console to the released version (remove next tag)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho mentioned this pull request Jun 29, 2021
Merged
15 tasks
@codecov
Copy link
codecov bot commented Jul 15, 2021 •
edited
Loading

Codecov Report

Merging #28 (6406083) into master (2967b2a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          451       506   +55     
  Branches        71        78    +7     
=========================================
+ Hits           451       506   +55
Impacted Files Coverage Δ
lib/validate.js 100.00% <ø> (ø)
lib/console-cli.js 100.00% <100.00%> (ø)
lib/pure-helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2967b2a...6406083. Read the comment docs.

@shazron
Copy link
Member
shazron commented Jul 15, 2021

re-enabled npm test -- all unit tests pass and code coverage is 100%

@shazron shazron mentioned this pull request Jul 27, 2021
Closed
22 tasks
@shazron shazron closed this Jul 28, 2021
@shazron shazron reopened this Jul 28, 2021
@shazron shazron changed the title Release ext reg feat: add new extension registry functions Jul 28, 2021
@purplecabbage purplecabbage merged commit 7fd0ca3 into master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moritzraho @shazron @purplecabbage @sandeep-paliwal
0