breaking change: add new Extension Registry APIs, removed old APIs #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unit tests Updated api.json TODO - update param JSdoc definitions
Removed old app registry APIs and related tests.
Updated tests. Updated docs.
Updated unit tests Added e2e tests removed previously added apis from spec and they are not part of transporter API now. Updated docs.
to run tests manually, use `npm run unit-tests` instead.
|
@sandeep-paliwal Please review any remaining review comments in #20 (review) #20 |
12 tasks
22 tasks
This reverts commit 274dd69.
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 487 458 -29
Branches 15 16 +1
=========================================
- Hits 487 458 -29
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XR APIs for console sdk
Major version bumpsince endpoints are removed (breaking change).TODO add e2e tests once APIs are live
Before merge, revert these changes
npm test(git revert 274dd69)Description
Related Issue
Motivation and Context
How Has This Been Tested?
TODO
Screenshots (if appropriate):
Types of changes
Checklist: