Add XR apis to sdk #20
Conversation
Added unit tests Updated api.json TODO - update param JSdoc definitions
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 487 458 -29
Branches 15 16 +1
=========================================
- Hits 487 458 -29
Continue to review full report at Codecov.
|
|
Thanks @moritzraho for the comments. |
|
@sandeep-paliwal good thoughts but no one is using this api in the sdk. We discussed this with @meryllblanchet and @fmeschbe I think it is safe to delete those apis. |
|
@sandeep-paliwal @moritzraho these APIs should not be exposed within the library and do not serve any 3rd party extensibility purpose. No deprecation needed IMO. cc @fmeschbe |
Removed old app registry APIs and related tests.
src/index.js
Outdated
| * @param {number} [options.pageSize] page size | ||
| * @returns {Promise<Response>} the response | ||
| */ | ||
| async getAllExtensionPoints (organizationId, xpId, options = {}) { |
There was a problem hiding this comment.
It's probably early without the API working but we will need to make xpId optional and set the default as per https://adobeio.slack.com/archives/CSCQ8CQQJ/p1617827196029200?thread_ts=1617781290.014700&cid=CSCQ8CQQJ
There was a problem hiding this comment.
xpId was a required param as per the shared swagger spec. Anyway there is new spec available and we will need to make changes to SDK as per that.
There was a problem hiding this comment.
Looks like there is no change to the param in this API. We should still make this change IMO.
Updated tests. Updated docs.
Updated unit tests Added e2e tests removed previously added apis from spec and they are not part of transporter API now. Updated docs.
|
@sandeep-paliwal can you get this change into your PR branch: https://github.com/adobe/aio-lib-console/pull/21/files Jesse put it against master so it can't be merged via Github into this PR |
to run tests manually, use `npm run unit-tests` instead.
|
Moved to #22. Please review any pending changes due to review in this PR that needs to be migrated to the new PR. |
XR APIs for console sdk
TODO add e2e tests once APIs are live
Before merge, revert these changes
npm test(git revert 274dd69)Description
Related Issue
Motivation and Context
How Has This Been Tested?
TODO
Screenshots (if appropriate):
Types of changes
Checklist: