MWPW-173586: Dexter modals deeplink -backwards compatibility for 3in1 #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yesil
approved these changes
May 19, 2025
npeltier
approved these changes
May 19, 2025
libs/blocks/merch/merch.js
Outdated
| @@ -259,6 +259,18 @@ export const CHECKOUT_ALLOWED_KEYS = [ | |||
| 'marketSegment', | |||
| ]; | |||
|
|
|||
| /** | |||
| * Used when 3in1 modals are configured with ms=e or cs=t extra paramter, but 3in1 is diabled. | |||
|
looks good to me. @Roycethan feel free to double check. |
skholkhojaev
added a commit
to skholkhojaev/milo
that referenced
this pull request
May 22, 2025
* [MWPW-168459] - A11y fixes for Gnav Promo, cross cloud menu and footer feature links (adobecom#4076) * A11y fixes for Gnav Promo, cross cloud menu and footer feature links * list and UT fixes * Footer Nala fixes * Resolved review comments * Resolved review comments * lint fix * Reveiw comment fix * add review comments * Added fix for clickable headline read only in mobile * Added fix for clickable headline read only in mobile * Lint Fix * Added fix for footer menu links open/close state * Lint, UT and Css fix for feature products * Lint Fix * Nala fix * Nala fix --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * Adding Color white variable for standalone gnav and adding non milo locale path link transform in region nav (adobecom#4175) * Adding Color white variable * Adding support for non locale prefix sites * Adding --modal-close-accent-color for standalone gnav * MWPW-173586: Dexter modals deeplink -backwards compatibility for 3in1 (adobecom#4184) * MWPW-173586: Dexter modals deeplink -backwards compatibility for 3in1 * fix regression * address review comments * [MWPW-171327] Table sticky heading (adobecom#4054) * [MWPW-171327] - talbe sticky percentage * [MWPW-171327] - update percentage * [MWPW-171327] - update * [MWPW-171327] - shorten code * [MWPW-171327] - variable rename * [MWPW-171327] - logic and test update * [MWPW-171327] - code shorten * [MWPW-171327] - update * [MWPW-171327] - update * [MWPW-171327] - boundary moved, remove cancel sticky added * [MWPW-171327] - optimize code * MWPW-169899: add custom deeplink for Tabs (adobecom#4085) * MWPW-169899: support custom deeplink for tabs * add tests * MWPW-172916 Pep prompt is seen loaded and redirected when geo popup is on and not closed (adobecom#4088) * Fixed a problem where PEP loaded before the Georouting modal had a chance to load * Cleanup the getConfig().georouting object once it's no longer needed * added a comment explaining why we're putting a promise into getConfig() in loadPostLCP * Fixed pep unit tests * config.georouting.loadedPromise needs to have a fallback value in case georouting is off * Adding arrow Up/Down navigation for localnav (adobecom#4092) * Adding arrow navigation for localnav * lint fix * Adding support for nested dropdown * Applying inert attribute if localnav is closed * lint fix * Removing inert as not supported in old browsers and firefox * lint fix * lint fix * lint fix * Adding item wrapper back * MWPW-172474: await merch service before (adobecom#4107) rendering a merch card * [MWPW-158022] - Text block bold break (adobecom#4138) * [MWPW-158022] - text block bold line break fix * [MWPW-158022] - css solution * [MWPW-158022] - solution update * MWPW-173130: Preserve regular links in merch-card footers (adobecom#4139) * MWPW-173130: Preserve regular links in merch-card footers * nala and fixes * unit test * nala fix * MWPW-173130 lanafix (adobecom#4143) MWPW-173130: fix lana regression --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * Standalone Gnav Link transformation support for hosts other than stage.adobe.com (adobecom#4140) * Adding current domain in stage Domain map * Moving top nav wrapper variable to styles.css as it is overriding standalone gnav height * Fix for adobe url * MWPW-172950: Replace blockquote with p (adobecom#4145) * MWPW-172950: Replace blockquote with p * MWPW-172950: Use div instead p * Test Urls are not getting added when PR is created from fork repo (adobecom#4183) * WIP * Adding region nav and navigation folder to track list for test urls * Adding feds components to track list * MWPW-173649 CWV Logging Updates (adobecom#4173) * MWPW-173649 CWV Logging Updates * Revert "Improve carousel accessibility" (adobecom#4194) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016. * Fixing Missing/Mismatched attributes in PageView call payload (adobecom#4073) * Missing/Mismatched Attributes * Missing/Mismatched Attributes * Adding requested changes * Fixing Locale Issue * Fixing Locale Issue * Updating helpers.md * Fixing Errors * Fixing Errors * Fixing Errors * Fixing Errors * Fixing Errors * Updated Attributes + Deletions * Updated Attributes + Deletions * Updated Attributes + Deletions * Fixing Errors * Fixing Errors * Fixing Errors * Fixing setEvent - secondVisits * Fixing setEvent - secondVisits * Fixing consent issue for secondHit * Fixing acrobatSecondVisit * Fixing locale Bug * Fixing errors * Fixing errors * Fixing errors --------- Co-authored-by: Akansha Arora <> * MWPW-172085, 173254, 173501, 173732, 173083 [MEP][MMM] Batch PR for Stage (adobecom#4124) * added filtering of page manifests by filter params * added filtering of page manifests by filter params * conf * first commit * temporarily disabled ajo and placeholder manifestsrc options * MWPW-173501 [MMM][MEP] Add geo filter to MMM Target cleanup report (adobecom#4172) * enabled geo filter on mmm-target-cleanup * change naming for base vs targetCleanUp vars * MWPW-173732 [MMM][MEP] Add contextually relevant button in Target Metadata Lookup Report (adobecom#4192) * first commit * add button selector for .instructions text block * Refactor metadata URLs in createMetadataLookup function for improved structure and clarity * Add TARGET_METADATA_OPTIONS for improved metadata handling in createMetadataLookup * Update label text for last seen manifests dropdown for mmm and mep-target-inactivity * Refactor metadata lookup to use updated search function for selectedRepo --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * [MWPW-173083] [MEP][MMM] Add history from MMM to MEP button in page (adobecom#4162) * Initial che 8000 ckin. Good state. * Naming conventions. Fix sticky marquee logic. * Variant name update. * Alignment fix. * Update with hide at action area logic. * Updated as per PR comment. * Marquee updates, first pass. * Var1 marquee button rework. * Possible custom-hide fix. * Initial checkin. Fetch manifests API. Generate HTML. * Headers, divider logic, change events, hide selected, 'non' select option logic. * Update to duplicate manifest logic. * Remove console log. * Linting. * Unit test update. * Label/select rename. Don't update button for hidden experiences. Default MMM to none. * Hidden option button update fix. * Unit Testing. * Update libs/features/personalization/preview.js * Remove placeholder domain. * Update manifest option titles for clarity in preview.js * Update option title for clarity in getManifestListDomAndParameter function --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment has not loaded (Desktop & Mobile) (adobecom#4137) * Parallelize the network calls required before the gnav becomes visible * corrected the logic for loading base styles for non-milo contexts * load aside.js in parallel if necessary * made the logic inside getGnavSource a little more fault tolerant * Fixed an issue with loading the dark mode gnav (standalone) * changed the gnav tests to reload the global-navigation.js module anew on each test to work correctly with the performance optimizations * Fixed a test for localnav inside bootstrapper.test.js * ignore eslint error on a test * added error handling to the style loading logic in gnav * changed error handling for loading gnav styles from throwing an error to rejecting a promise * removed some redundant code * changed e.message to e * implemented the loading state for desktop viewports * Change animation name as it was the same as one that the unav uses * implemented the loading state for mobile * Removed pointer events from the loading state; made the loading state closer to the specs * Finishing touches * Don't have a loading state for the legacy mobile gnav * add the loading state only on async Dropdowns; decorateLocalnav should be inside decorateMenu.then(...) * put the call to `decorateLocalNavItems` inside `finally` to make sure it runs * lint fixes * Sometimes mobileNavCleanup can be null * Removed an extraneous line * Cleaning up the merge conflict resolution * Make sure `transformTemplateToMobile` always returns a function * [MWPW-173341] - Added ally fix for GNAV Promo heading text (adobecom#4151) Added ally fix for GNAV Promo heading text Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * Removing text decoration none from region nav links (adobecom#4188) * [MWPW-170714] - Section metadata grid (adobecom#4097) * [MWPW=170714] - section data mobile margin * [MWPW=170714] - section two up metadata change * [MWPW-170714] - update mobile gap solution * [MWPW-170714] - remove media query * MWPW-173121: Tax Exclusive & ABM labels for Plans body prices (adobecom#4120) * MWPW-170799: Remove external.js and refactor imports. * fix regressions * fix regressions * fix checks * fix checks * still regression in variants * fix regression on ccd ah styles * disable aggressive PR comments * remove unused file * fix regressions * fix error in doc page * PR review * fix regression in variant mappings * fix plans url * cleanup constants * merge stage and fix regressions * MWPW-164498: Plans Education card * styles * plans page update * heading global styles * phas * block * business plans initial draft * fix badge * spacing and growing * height and styles * collection styles * remove whats included from education * removed whats included in some other way * Plans students aem mapping * milo plans page style updates * removed hardcoded link color * link fix * MWPW-173121: ABM label for Plans body prices * unit test --------- Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * Mwpw 170301 focus outside modal (adobecom#4155) * MWPW-170301: Hide cookie banner when modal is open Revert "MWPW-170301: Keep focus inside the modal" This reverts commit df02548. MWPW-170301: Hide cookie banner when modal is open * MWPW-170301: Move isDeepLink to getModal * MWPW-170301: Add deepLink property to details * MWPW-171825 Improve lcp performance for favicon and breadcrumb (adobecom#4163) * Breadcrumb last item value as current window url if not a link (adobecom#4166) * Breadcrumb last item value as current window url if not a link * Breadcrumb test case fix * Breadcrumb Lint fix * Breadcrumb Lint fix * Quiz option titles on mobile (adobecom#4190) * show titles on mobile * add support for rtl for option titles Resolves: [MWPW-173478](https://jira.corp.adobe.com/browse/MWPW-173478) * MWPW-173816: remove stock checks temporarily (adobecom#4208) * Revert "MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment has not loaded (Desktop & Mobile)" (adobecom#4210) Revert "MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment…" This reverts commit 02289eb. * [MWPW-173470] - Korea free trial restrict (adobecom#4185) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error * Base mweb style changes (adobecom#4187) * MWPW-173239: fallback for addon (adobecom#4200) * MWPW-173239: fallback for addon * add unit test * address review comments --------- Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending revi
2BA2
ews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If its a 3in1 Modal, but 3in1 is disabled - turn '3in1' style deeplinks into dexter deeplinks.
ms=e becomes plan=edu
cs=t becomes plan=team
To test on Milo you need modheader (cors issues on feature branches)
To test without modheader use CC test page: https://main--cc--adobecom.aem.page/drafts/mariia/3in1off?milolibs=mwpw-173586
https://jira.corp.adobe.com/browse/MWPW-173586
Test URLs: