Improve carousel accessibility #4103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JasonHowellSlavin
approved these changes
May 8, 2025
DKos95
approved these changes
May 9, 2025
| @@ -179,6 +178,13 @@ function setIndicatorMultiplyer(carouselElements, activeSlideIndicator, event) { | |||
| } | |||
| } | |||
|
|
|||
| function updateAriaLive(ariaLive, slide) { | |||
There was a problem hiding this comment.
NIT: Does this really need to be a function?
There was a problem hiding this comment.
Not really, but to me it looks cleaner this way, than adding the forEach in moveSlides
|
Reminder to set the |
SilviuLCF
approved these changes
May 12, 2025
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-172184
ivanvatadobe
pushed a commit
that referenced
this pull request
May 15, 2025
* Improve carousel accessibility * add visibility hidden * clear timeout * update nala tests
mokimo
added a commit
to mokimo/milo
that referenced
this pull request
May 20, 2025
This reverts commit 34d2016.
mokimo
pushed a commit
that referenced
this pull request
May 20, 2025
skholkhojaev
added a commit
to skholkhojaev/milo
that referenced
this pull request
May 22, 2025
* [MWPW-168459] - A11y fixes for Gnav Promo, cross cloud menu and footer feature links (adobecom#4076) * A11y fixes for Gnav Promo, cross cloud menu and footer feature links * list and UT fixes * Footer Nala fixes * Resolved review comments * Resolved review comments * lint fix * Reveiw comment fix * add review comments * Added fix for clickable headline read only in mobile * Added fix for clickable headline read only in mobile * Lint Fix * Added fix for footer menu links open/close state * Lint, UT and Css fix for feature products * Lint Fix * Nala fix * Nala fix --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * Adding Color white variable for standalone gnav and adding non milo locale path link transform in region nav (adobecom#4175) * Adding Color white variable * Adding support for non locale prefix sites * Adding --modal-close-accent-color for standalone gnav * MWPW-173586: Dexter modals deeplink -backwards compatibility for 3in1 (adobecom#4184) * MWPW-173586: Dexter modals deeplink -backwards compatibility for 3in1 * fix regression * address review comments * [MWPW-171327] Table sticky heading (adobecom#4054) * [MWPW-171327] - talbe sticky percentage * [MWPW-171327] - update percentage * [MWPW-171327] - update * [MWPW-171327] - shorten code * [MWPW-171327] - variable rename * [MWPW-171327] - logic and test update * [MWPW-171327] - code shorten * [MWPW-171327] - update * [MWPW-171327] - update * [MWPW-171327] - boundary moved, remove cancel sticky added * [MWPW-171327] - optimize code * MWPW-169899: add custom deeplink for Tabs (adobecom#4085) * MWPW-169899: support custom deeplink for tabs * add tests * MWPW-172916 Pep prompt is seen loaded and redirected when geo popup is on and not closed (adobecom#4088) * Fixed a problem where PEP loaded before the Georouting modal had a chance to load * Cleanup the getConfig().georouting object once it's no longer needed * added a comment explaining why we're putting a promise into getConfig() in loadPostLCP * Fixed pep unit tests * config.georouting.loadedPromise needs to have a fallback value in case georouting is off * Adding arrow Up/Down navigation for localnav (adobecom#4092) * Adding arrow navigation for localnav * lint fix * Adding support for nested dropdown * Applying inert attribute if localnav is closed * lint fix * Removing inert as not supported in old browsers and firefox * lint fix * lint fix * lint fix * Adding item wrapper back * MWPW-172474: await merch service before (adobecom#4107) rendering a merch card * [MWPW-158022] - Text block bold break (adobecom#4138) * [MWPW-158022] - text block bold line break fix * [MWPW-158022] - css solution * [MWPW-158022] - solution update * MWPW-173130: Preserve regular links in merch-card footers (adobecom#4139) * MWPW-173130: Preserve regular links in merch-card footers * nala and fixes * unit test * nala fix * MWPW-173130 lanafix (adobecom#4143) MWPW-173130: fix lana regression --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * Standalone Gnav Link transformation support for hosts other than stage.adobe.com (adobecom#4140) * Adding current domain in stage Domain map * Moving top nav wrapper variable to styles.css as it is overriding standalone gnav height * Fix for adobe url * MWPW-172950: Replace blockquote with p (adobecom#4145) * MWPW-172950: Replace blockquote with p * MWPW-172950: Use div instead p * Test Urls are not getting added when PR is created from fork repo (adobecom#4183) * WIP * Adding region nav and navigation folder to track list for test urls * Adding feds components to track list * MWPW-173649 CWV Logging Updates (adobecom#4173) * MWPW-173649 CWV Logging Updates * Revert "Improve carousel accessibility" (adobecom#4194) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016. * Fixing Missing/Mismatched attributes in PageView call payload (adobecom#4073) * Missing/Mismatched Attributes * Missing/Mismatched Attributes * Adding requested changes * Fixing Locale Issue * Fixing Locale Issue * Updating helpers.md * Fixing Errors * Fixing Errors * Fixing Errors * Fixing Errors * Fixing Errors * Updated Attributes + Deletions * Updated Attributes + Deletions * Updated Attributes + Deletions * Fixing Errors * Fixing Errors * Fixing Errors * Fixing setEvent - secondVisits * Fixing setEvent - secondVisits * Fixing consent issue for secondHit * Fixing acrobatSecondVisit * Fixing locale Bug * Fixing errors * Fixing errors * Fixing errors --------- Co-authored-by: Akansha Arora <> * MWPW-172085, 173254, 173501, 173732, 173083 [MEP][MMM] Batch PR for Stage (adobecom#4124) * added filtering of page manifests by filter params * added filtering of page manifests by filter params * conf * first commit * temporarily disabled ajo and placeholder manifestsrc options * MWPW-173501 [MMM][MEP] Add geo filter to MMM Target cleanup report (adobecom#4172) * enabled geo filter on mmm-target-cleanup * change naming for base vs targetCleanUp vars * MWPW-173732 [MMM][MEP] Add contextually relevant button in Target Metadata Lookup Report (adobecom#4192) * first commit * add button selector for .instructions text block * Refactor metadata URLs in createMetadataLookup function for improved structure and clarity * Add TARGET_METADATA_OPTIONS for improved metadata handling in createMetadataLookup * Update label text for last seen manifests dropdown for mmm and mep-target-inactivity * Refactor metadata lookup to use updated search function for selectedRepo --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * [MWPW-173083] [MEP][MMM] Add history from MMM to MEP button in page (adobecom#4162) * Initial checkin. Good state. * Naming conventions. Fix sticky marquee logic. * Variant name update. * Alignment fix. * Update with hide at action area logic. * Updated as per PR comment. * Marquee updates, first pass. * Var1 marquee button rework. * Possible custom-hide fix. * Initial checkin. Fetch manifests API. Generate HTML. * Headers, divider logic, change events, hide selected, 'non' select option logic. * Update to duplicate manifest logic. * Remove console log. * Linting. * Unit test update. * Label/select rename. Don't update button for hidden experiences. Default MMM to none. * Hidden option button update fix. * Unit Testing. * Update libs/features/personalization/preview.js * Remove placeholder domain. * Update manifest option titles for clarity in preview.js * Update option title for clarity in getManifestListDomAndParameter function --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment has not loaded (Desktop & Mobile) (adobecom#4137) * Parallelize the network calls required before the gnav becomes visible * corrected the logic for loading base styles for non-milo contexts * load aside.js in parallel if necessary * made the logic inside getGnavSource a little more fault tolerant * Fixed an issue with loading the dark mode gnav (standalone) * changed the gnav tests to reload the global-navigation.js module anew on each test to work correctly with the performance optimizations * Fixed a test for localnav inside bootstrapper.test.js * ignore eslint error on a test * added error handling to the style loading logic in gnav * changed error handling for loading gnav styles from throwing an error to rejecting a promise * removed some redundant code * changed e.message to e * implemented the loading state for desktop viewports * Change animation name as it was the same as one that the unav uses * implemented the loading state for mobile * Removed pointer events from the loading state; made the loading state closer to the specs * Finishing touches * Don't have a loading state for the legacy mobile gnav * add the loading state only on async Dropdowns; decorateLocalnav should be inside decorateMenu.then(...) * put the call to `decorateLocalNavItems` inside `finally` to make sure it runs * lint fixes * Sometimes mobileNavCleanup can be null * Removed an extraneous line * Cleaning up the merge conflict resolution * Make sure `transformTemplateToMobile` always returns a function * [MWPW-173341] - Added ally fix for GNAV Promo heading text (adobecom#4151) Added ally fix for GNAV Promo heading text Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * Removing text decoration none from region nav links (adobecom#4188) * [MWPW-170714] - Section metadata grid (adobecom#4097) * [MWPW=170714] - section data mobile margin * [MWPW=170714] - section two up metadata change * [MWPW-170714] - update mobile gap solution * [MWPW-170714] - remove media query * MWPW-173121: Tax Exclusive & ABM labels for Plans body prices (adobecom#4120) * MWPW-170799: Remove external.js and refactor imports. * fix regressions * fix regressions * fix checks * fix checks * still regression in variants * fix regression on ccd ah styles * disable aggressive PR comments * remove unused file * fix regressions * fix error in doc page * PR review * fix regression in variant mappings * fix plans url * cleanup constants * merge stage and fix regressions * MWPW-164498: Plans Education card * styles * plans page update * heading global styles * phas * block * business plans initial draft * fix badge * spacing and growing * height and styles * collection styles * remove whats included from education * removed whats included in some other way * Plans students aem mapping * milo plans page style updates * removed hardcoded link color * link fix * MWPW-173121: ABM label for Plans body prices * unit test --------- Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * Mwpw 170301 focus outside modal (adobecom#4155) * MWPW-170301: Hide cookie banner when modal is open Revert "MWPW-170301: Keep focus inside the modal" This reverts commit df02548. MWPW-170301: Hide cookie banner when modal is open * MWPW-170301: Move isDeepLink to getModal * MWPW-170301: Add deepLink property to details * MWPW-171825 Improve lcp performance for favicon and breadcrumb (adobecom#4163) * Breadcrumb last item value as current window url if not a link (adobecom#4166) * Breadcrumb last item value as current window url if not a link * Breadcrumb test case fix * Breadcrumb Lint fix * Breadcrumb Lint fix * Quiz option titles on mobile (adobecom#4190) * show titles on mobile * add support for rtl for option titles Resolves: [MWPW-173478](https://jira.corp.adobe.com/browse/MWPW-173478) * MWPW-173816: remove stock checks temporarily (adobecom#4208) * Revert "MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment has not loaded (Desktop & Mobile)" (adobecom#4210) Revert "MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment…" This reverts commit 02289eb. * [MWPW-173470] - Korea free trial restrict (adobecom#4185) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error * Base mweb style changes (adobecom#4187) * MWPW-173239: fallback for addon (adobecom#4200) * MWPW-173239: fallback for addon * add unit test * address review comments --------- Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 9, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-162398 draft * MWPW-162398 enable mas preview - getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview, - if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser, - surface used (for stuff like placeholders) is either computed depending on wcs api key, or coming from preview parameter value, - is url is .page, or www.stage, then preview is set by default, - preview configuration can be overriden with masPreview parameter (url or local storage) set to off for disabling, or a value to use another surface (if api key is not corresponding to a registered surface) * some fixes * some other fixes * some doc and changes * small fixes * Reduce gnav lana sampleRate to 0.01% (#4150) * review comment * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * some fixes * review comments --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
skholkhojaev
added a commit
to skholkhojaev/milo
that referenced
this pull request
Jun 11, 2025
* [MWPW-173100][NALA] Automation test script for Timeline block (adobecom#4301) Update nala automation tests for timeline * Fixing replace check for Gnav test url (adobecom#4333) Fixing replace check for test url * MWPW-170229: Show action scroller nav on resize (adobecom#4311) * MWPW-170229: Show action scroller nav on resize * MWPW-170229: Debounce scroll and resize events * [MWPW-173161] - Refactor preflight to export checks (adobecom#4109) * MWPW-170805 initial refactoring of seo checks. * MWPW-170805 update the links method to cache its result * MWPW-170805 allow for document to be passed * update preflight * update performance checks * update assets checks * don't pass url if not necessary to assets * cache image result * import mini-preflight in utils * hotfix - seo title typos * hotfixes * hotfix * hotfix * Removed unnecessary comments * fixed linter errors * removed old performance panel unit tests * Mwpw 170378 preflight assets unit test (adobecom#4131) * added unit tests for assets tab in preflight * fixed linting * centralized checks imports * added unit tests --------- Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Sino Kholkhojaev <132879006+skholkhojaev@users.noreply.github.com> * MWPW-162398 enable mas preview (adobecom#4148) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * [Release] Stage to Main (adobecom#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (adobecom#3817) * ENB-7820: Add values for event95 (adobecom#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (adobecom#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (adobecom#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (adobecom#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (adobecom#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (adobecom#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (adobecom#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (adobecom#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-162398 draft * MWPW-162398 enable mas preview - getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview, - if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser, - surface used (for stuff like placeholders) is either computed depending on wcs api key, or coming from preview parameter value, - is url is .page, or www.stage, then preview is set by default, - preview configuration can be overriden with masPreview parameter (url or local storage) set to off for disabling, or a value to use another surface (if api key is not corresponding to a registered surface) * some fixes * some other fixes * some doc and changes * small fixes * Reduce gnav lana sampleRate to 0.01% (adobecom#4150) * review comment * Revert "Improve carousel accessibility (adobecom#4103)" from prod (adobecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016. * some fixes * review comments --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-171672: Copy to clipboard for checkout CTAs (adobecom#4171) * added copying to clipboard * lint fix * moved to a separate module * used getMetadata * added a tooltip * fixed brackets * added ClipboardItem * updated tests * replaced the icon * updated unit test * MWPW-172886 [MEP][MILO] Dynamic content on RFI page via referrer | MEP (adobecom#4273) * first commit * Enhance path normalization to include localhost and simplify previous page match logic * Refactor checkForPreviousPageMatch to accept referrer as a parameter and add comprehensive tests * Remove commented suggestion for error handling * Refactor checkForPreviousPageMatch to use lastVisitedPage parameter for improved clarity * Exposing close gnav function for clients (adobecom#4274) * Exposing close gnav function for clients * Lint fix * Add a check if the gnav is in open state before calling toggle * MWPW-173759: Unordered list styling for merch cards (adobecom#4298) * MWPW-173759: Unordered list styling for merch cards * style specificity fix * [MWPW-173502] Remove hash from how-to schema (adobecom#4299) * [MWPW-174367] Inline fragment not behaving as expected in block (adobecom#4317) * Initial checkin. Working state. * Move replacecell handling to utils from fragments * Fix: Replace hardcoded string with constant for replacecell handling * Refactor: Replace constant OVERRIDE_AUTO_INLINE with inline string in modal handling * Unit testing. * Unit testing. * Removed unnecessary test statement. --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * MWPW-172018 Update default price for CIS umbrella regions to TM (adobecom#4323) Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * MWPW-173830: Add tooltip to notification pill (adobecom#4295) * MWPW-173830: Add tooltip to notification pill * MWPW-173830: PR feedback and add checks * MWPW-173528 Fix Safari mobile preview (adobecom#4231) * MWPW-173528 Fix Safari mobile preview Safari requires that the spoofed user agent be set on the load event and not before that. * Show the currently selected device view * Remove flicker when switching between devices * Fix CodeQL Incomplete URL substring sanitization --------- Co-authored-by: Biljana Cvijanovic <hit11757@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Jun 16, 2025
…obecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016.
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 17, 2025
…on contrast / navigation title (#4355) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Reduce gnav lana sampleRate to 0.01% (#4150) * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236) Revert "[MWPW-173470] - Korea free trial restrict (#4185)" This reverts commit 351cfe6. * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237) * MWPW-173875 direct to main * Korea free trial restrict (#4282) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)" This reverts commit 7b82821. * Update utilities.js (#4312) Making a change to the utilities file Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> * MWPW-173772 [merch-card-collection] introduce mobile filter text * MWPW-173772 fix for catalog * icon & display text mgt * fix * more fixes * add more unit test * fixing autoblock fill * MWPW-173772 bump sidenav h2 font size by 1px --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 23, 2025
…nt (#4417) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236) Revert "[MWPW-173470] - Korea free trial restrict (#4185)" This reverts commit 351cfe6. * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237) * Korea free trial restrict (#4282) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [M 8BF0 WPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)" This reverts commit 7b82821. * MWPW-74582: ensure that empty primaryCtas are not being sent through to caas * ugh rebasing stage is the worst * omg literally the worst * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * omg this whitespace will be the death of me * MWPW-74582: carlos revsion --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: Missing slide content announcement when navigating carousel and select slide indicator missing correct state.
aria-livedocsaria-livewith slide text content, so it gets announced to the useraria-labelattributes to the slide indicatorsaria-currentattribute to the active indicatorResolves: MWPW-171960 and MWPW-172184
Test URLs: