MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets #3259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3259 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 245 245
Lines 56746 56835 +89
=======================================
+ Hits 54698 54787 +89
Misses 2048 2048 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
mokimo
approved these changes
Nov 26, 2024
overmyheadandbody
approved these changes
Nov 26, 2024
…o be sharepoint authorable
…e condition w/ decorateIcon()
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Jan 16, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Jan 16, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * MWPW-165523: Fixes BETA Caas bulkpublisher auto-detect * Minor css fix --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Jan 16, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
milo-pr-merge bot
added a commit
that referenced
this pull request
Feb 4, 2025
…3503) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-155425: ability to add multiple event states * MWPW-155425: adjusting the order of the filter messages * MWPW-155425: unit tests --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
colloyd
pushed a commit
to colloyd/milo
that referenced
this pull request
Feb 6, 2025
…dobecom#3503) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * [Release] Stage to Main (adobecom#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-155425: ability to add multiple event states * MWPW-155425: adjusting the order of the filter messages * MWPW-155425: unit tests --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
milo-pr-merge bot
added a commit
that referenced
this pull request
Feb 6, 2025
…le (#3631) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-163904: saving work --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Feb 13, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * adding the log * updated the log --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Saloni Jain <saljain@Salonis-MacBook-Pro-2.local>
milo-pr-merge bot
added a commit
that referenced
this pull request
Mar 4, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Initial checkin. * Remove white space. --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
sanrai
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Initial checkin. * Remove white space. --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
vgoodric
pushed a commit
that referenced
this pull request
Mar 6, 2025
… Tab as Android (#3766) * [MWPW-159511] Create anchor (ID) elements (#3714) * [MWPW-159511] Create anchor (ID) elements * address feedback * address feedback * [MWPW-167031] top tooltip rtl fix (#3618) * [MWPW-167031] tooltip top rtl fix * [MWPW-167031] spacing corrections * [MWPW-167031] css optimization * [MWPW-167031] replaced css with js logic * [MWPW-167031] optimization * [MWPW-167031] optimization * MWPW-164492: Plans Card via MAS (#3649) * first draft * add callout * fix stock js issue * fix plans variant * remove sitemap * fix unit tests * add nala tests * MWPW-167305 [Plans Milo] Callout grey block: authoring improvement (#3663) Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * use consonant cta for plans * add plans.md * fix review comments * fix merge issue * revert obsolete change * fix nala tests * address review comments * merge in stage * Fix regression * fix nala tests comments --------- Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * MWPW-160954 Marketo Multi-step (#3671) * MWPW-160954 Marketo Multi-step * PR Changes * QA Fixes * Next button fix * Adding support for first localnav menu being a dropdown (#3693) * Adding support for localnav item being a dropdown * Fix for button text * wip * Updating title for dropdown * Updating mock for localnav * Fixing button text * Lint fix * Replacing button text after copying * Lint fix * [MWPW-162639] youtube block a tag fix (#3703) * [MWPW-162639] youtube block a tag fix * [MWPW-162639] condition update * [MWPW-162639] clause fix * [MWPW-162639] code removal * Fix(mwpw-163031): Typo fix long-form (#3710) * new event added for autoplay videos * combining the fixe for 163031 * Update adobetv.js * Upgrading standalone gnav version to 0.0.5 (#3712) Upgrading gnav version to 0.0.5 * MWPW-167455: Remove node cloning (#3715) * MWPW-167455: Remove node cloning * MWPW-167455: Remove redundant code * MWPW-167455: Remove video test * MWPW-167455: Remove unnecessary code * MWPW-167455: Change test name * Add fix for galaxy tab * [MWPW-167349] - Added a default logo for the 'A' icon displayed on the right side of GNAV. (#3728) * Added default case adobe 'A' logo on right side for GNAV(Adobe logo block) * Added default case adobe 'A' logo on right side for GNAV(Adobe logo block) --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * MWPW-164660: [3-in-1][Milo] Implement a link converter for CTAs using an iFrame (#3564) * added 3-in-1 modal * moved event listener * updated tests * addressed comments * fixed unit test * moved constants.js into mas.js * added cli param * MWPW-167928 Override Marketo POI (#3702) * replace overflow x with contain layout (#3706) * replace overflow x with contain layout * add a fix for breaking mobile gnav * move fix to existing media block * [MWPW-168309] 2 small MEP button updates (#3719) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Initial checkin. * Remove white space. --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-168334 Load georoutingv2.json and georoutingv2.js in parallel (#3720) * load georoutingv2.json in parallel with georoutingv2.js * remove performance marks * fixed unit tests * Small refactoring * fallback for the jsonPromise * fix unit tests * [MWPW-167309] - Table h tags replace (#3721) * [MWPW-167749] table h header replaced * [MWPW-167749] optimization * [MWPW-167749] naming changes * [MWPW-167749] optimization * [MWPW-167749] code optimization * [MWPW-167749] col role removal * [MWPW-167749] code style update * [MWPW-167309] code improvement * [MWPW-167309] - header role paragraph * MWPW-166176 - Stop initial tabs click propagation (#3726) * MWPW-166176 - Stop initial tabs click propagation * PR feedback --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com> * Fix(mwpw-168006): Viewport bug fix. (#3730) viewport bug fix * Remove file overlap condition from merge to stage workflow (#3736) Remove file overlap condition * Revert "replace overflow x with contain layout" (#3776) Revert "replace overflow x with contain layout (#3706)" This reverts commit 0f54535. * Adding a class to convert group link title to a simple header instead of a link (#3769) Adding a class to convert group link title to a simple header instead of link * MWPW-164093: Adobe Home "Try Buy Widget" merch card (#3651) * MWPW-164093: Adobe Home 'Pricing Widget' merch card Co-Authored-By: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> * styles * cr fixes * refactored swc cta creation * wip * Revert "wip" This reverts commit ebede48. * wip * wip * wip * removed loading promise from race * tacocat update * new fragment mapping approach * typo fix * adobe home card improvements * Enhance merch card background and border color handling - Refactored background color processing to support custom color mapping - Updated border color processing to use CSS custom properties - Added more flexible color configuration for merch cards - Improved test coverage for color-related functions - Removed hardcoded color and border styling in favor of dynamic properties * truncate fixes * benchmarks duration update * truncation error handling * reubens comments * updated deps * unit test fix * data-href for event capture * Delete .cursor.zip * Update .gitignore * bubbled click event * dataset url * wip * Move SWC buttons to light DOM (#3734) * Move SWC buttons to light DOM * fix doc * css padding reset * remove .cursor rules * NALA tests * improved nala tests * lcp improvements on docs page * lcp improvements * Revert "lcp improvements" This reverts commit bb26697. * Revert "lcp improvements on docs page" This reverts commit 936cf14. * Update MAS package.json version * fixed nala tests * lint fixes * nala test title fixed * fixed test * conflicts resolved for the nth time * conflicts resolved * no source maps * right bg color for ah try card * sp-button analytics * data-analytics-id in sp-button * MWPW-169143: AH Try/Buy Widget sizing fixes * data-analytics-id on checkoutButton * version bump --------- Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> Co-authored-by: astatescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> * [MWPW-167752] Loop focus in modals containing iframes (#3716) * MWPW-163228: Preflight svg issue (#3725) * WIP: Pushing just for preview purposes * Added messaging to clairfy the status of the SVG * Strange issues with dev tools, removing fetch to avoid possible CORS, adding external url to show authors where content lives * Updating tags and errortype for PEP lana logs (#3731) Lana log message fix * MWPW-151376: Check sharepoint url (#3733) * [MWPW-167759] Hero marquee bg-bottom-tablet fix (#3735) * MWPW-166689 Add video support to Article Header (#3737) * MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav (#3739) * MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav * apply fix specific to button inside feds promo --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Brandon Marshall <bmarshal@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Prince Patel <prpatel0949@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> Co-authored-by: astatescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Jason Slavin <slavin@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Mar 10, 2025
* [MEP][AJO] POC to integrate AJO with MEP (#3654) * Add ajo integration * Remove AJO references from pznv2 for now * Remove another ajo reference * revert formatting * Remove hard-coded url * Add tests for enabling ajo * MWPW-167217 [MEP] preserve hash in normalizePath (#3751) * Update normalizePath to retain hash * Revert change that will go in separate PR * Update tests * Update to align with getFederatedUrl * Refactor * MWPW-169117[MEP][MILO] Update Personalization Tabs to identity Galaxy Tab as Android (#3766) * [MWPW-159511] Create anchor (ID) elements (#3714) * [MWPW-159511] Create anchor (ID) elements * address feedback * address feedback * [MWPW-167031] top tooltip rtl fix (#3618) * [MWPW-167031] tooltip top rtl fix * [MWPW-167031] spacing corrections * [MWPW-167031] css optimization * [MWPW-167031] replaced css with js logic * [MWPW-167031] optimization * [MWPW-167031] optimization * MWPW-164492: Plans Card via MAS (#3649) * first draft * add callout * fix stock js issue * fix plans variant * remove sitemap * fix unit tests * add nala tests * MWPW-167305 [Plans Milo] Callout grey block: authoring improvement (#3663) Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * use consonant cta for plans * add plans.md * fix review comments * fix merge issue * revert obsolete change * fix nala tests * address review comments * merge in stage * Fix regression * fix nala tests comments --------- Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * MWPW-160954 Marketo Multi-step (#3671) * MWPW-160954 Marketo Multi-step * PR Changes * QA Fixes * Next button fix * Adding support for first localnav menu being a dropdown (#3693) * Adding support for localnav item being a dropdown * Fix for button text * wip * Updating title for dropdown * Updating mock for localnav * Fixing button text * Lint fix * Replacing button text after copying * Lint fix * [MWPW-162639] youtube block a tag fix (#3703) * [MWPW-162639] youtube block a tag fix * [MWPW-162639] condition update * [MWPW-162639] clause fix * [MWPW-162639] code removal * Fix(mwpw-163031): Typo fix long-form (#3710) * new event added for autoplay videos * combining the fixe for 163031 * Update adobetv.js * Upgrading standalone gnav version to 0.0.5 (#3712) Upgrading gnav version to 0.0.5 * MWPW-167455: Remove node cloning (#3715) * MWPW-167455: Remove node cloning * MWPW-167455: Remove redundant code * MWPW-167455: Remove video test * MWPW-167455: Remove unnecessary code * MWPW-167455: Change test name * Add fix for galaxy tab * [MWPW-167349] - Added a default logo for the 'A' icon displayed on the right side of GNAV. (#3728) * Added default case adobe 'A' logo on right side for GNAV(Adobe logo block) * Added default case adobe 'A' logo on right side for GNAV(Adobe logo block) --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * MWPW-164660: [3-in-1][Milo] Implement a link converter for CTAs using an iFrame (#3564) * added 3-in-1 modal * moved event listener * updated tests * addressed comments * fixed unit test * moved constants.js into mas.js * added cli param * MWPW-167928 Override Marketo POI (#3702) * replace overflow x with contain layout (#3706) * replace overflow x with contain layout * add a fix for breaking mobile gnav * move fix to existing media block * [MWPW-168309] 2 small MEP button updates (#3719) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Initial checkin. * Remove white space. --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-168334 Load georoutingv2.json and georoutingv2.js in parallel (#3720) * load georoutingv2.json in parallel with georoutingv2.js * remove performance marks * fixed unit tests * Small refactoring * fallback for the jsonPromise * fix unit tests * [MWPW-167309] - Table h tags replace (#3721) * [MWPW-167749] table h header replaced * [MWPW-167749] optimization * [MWPW-167749] naming changes * [MWPW-167749] optimization * [MWPW-167749] code optimization * [MWPW-167749] col role removal * [MWPW-167749] code style update * [MWPW-167309] code improvement * [MWPW-167309] - header role paragraph * MWPW-166176 - Stop initial tabs click propagation (#3726) * MWPW-166176 - Stop initial tabs click propagation * PR feedback --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com> * Fix(mwpw-168006): Viewport bug fix. (#3730) viewport bug fix * Remove file overlap condition from merge to stage workflow (#3736) Remove file overlap condition * Revert "replace overflow x with contain layout" (#3776) Revert "replace overflow x with contain layout (#3706)" This reverts commit 0f54535. * Adding a class to convert group link title to a simple header instead of a link (#3769) Adding a class to convert group link title to a simple header instead of link * MWPW-164093: Adobe Home "Try Buy Widget" merch card (#3651) * MWPW-164093: Adobe Home 'Pricing Widget' merch card Co-Authored-By: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> * styles * cr fixes * refactored swc cta creation * wip * Revert "wip" This reverts commit ebede48. * wip * wip * wip * removed loading promise from race * tacocat update * new fragment mapping approach * typo fix * adobe home card improvements * Enhance merch card background and border color handling - Refactored background color processing to support custom color mapping - Updated border color processing to use CSS custom properties - Added more flexible color configuration for merch cards - Improved test coverage for color-related functions - Removed hardcoded color and border styling in favor of dynamic properties * truncate fixes * benchmarks duration update * truncation error handling * reubens comments * updated deps * unit test fix * data-href for event capture * Delete .cursor.zip * Update .gitignore * bubbled click event * dataset url * wip * Move SWC buttons to light DOM (#3734) * Move SWC buttons to light DOM * fix doc * css padding reset * remove .cursor rules * NALA tests * improved nala tests * lcp improvements on docs page * lcp improvements * Revert "lcp improvements" This reverts commit bb26697. * Revert "lcp improvements on docs page" This reverts commit 936cf14. * Update MAS package.json version * fixed nala tests * lint fixes * nala test title fixed * fixed test * conflicts resolved for the nth time * conflicts resolved * no source maps * right bg color for ah try card * sp-button analytics * data-analytics-id in sp-button * MWPW-169143: AH Try/Buy Widget sizing fixes * data-analytics-id on checkoutButton * version bump --------- Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> Co-authored-by: astatescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> * [MWPW-167752] Loop focus in modals containing iframes (#3716) * MWPW-163228: Preflight svg issue (#3725) * WIP: Pushing just for preview purposes * Added messaging to clairfy the status of the SVG * Strange issues with dev tools, removing fetch to avoid possible CORS, adding external url to show authors where content lives * Updating tags and errortype for PEP lana logs (#3731) Lana log message fix * MWPW-151376: Check sharepoint url (#3733) * [MWPW-167759] Hero marquee bg-bottom-tablet fix (#3735) * MWPW-166689 Add video support to Article Header (#3737) * MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav (#3739) * MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav * apply fix specific to button inside feds promo --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Brandon Marshall <bmarshal@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Prince Patel <prpatel0949@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> Co-authored-by: astatescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Jason Slavin <slavin@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> --------- Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Brandon Marshall <bmarshal@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Prince Patel <prpatel0949@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com> Co-authored-by: astatescu <angelostatescu.adobe@gmail.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Jason Slavin <slavin@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Mar 10, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Promotes beta version to default URL * MWPW-167326: adds download CSV option and code cleanup * MWPW-167326: fixes eslint errors * MWPW-167326: fixes eslint errors II * MWPW-167326: fixes eslint errors III * MWPW-167326: fixes eslint errors IV * MWPW-167326: fixes eslint errors V --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Apr 7, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
…on (#3906) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * MWPW-170567: send to caas language first localization * MWPW-170567: eslint * MWPW-170567: eslint * MWPW-170567: eslint * MWPW-170567: eslint * MWPW-170567: merge error * MWPW-170567: fixing a thing * eslint * MWPW-170567: lint * caught a local testing error * caught a local testing error --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
nishantka
pushed a commit
to nishantka/milo
that referenced
this pull request
Apr 21, 2025
…on (adobecom#3906) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * MWPW-170567: send to caas language first localization * MWPW-170567: eslint * MWPW-170567: eslint * MWPW-170567: eslint * MWPW-170567: eslint * MWPW-170567: merge error * MWPW-170567: fixing a thing * eslint * MWPW-170567: lint * caught a local testing error * caught a local testing error --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
milo-pr-merge bot
added a commit
that referenced
this pull request
Apr 22, 2025
…ation (#3969) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.co 10000 m> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-170562: saving work * saving work * MWPW-170562: sorted lang & country dropdowns * MWPW-170562: unit tests * MWPW-170562: unit tests * MWPW-170562: unit tests * MWPW-170562: lint * MWPW-170562: auto country/lang * MWPW-170562: auto country/lang * MWPW-170562: sort * lint --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local> Co-authored-by: Sheridan Sunier <sunier@macbookpro.lan>
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
May 12, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
May 12, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
milo-pr-merge bot
added a commit
that referenced
this pull request
May 13, 2025
…ion (#4102) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-170933: saving work * MWPW-170933: bulk publisher support for language first * lint * ui changes * tool-tip * chris code change * chris changes * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
May 13, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.
milo-pr-merge bot
added a commit
that referenced
this pull request
May 15, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * add pathname into config for autodetect purposes * MWPW-172910: autodetect localization * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * lint --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
ivanvatadobe
pushed a commit
that referenced
this pull request
May 15, 2025
…ion (#4102) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgood 58E8 ric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-170933: saving work * MWPW-170933: bulk publisher support for language first * lint * ui changes * tool-tip * chris code change * chris changes * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue * weird merge issue --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
ivanvatadobe
pushed a commit
that referenced
this pull request
May 15, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * add pathname into config for autodetect purposes * MWPW-172910: autodetect localization * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * merge weirdness * lint --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 9, 2025
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-162398 draft * MWPW-162398 enable mas preview - getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview, - if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser, - surface used (for stuff like placeholders) is either computed depending on wcs api key, or coming from preview parameter value, - is url is .page, or www.stage, then preview is set by default, - preview configuration can be overriden with masPreview parameter (url or local storage) set to off for disabling, or a value to use another surface (if api key is not corresponding to a registered surface) * some fixes * some other fixes * some doc and changes * small fixes * Reduce gnav lana sampleRate to 0.01% (#4150) * review comment * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * some fixes * review comments --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
skholkhojaev
added a commit
to skholkhojaev/milo
that referenced
this pull request
Jun 11, 2025
* [MWPW-173100][NALA] Automation test script for Timeline block (adobecom#4301) Update nala automation tests for timeline * Fixing replace check for Gnav test url (adobecom#4333) Fixing replace check for test url * MWPW-170229: Show action scroller nav on resize (adobecom#4311) * MWPW-170229: Show action scroller nav on resize * MWPW-170229: Debounce scroll and resize events * [MWPW-173161] - Refactor preflight to export checks (adobecom#4109) * MWPW-170805 initial refactoring of seo checks. * MWPW-170805 update the links method to cache its result * MWPW-170805 allow for document to be passed * update preflight * update performance checks * update assets checks * don't pass url if not necessary to assets * cache image result * import mini-preflight in utils * hotfix - seo title typos * hotfixes * hotfix * hotfix * Removed unnecessary comments * fixed linter errors * removed old performance panel unit tests * Mwpw 170378 preflight assets unit test (adobecom#4131) * added unit tests for assets tab in preflight * fixed linting * centralized checks imports * added unit tests --------- Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Sino Kholkhojaev <132879006+skholkhojaev@users.noreply.github.com> * MWPW-162398 enable mas preview (adobecom#4148) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * [Release] Stage to Main (adobecom#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (adobecom#3817) * ENB-7820: Add values for event95 (adobecom#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (adobecom#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (adobecom#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (adobecom#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (adobecom#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (adobecom#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (adobecom#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (adobecom#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-162398 draft * MWPW-162398 enable mas preview - getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview, - if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser, - surface used (for stuff like placeholders) is either computed depending on wcs api key, or coming from preview parameter value, - is url is .page, or www.stage, then preview is set by default, - preview configuration can be overriden with masPreview parameter (url or local storage) set to off for disabling, or a value to use another surface (if api key is not corresponding to a registered surface) * some fixes * some other fixes * some doc and changes * small fixes * Reduce gnav lana sampleRate to 0.01% (adobecom#4150) * review comment * Revert "Improve carousel accessibility (adobecom#4103)" from prod (adobecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016. * some fixes * review comments --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-171672: Copy to clipboard for checkout CTAs (adobecom#4171) * added copying to clipboard * lint fix * moved to a separate module * used getMetadata * added a tooltip * fixed brackets * added ClipboardItem * updated tests * replaced the icon * updated unit test * MWPW-172886 [MEP][MILO] Dynamic content on RFI page via referrer | MEP (adobecom#4273) * first commit * Enhance path normalization to include localhost and simplify previous page match logic * Refactor checkForPreviousPageMatch to accept referrer as a parameter and add comprehensive tests * Remove commented suggestion for error handling * Refactor checkForPreviousPageMatch to use lastVisitedPage parameter for improved clarity * Exposing close gnav function for clients (adobecom#4274) * Exposing close gnav function for clients * Lint fix * Add a check if the gnav is in open state before calling toggle * MWPW-173759: Unordered list styling for merch cards (adobecom#4298) * MWPW-173759: Unordered list styling for merch cards * style specificity fix * [MWPW-173502] Remove hash from how-to schema (adobecom#4299) * [MWPW-174367] Inline fragment not behaving as expected in block (adobecom#4317) * Initial checkin. Working state. * Move replacecell handling to utils from fragments * Fix: Replace hardcoded string with constant for replacecell handling * Refactor: Replace constant OVERRIDE_AUTO_INLINE with inline string in modal handling * Unit testing. * Unit testing. * Removed unnecessary test statement. --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * MWPW-172018 Update default price for CIS umbrella regions to TM (adobecom#4323) Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * MWPW-173830: Add tooltip to notification pill (adobecom#4295) * MWPW-173830: Add tooltip to notification pill * MWPW-173830: PR feedback and add checks * MWPW-173528 Fix Safari mobile preview (adobecom#4231) * MWPW-173528 Fix Safari mobile preview Safari requires that the spoofed user agent be set on the load event and not before that. * Show the currently selected device view * Remove flicker when switching between devices * Fix CodeQL Incomplete URL substring sanitization --------- Co-authored-by: Biljana Cvijanovic <hit11757@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Jun 16, 2025
adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" T 10000 his reverts commit 81a5770.
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 17, 2025
…on contrast / navigation title (#4355) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Reduce gnav lana sampleRate to 0.01% (#4150) * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236) Revert "[MWPW-173470] - Korea free trial restrict (#4185)" This reverts commit 351cfe6. * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237) * MWPW-173875 direct to main * Korea free trial restrict (#4282) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)" This reverts commit 7b82821. * Update utilities.js (#4312) Making a change to the utilities file Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> * MWPW-173772 [merch-card-collection] introduce mobile filter text * MWPW-173772 fix for catalog * icon & display text mgt * fix * more fixes * add more unit test * fixing autoblock fill * MWPW-173772 bump sidenav h2 font size by 1px --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 23, 2025
…nt (#4417) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236) Revert "[MWPW-173470] - Korea free trial restrict (#4185)" This reverts commit 351cfe6. * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237) * Korea free trial restrict (#4282) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)" This reverts commit 7b82821. * MWPW-74582: ensure that empty primaryCtas are not being sent through to caas * ugh rebasing stage is the worst * omg literally the worst * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * omg this whitespace will be the death of me * MWPW-74582: carlos revsion --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial PR was reverted due to some issues found w/ tooltips in the table block. re-submitting as this has been resolved.
To streamline icon management across Milo and other consuming sites, a centralized repository, federal, along with a directory named
icons/svgs, will be established. This will provide shared access to a unified set of icons. The transition will maintain the current authoring experience, while also introducing new opportunities for contributors to expand the icon set. The key points of this change are outlined below:Key Points:
Centralized Icon Repository: A new /assets/icons/svgs directory was added to the /federal/ repo, allowing multiple sites (Milo and others) to use the same set of icons. All icons currently available are listed here /icons/icons.json
Consistent Authoring Notation: Authors will continue to use the current notation, such as
:icon-play:, to insert icons into content. This ensures a seamless transition with no change in authoring experience.Source Change: Icons will no longer be served from the Milo code-bus. Instead, they will be fetched from the federal repository via the content-bus.
Author Contributions: This new system enables authors to contribute and expand the icon set by adding new icons to the centralized repository, a feature that was previously unavailable.
Subsequent Ticket: The Sidekick plugin library will be updated in a subsequent ticket to improve authoring accessibility for that component - see MWPW-159581
Resolves: MWPW-140452
Draft URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/icon/icons-federal?martech=off
After: https://rparrish-fed-icons--milo--adobecom.hlx.page/drafts/rparrish/icon/icons-federal?martech=off
Doc URLs:
Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/?martech=off
After: https://rparrish-fed-icons--milo--adobecom.hlx.page/docs/library/kitchen-sink/?martech=off
URLs where the
tooltip / tableissue was found:https://main--dc--adobecom.hlx.page/acrobat/pricing?milolibs=rparrish-fed-icons&martech=off
https://main--bacom--adobecom.hlx.page/?milolibs=rparrish-fed-icons