MWPW-162398 enable mas preview #4148

npeltier · 2025-05-14T17:46:34Z

getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview,
if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser,
surface used (for stuff like placeholders) is computed depending on wcs api key
is url is .page, or www.stage, then preview is set by default,
preview configuration can be overriden with mas.preview parameter (url or local storage) set to off for disabling,

Test URLs:

adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

yesil · 2025-05-15T12:51:37Z

libs/features/mas/src/aem-fragment.js

@@ -273,6 +279,16 @@ export class AemFragment extends HTMLElement {
            { fields: {}, id, tags, settings },
        );
    }
+
+    async generatePreview() {
+        const { previewFragment } = await import('https://mas.adobe.com/studio/libs/fragment-client.js');


Thanks @npeltier for explaining the concept, I'm good now :)

yesil · 2025-05-15T12:59:16Z

libs/features/mas/src/settings.js

@@ -16,6 +17,8 @@ import {

 import { toQuantity } from './utilities.js';

+const PREVIEW_REGISTERED_SURFACE = { 'wcms-commerce-ims-ro.+': 'acom', 'CreativeCloud_.+': 'ccd', "CCHome.+": 'adobe-home' };


can we make this logic automatic? This is going to increase consumer onboarding effort where we need to make a PR there for future consumers.

yesil

@npeltier

I see a regression in the merch-addon, can you confirm if this is ok?
https://main--milo--npeltier.aem.page/drafts/ilyas/mas/merch-card

https://mwpw-162398--milo--npeltier.aem.page/drafts/ilyas/mas/merch-card (updated)

npeltier · 2025-05-19T13:25:14Z

@npeltier

I see a regression in the merch-addon, can you confirm if this is ok? https://main--milo--npeltier.aem.page/drafts/ilyas/mas/merch-card

https://mwpw-162398--milo--npeltier.aem.page/drafts/ilyas/mas/merch-carde/drafts/ilyas/mas/merch-card

@yesil assuming you are talking about https://mwpw-162398--milo--npeltier.aem.page/drafts/ilyas/mas/merch-card ;-)
i did following changes:

created addon-stock-base placeholder on acom surface with same value as sandbox (not published, will leave that to authors),
updated fragment-client.js (from pipeline code MWPW-162398 add latest io/www changes before hook mas#267)

looks better now

…obecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016.

3ch023 · 2025-05-26T12:37:49Z

libs/features/mas/docs/src/mas.js.md

 | `lana-tags`              | Enables logging via lana[^1][^2] with the given tags. e.g:`ccd`.                                    |                                  | `false`  |
 | `lana-sample-rate`       | Sets the sampling rate, see [^1] for details.                                                       | 1                                | `false`  |
+| `language`               | language of the price literal, e.g: per license                                                     | en or locale language if set     | `false`  |
+| `preview`                | enable preview (will only work on corp network), can be overriden with parameter `mas.preview=off`  | false / off                      | `false`  |


lets add also possible values to description:

enable preview (will only work on corp network), can be overriden with parameter mas.preview=off
to enable preview, set it to 'on' or provide surface, e.g.
preview="on"
or
preview="acom"

no, you can't override promotions anymore, will add "on/true" even anything but "off/false" works

i see, thx, i updated PR description to reflect

3ch023

approving, however a few thoughts:

since we can't cover this with Nala we could add a unit test for aem-fragment change, mocking fragment-client.js library
M@S gallery pages could potentially have same logic, aem.page -> preview="on", aem.live -> preview="off". We would need to make sure nala tests go to aem.live only.

3ch023 · 2025-05-26T13:09:22Z

libs/features/mas/docs/src/mas.js.md

 | `lana-tags`              | Enables logging via lana[^1][^2] with the given tags. e.g:`ccd`.                                    |                                  | `false`  |
 | `lana-sample-rate`       | Sets the sampling rate, see [^1] for details.                                                       | 1                                | `false`  |
+| `language`               | language of the price literal, e.g: per license                                                     | en or locale language if set     | `false`  |
+| `preview`                | enable preview (will only work on corp network), can be overriden with parameter `mas.preview=off`  | false / off                      | `false`  |


3ch023 · 2025-05-26T13:11:59Z

libs/features/mas/docs/ccd.html

@@ -29,7 +29,7 @@ <h1 id="ccd-gallery" tabindex="-1">CCD Gallery <a class="header-anchor" href="#c
 <p>Switch country/language: <a class="locale-toggle spectrum-Link spectrum-Link--secondary" value="US,en" href="?country=US&language=en">Country: US, language: en</a> OR <a class="locale-toggle spectrum-Link spectrum-Link--secondary" value="FR,fr" href="?country=FR&language=fr">Country: FR, language: fr</a></p>
  <h2 id="ccd-slice-card" tabindex="-1">CCD Slice Cards <a class="header-anchor" href="#ccd-slice-card" title="Permalink to this heading">#</a></h2>
  <div class="three-merch-cards ccd-slice">
-      <merch-card><aem-fragment fragment="0ef2a804-e788-4959-abb8-b4d96a18b0ef"></aem-fragment></merch-card>
+      <merch-card><aem-fragment fragment="0ef2a804-e788-4959-abb8-b4d96a18b0ef" preview="true"></aem-fragment></merch-card>


this is not needed, right?

3ch023 · 2025-05-26T13:32:25Z

libs/features/mas/test/settings.test.js

+    it('overrides correctly preview surface configuration from parameter mas.preview', () => {
+      const config = { commerce: {}, preview: '' };
+      window.sessionStorage.setItem('wcsApiKey', 'user-test');
+      window.sessionStorage.setItem('mas.preview', 'nala');


not a valid use-case afaik?

milo-pr-merge · 2025-06-03T08:06:18Z

Error merging 4148: MWPW-162398 enable mas preview Pull Request is not mergeable

milo-pr-merge · 2025-06-05T09:09:25Z

Error merging 4148: MWPW-162398 enable mas preview Pull Request is not mergeable

* [MWPW-173100][NALA] Automation test script for Timeline block (adobecom#4301) Update nala automation tests for timeline * Fixing replace check for Gnav test url (adobecom#4333) Fixing replace check for test url * MWPW-170229: Show action scroller nav on resize (adobecom#4311) * MWPW-170229: Show action scroller nav on resize * MWPW-170229: Debounce scroll and resize events * [MWPW-173161] - Refactor preflight to export checks (adobecom#4109) * MWPW-170805 initial refactoring of seo checks. * MWPW-170805 update the links method to cache its result * MWPW-170805 allow for document to be passed * update preflight * update performance checks * update assets checks * don't pass url if not necessary to assets * cache image result * import mini-preflight in utils * hotfix - seo title typos * hotfixes * hotfix * hotfix * Removed unnecessary comments * fixed linter errors * removed old performance panel unit tests * Mwpw 170378 preflight assets unit test (adobecom#4131) * added unit tests for assets tab in preflight * fixed linting * centralized checks imports * added unit tests --------- Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Sino Kholkhojaev <132879006+skholkhojaev@users.noreply.github.com> * MWPW-162398 enable mas preview (adobecom#4148) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * [Release] Stage to Main (adobecom#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (adobecom#3817) * ENB-7820: Add values for event95 (adobecom#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (adobecom#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (adobecom#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (adobecom#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (adobecom#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (adobecom#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (adobecom#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (adobecom#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-162398 draft * MWPW-162398 enable mas preview - getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview, - if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser, - surface used (for stuff like placeholders) is either computed depending on wcs api key, or coming from preview parameter value, - is url is .page, or www.stage, then preview is set by default, - preview configuration can be overriden with masPreview parameter (url or local storage) set to off for disabling, or a value to use another surface (if api key is not corresponding to a registered surface) * some fixes * some other fixes * some doc and changes * small fixes * Reduce gnav lana sampleRate to 0.01% (adobecom#4150) * review comment * Revert "Improve carousel accessibility (adobecom#4103)" from prod (adobecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016. * some fixes * review comments --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-171672: Copy to clipboard for checkout CTAs (adobecom#4171) * added copying to clipboard * lint fix * moved to a separate module * used getMetadata * added a tooltip * fixed brackets * added ClipboardItem * updated tests * replaced the icon * updated unit test * MWPW-172886 [MEP][MILO] Dynamic content on RFI page via referrer | MEP (adobecom#4273) * first commit * Enhance path normalization to include localhost and simplify previous page match logic * Refactor checkForPreviousPageMatch to accept referrer as a parameter and add comprehensive tests * Remove commented suggestion for error handling * Refactor checkForPreviousPageMatch to use lastVisitedPage parameter for improved clarity * Exposing close gnav function for clients (adobecom#4274) * Exposing close gnav function for clients * Lint fix * Add a check if the gnav is in open state before calling toggle * MWPW-173759: Unordered list styling for merch cards (adobecom#4298) * MWPW-173759: Unordered list styling for merch cards * style specificity fix * [MWPW-173502] Remove hash from how-to schema (adobecom#4299) * [MWPW-174367] Inline fragment not behaving as expected in block (adobecom#4317) * Initial checkin. Working state. * Move replacecell handling to utils from fragments * Fix: Replace hardcoded string with constant for replacecell handling * Refactor: Replace constant OVERRIDE_AUTO_INLINE with inline string in modal handling * Unit testing. * Unit testing. * Removed unnecessary test statement. --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * MWPW-172018 Update default price for CIS umbrella regions to TM (adobecom#4323) Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * MWPW-173830: Add tooltip to notification pill (adobecom#4295) * MWPW-173830: Add tooltip to notification pill * MWPW-173830: PR feedback and add checks * MWPW-173528 Fix Safari mobile preview (adobecom#4231) * MWPW-173528 Fix Safari mobile preview Safari requires that the spoofed user agent be set on the load event and not before that. * Show the currently selected device view * Remove flicker when switching between devices * Fix CodeQL Incomplete URL substring sanitization --------- Co-authored-by: Biljana Cvijanovic <hit11757@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

milo-pr-merge bot and others added 30 commits December 9, 2024 09:18

[Release] Stage to Main (adobecom#3315)

e51a18c

[Release] Stage to Main (adobecom#3331)

41ef7a9

[Release] Stage to Main (adobecom#3345)

badc68d

Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (

58ae324

adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770.

[Release] Stage to Main (adobecom#3355)

fa0dbb1

[Release] Stage to Main (adobecom#3411)

55c4a2d

[Release] Stage to Main (adobecom#3422)

d8fb2eb

[Release] Stage to Main (adobecom#3442)

7f147b6

[Release] Stage to Main (adobecom#3468)

3cda648

[Release] Stage to Main (adobecom#3478)

a61dc66

[Release] Stage to Main (adobecom#3487)

409ed68

[Release] Stage to Main (adobecom#3497)

c56840d

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

[Release] Stage to Main (adobecom#3500)

b02a573

[Release] Stage to Main (adobecom#3512)

f3ab5ac

[Release] Stage to Main (adobecom#3531)

36827bd

[Release] Stage to Main (adobecom#3545)

6afa5dd

[Release] Stage to Main (adobecom#3570)

7097c97

[Release] Stage to Main (adobecom#3581)

2d31710

[Release] Stage to Main (adobecom#3595)

e253988

[Release] Stage to Main (adobecom#3615)

a0c3810

[Release] Stage to Main (adobecom#3621)

24a90ab

[Release] Stage to Main (adobecom#3628)

98d34a8

[Release] Stage to Main (adobecom#3640)

ba3e6aa

[Release] Stage to Main (adobecom#3667)

d3fbffa

[Release] Stage to Main (adobecom#3681)

4769d4e

[Release] Stage to Main (adobecom#3701)

f6e9d43

[Release] Stage to Main (adobecom#3707)

cffeac6

[Release] Stage to Main (adobecom#3718)

1b8f560

[Release] Stage to Main (adobecom#3764)

338fbec

[Release] Stage to Main (adobecom#3772)

8dbad8c

npeltier requested review from sharmrj, nishantka, Deva309 and sonawanesnehal3 as code owners May 15, 2025 10:21

yesil approved these changes May 15, 2025

View reviewed changes

yesil requested changes May 15, 2025

View reviewed changes

milo-pr-merge bot and others added 3 commits May 15, 2025 16:08

[Release] Stage to Main (adobecom#4149)

35d06bf

review comment

f4fecb9

Merge branch 'stage' of github.com:adobecom/milo into MWPW-162398

5ab7e2a

[Release] Stage to Main (adobecom#4160)

faab486

yesil approved these changes May 19, 2025

View reviewed changes

mokimo and others added 6 commits May 20, 2025 10:30

Revert "Improve carousel accessibility (adobecom#4103)" from prod (ad…

025a1e9

…obecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016.

Merge branch 'stage' of github.com:adobecom/milo into MWPW-162398

1ba9fd0

[Release] Stage to Main (adobecom#4186)

c3b4455

some fixes

60af6cf

Merge branch 'main' of github.com:adobecom/milo into MWPW-162398

1543039

Merge branch 'stage' of github.com:adobecom/milo into MWPW-162398

3e8894c

3ch023 reviewed May 26, 2025

View reviewed changes

3ch023 approved these changes May 26, 2025

View reviewed changes

npeltier added 2 commits May 26, 2025 16:21

Merge branch 'stage' of github.com:adobecom/milo into MWPW-162398

18fd924

review comments

a670ba1

afmicka added verified PR has been E2E tested by a reviewer Ready for Stage labels May 30, 2025

Merge branch 'stage' of github.com:adobecom/milo into MWPW-162398

c13d233

milo-pr-merge bot merged commit 78de654 into adobecom:stage Jun 9, 2025
13 of 14 checks passed

milo-pr-merge bot mentioned this pull request Jun 9, 2025

[Release] Stage to Main #4345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MWPW-162398 enable mas preview #4148

MWPW-162398 enable mas preview #4148

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

		@@ -16,6 +17,8 @@ import {

		import { toQuantity } from './utilities.js';

		const PREVIEW_REGISTERED_SURFACE = { 'wcms-commerce-ims-ro.+': 'acom', 'CreativeCloud_.+': 'ccd', "CCHome.+": 'adobe-home' };

MWPW-162398 enable mas preview #4148

MWPW-162398 enable mas preview #4148

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!