8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #3718 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 3, 2025
Merged

[Release] Stage to Main #3718

merged 7 commits into from
Mar 3, 2025

Conversation

st-angelo-adobe and others added 3 commits February 20, 2025 17:53
* init upt-link

* mas-element fix

* missing build

* callback check

* correct href

* upt link error handling

* refined link

* ccd revert, encoded URI

* build

* hook name conflict fix

* upt link in hydration

* is attribute

* upt-link fix; nala tests

* nala test updates

* undefined promo code fix

* promo terms url based on env
* after history reset

* opcity change remove dropdown disabled

* comment cleanup

* createPageList fix added search params

* search param update

* remove perpage pagenum from shareurl hrefs

* comment changes

---------

Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
* [MWPW-168041] pill tab border removal

* [MWPW-168041] optimization
@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Feb 20, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor
aem-code-sync bot commented Feb 20 8000 , 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
aem-code-sync bot commented Feb 20, 2025
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-stock.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-subscription-panel.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-twp-d2p.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-whats-included.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/dist/mas.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/src/commerce.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/src/hydrate.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/src/upt-link.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

8000 Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

8000

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

…tics (#3559)

* DOTCOM-128841, DOTCOM-129276,  Group of navigation links missing semantics

* fix linting errors

* DOTCOM-128841 change p tag to div

* wrap footer links with ul li

* replace span with before element for divider, to mentain semantics

* undo last changes

* move divider in li

* remove divider form semantic testing purpose

* undo last commit

* move copyright inside list

* undo reader fix

* wrap copyright in list item

* remove whitespace

* add fix for two sections
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 01:15 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 04:17 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 08:18 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 09:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 12:27 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 16:16 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 1, 2025 20:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 01:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 04:16 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 08:17 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 09:15 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 12:26 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 16:16 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 2, 2025 20:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 3, 2025 01:12 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 3, 2025 04:19 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 3, 2025 08:20 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge March 3, 2025 09:17 — with GitHub Actions Inactive
@milo-pr-merge milo-pr-merge bot merged commit 1b8f560 into main Mar 3, 2025
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0