8000 MWPW-164728 [MMM] Improve design of pagination by ivanvatadobe · Pull Request #3669 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-164728 [MMM] Improve design of pagination #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 20, 2025
Merged

MWPW-164728 [MMM] Improve design of pagination #3669

merged 7 commits into from
Feb 20, 2025

Conversation

ivanvatadobe
Copy link
Contributor

This PR introduces a more attractive and user friendly pagination design to MMM.

  • Replaced page number links with arrow navigation UI
  • Arrows will automatically gray out and be disabled if user is at the start or end of list
  • Range numbers have commas via toLocaleString()
  • Dropdown options to show x number of records per page: 25 (default), 50, 100
  • Share url will only copy search values, not current perPage or pageNum setting

Resolves: MWPW-164728

Test URLs:

QA URLs

base url (check functionality and use share button as needed):
https://mmm-pagination-style--milo--adobecom.hlx.page/docs/authoring/features/mmm

examples of share urls

basic string and last seen:
https://mmm-pagination-style--milo--adobecom.hlx.page/docs/authoring/features/mmm?lastSeenManifest=threeMonths&urls=test

url that should fetch no items:
https://mmm-pagination-style--milo--adobecom.hlx.page/docs/authoring/features/mmm?geos=us%2Cca%2Cca_fr&pages=%2Fproducts%2Fphotoshop.html&lastSeenManifest=year&urls=acrobat

homepage path (/) check:
https://mmm-pagination-style--milo--adobecom.hlx.page/docs/authoring/features/mmm?geos=jp&pages=%2F&lastSeenManifest=year

all params populated:
https://mmm-pagination-style--milo--adobecom.hlx.page/docs/authoring/features/mmm?geos=mx%2Cbr&pages=%2Fcreativecloud.html&lastSeenManifest=year&urls=cloud

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Feb 11, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Feb 11, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /docs/authoring/features/mmm PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/features/mmm PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /docs/authoring/features/mmm?geos=jp&pages=%2F&lastSeenManifest=year PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/features/mmm?geos=jp&pages=%2F&lastSeenManifest=year PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /docs/authoring/features/mmm?geos=mx%2Cbr&pages=%2Fcreativecloud.html&lastSeenMa
nifest=year&urls=cloud		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/features/mmm?geos=mx%2Cbr&pages=%2Fcreativecloud.html&lastSeenMa
nifest=year&urls=cloud		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /docs/authoring/features/mmm?geos=us%2Cca%2Cca_fr&pages=%2Fproducts%2Fphotoshop.
html&lastSeenManifest=year&urls=acrobat		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/features/mmm?geos=us%2Cca%2Cca_fr&pages=%2Fproducts%2Fphotoshop.
html&lastSeenManifest=year&urls=acrobat		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /docs/authoring/features/mmm?lastSeenManifest=threeMonths&urls=test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/authoring/features/mmm?lastSeenManifest=threeMonths&urls=test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@denlight denlight self-requested a review February 11, 2025 18:38
denlight
denlight approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor
@denlight denlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just gotta fix come checks

@denlight denlight force-pushed the mmm-pagination-style branch from 9962f81 to f35463f Compare February 11, 2025 18:47
jpratt2
jpratt2 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor
@jpratt2 jpratt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve from a functionality perspective. The pagination is accurate showing 25, 50, or 100 pages, and the arrows allow movement to new page groupings.

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Feb 13, 2025

Skipped 3669: "MWPW-164728 [MMM] Improve design of pagination" due to file "libs/blocks/mmm/mmm.css" overlap. Merging will be attempted in the next batch

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Feb 18, 2025

Error merging 3669: MWPW-164728 [MMM] Improve design of pagination Pull Request is not mergeable

1 similar comment
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Feb 19, 2025

Error merging 3669: MWPW-164728 [MMM] Improve design of pagination Pull Request is not mergeable

@denlight denlight force-pushed the mmm-pagination-style branch from f35463f to fe1f163 Compare February 20, 2025 17:10
@aem-code-sync aem-code-sync bot temporarily deployed to mmm-pagination-style February 20, 2025 17:10 Inactive
@denlight denlight force-pushed the mmm-pagination-style branch from fe1f163 to 1e77964 Compare February 20, 2025 17:15
@denlight denlight added the verified PR has been E2E tested by a reviewer label Feb 20, 2025
@milo-pr-merge milo-pr-merge bot merged commit fd41709 into stage Feb 20, 2025
16 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mmm-pagination-style branch February 20, 2025 17:53
@milo-pr-merge milo-pr-merge bot mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denlight denlight denlight approved these changes

@jpratt2 jpratt2 jpratt2 approved these changes

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanvatadobe @denlight @jpratt2
0