MWPW-165992 Fix Chart Font Family #3685
Conversation
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| @@ -23,7 +23,7 @@ export default (deviceSize) => { | |||
| const axisColor = '#767676'; | |||
| const options = { | |||
| textStyle: { | |||
| fontFamily: 'Adobe Clean', | |||
| fontFamily: '"Adobe Clean", adobe-clean, "Trebuchet MS", sans-serif', | |||
There was a problem hiding this comment.
Do we really need to set a font family here? Ideally we want to inherit from body, which has the font family defined.
There was a problem hiding this comment.
The chart library will add a font family if you don't set any so inheriting from body won't work.
There was a problem hiding this comment.
@meganthecoder - using inherit should do the trick
There was a problem hiding this comment.
@narcis-radu Right, of course. Sorry, I didn't see this until after it got merged to stage. Do you want me to create a follow-up PR to change to inherit?
There was a problem hiding this comment.
@meganthecoder - only if it's not too much trouble. We don't change fonts that often, but if we do, it would be one less line to change if we use inherit. Thank you!
|
Reminder to set the |
Resolves: MWPW-165992
Test URLs: