[MWPW-173502] Remove hash from how-to schema #4299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zagi25
approved these changes
Jun 4, 2025
DKos95
approved these changes
Jun 4, 2025
|
Reminder to set the |
NadiiaSokolova
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-173502
skholkhojaev
added a commit
to skholkhojaev/milo
that referenced
this pull request
Jun 11, 2025
* [MWPW-173100][NALA] Automation test script for Timeline block (adobecom#4301) Update nala automation tests for timeline * Fixing replace check for Gnav test url (adobecom#4333) Fixing replace check for test url * MWPW-170229: Show action scroller nav on resize (adobecom#4311) * MWPW-170229: Show action scroller nav on resize * MWPW-170229: Debounce scroll and resize events * [MWPW-173161] - Refactor preflight to export checks (adobecom#4109) * MWPW-170805 initial refactoring of seo checks. * MWPW-170805 update the links method to cache its result * MWPW-170805 allow for document to be passed * update preflight * update performance checks * update assets checks * don't pass url if not necessary to assets * cache image result * import mini-preflight in utils * hotfix - seo title typos * hotfixes * hotfix * hotfix * Removed unnecessary comments * fixed linter errors * removed old performance panel unit tests * Mwpw 170378 preflight assets unit test (adobecom#4131) * added unit tests for assets tab in preflight * fixed linting * centralized checks imports * added unit tests --------- Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Sino Kholkhojaev <132879006+skholkhojaev@users.noreply.github.com> * MWPW-162398 enable mas preview (adobecom#4148) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * [Release] Stage to Main (adobecom#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (adobecom#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (adobecom#3817) * ENB-7820: Add values for event95 (adobecom#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (adobecom#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (adobecom#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (adobecom#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (adobecom#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (adobecom#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (adobecom#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (adobecom#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (adobecom#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-162398 draft * MWPW-162398 enable mas preview - getSettings will consider preview attribute of mas-commerce-service presence as the fact it should be using preview, - if preview is on, then using mas' previewFragment client library to act like adobeio, but on browser, - surface used (for stuff like placeholders) is either computed depending on wcs api key, or coming from preview parameter value, - is url is .page, or www.stage, then preview is set by default, - preview configuration can be overriden with masPreview parameter (url or local storage) set to off for disabling, or a value to use another surface (if api key is not corresponding to a registered surface) * some fixes * some other fixes * some doc and changes * small fixes * Reduce gnav lana sampleRate to 0.01% (adobecom#4150) * review comment * Revert "Improve carousel accessibility (adobecom#4103)" from prod (adobecom#4195) Revert "Improve carousel accessibility (adobecom#4103)" This reverts commit 34d2016. * some fixes * review comments --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-171672: Copy to clipboard for checkout CTAs (adobecom#4171) * added copying to clipboard * lint fix * moved to a separate module * used getMetadata * added a tooltip * fixed brackets * added ClipboardItem * updated tests * replaced the icon * updated unit test * MWPW-172886 [MEP][MILO] Dynamic content on RFI page via referrer | MEP (adobecom#4273) * first commit * Enhance path normalization to include localhost and simplify previous page match logic * Refactor checkForPreviousPageMatch to accept referrer as a parameter and add comprehensive tests * Remove commented suggestion for error handling * Refactor checkForPreviousPageMatch to use lastVisitedPage parameter for improved clarity * Exposing close gnav function for clients (adobecom#4274) * Exposing close gnav function for clients * Lint fix * Add a check if the gnav is in open state before calling toggle * MWPW-173759: Unordered list styling for merch cards (adobecom#4298) * MWPW-173759: Unordered list styling for merch cards * style specificity fix * [MWPW-173502] Remove hash from how-to schema (adobecom#4299) * [MWPW-174367] Inline fragment not behaving as expected in block (adobecom#4317) * Initial checkin. Working state. * Move replacecell handling to utils from fragments * Fix: Replace hardcoded string with constant for replacecell handling * Refactor: Replace constant OVERRIDE_AUTO_INLINE with inline string in modal handling * Unit testing. * Unit testing. * Removed unnecessary test statement. --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * MWPW-172018 Update default price for CIS umbrella regions to TM (adobecom#4323) Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * MWPW-173830: Add tooltip to notification pill (adobecom#4295) * MWPW-173830: Add tooltip to notification pill * MWPW-173830: PR feedback and add checks * MWPW-173528 Fix Safari mobile preview (adobecom#4231) * MWPW-173528 Fix Safari mobile preview Safari requires that the spoofed user agent be set on the load event and not before that. * Show the currently selected device view * Remove flicker when switching between devices * Fix CodeQL Incomplete URL substring sanitization --------- Co-authored-by: Biljana Cvijanovic <hit11757@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored 8AA9 -by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the div hash from the How To schema, as requested by the Tech SEO team.
Resolves: MWPW-173502
Test URLs: