[Release] Stage to Main #3772

milo-pr-merge · 2025-03-04T08:46:51Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

…e right side of GNAV. (#3728) * Added default case adobe 'A' logo on right side for GNAV(Adobe logo block) * Added default case adobe 'A' logo on right side for GNAV(Adobe logo block) --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>

… an iFrame (#3564) * added 3-in-1 modal * moved event listener * updated tests * addressed comments * fixed unit test * moved constants.js into mas.js * added cli param

* replace overflow x with contain layout * add a fix for breaking mobile gnav * move fix to existing media block

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Initial checkin. * Remove white space. --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

…3720) * load georoutingv2.json in parallel with georoutingv2.js * remove performance marks * fixed unit tests * Small refactoring * fallback for the jsonPromise * fix unit tests

* [MWPW-167749] table h header replaced * [MWPW-167749] optimization * [MWPW-167749] naming changes * [MWPW-167749] optimization * [MWPW-167749] code optimization * [MWPW-167749] col role removal * [MWPW-167749] code style update * [MWPW-167309] code improvement * [MWPW-167309] - header role paragraph

* MWPW-166176 - Stop initial tabs click propagation * PR feedback --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com>

viewport bug fix

milo-pr-merge · 2025-03-04T08:46:52Z

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

aem-code-sync · 2025-03-04T08:46:55Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

076ee63 ✅ (latest)
0ff9d06 ✅
005379e ✅
f8eb7e2 ✅
4df71c9 ✅
ed79397 ✅
a3ebf74 ✅
0f54535 ✅
80c79b5 ✅
1ae67fd ✅
8952d6d ✅

aem-code-sync · 2025-03-04T08:47:13Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-quantity-select.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-secure-transaction.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-sidenav.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-stock.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-subscription-panel.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-twp-d2p.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/deps/mas/merch-whats-included.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/src/buildCheckoutUrl.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/src/checkout-mixin.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/src/checkout.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/src/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/src/external.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/src/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/005379eabb39386f5335c7f25fabc859d736d726/libs/features/mas/test/build-checkout-url.test.js

github-actions · 2025-03-04T09:09:15Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-04T09:09:16Z

libs/deps/mas/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-04T09:09:17Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-04T09:09:18Z

libs/deps/mas/mas/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-04T09:09:19Z

libs/deps/mas/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-04T09:09:19Z

libs/deps/mas/merch-card-collection.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-04T09:09:20Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

sigadamvenkata

There are many areas broken in android mobile. there is huge white space introduced. PFA
Also Gnav has broken. PFA
reason PR: #3706

sigadamvenkata · 2025-03-05T07:33:25Z

Revert "replace overflow x with contain layout (#3706)" This reverts commit 0f54535.

github-actions · 2025-03-05T10:52:29Z

libs/features/mas/src/checkout-mixin.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-05T10:52:30Z

libs/features/mas/src/checkout.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-05T10:52:31Z

libs/features/mas/src/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-05T10:52:32Z

libs/features/mas/src/external.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-05T10:52:34Z

libs/features/mas/src/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-03-05T10:52:35Z

libs/features/mas/test/build-checkout-url.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Roycethan · 2025-03-05T17:06:13Z

Revert "replace overflow x with contain layout" Revert "replace overflow x with contain layout" #3776

Fixed post revert PR: #3776

Deva309 and others added 9 commits March 4, 2025 08:45

MWPW-164660: [3-in-1][Milo] Implement a link converter for CTAs using…

1ae67fd

… an iFrame (#3564) * added 3-in-1 modal * moved event listener * updated tests * addressed comments * fixed unit test * moved constants.js into mas.js * added cli param

MWPW-167928 Override Marketo POI (#3702)

80c79b5

replace overflow x with contain layout (#3706)

0f54535

* replace overflow x with contain layout * add a fix for breaking mobile gnav * move fix to existing media block

MWPW-168334 Load georoutingv2.json and georoutingv2.js in parallel (#…

ed79397

…3720) * load georoutingv2.json in parallel with georoutingv2.js * remove performance marks * fixed unit tests * Small refactoring * fallback for the jsonPromise * fix unit tests

MWPW-166176 - Stop initial tabs click propagation (#3726)

f8eb7e2

* MWPW-166176 - Stop initial tabs click propagation * PR feedback --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com>

Fix(mwpw-168006): Viewport bug fix. (#3730)

005379e

viewport bug fix

milo-pr-merge bot requested review from a team, Brandon32, meganthecoder, JasonHowellSlavin, salonijain3, bandana147, sharmrj, nishantka, Deva309 and sonawanesnehal3 as code owners March 4, 2025 08:46

github-actions bot reviewed Mar 4, 2025

View reviewed changes

< 10000 div data-view-component="true" class="TimelineItem-body d-flex flex-column flex-md-row flex-justify-start">
github-actions bot reviewed Mar 4, 2025

View reviewed changes

github-actions bot reviewed Mar 4, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge March 5, 2025 04:18 — with GitHub Actions Inactive

sigadamvenkata requested changes Mar 5, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge March 5, 2025 08:20 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge March 5, 2025 09:16 — with GitHub Actions Inactive

Revert "replace overflow x with contain layout" (#3776)

076ee63

Revert "replace overflow x with contain layout (#3706)" This reverts commit 0f54535.

github-actions bot reviewed Mar 5, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge March 5, 2025 12:30 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge March 5, 2025 16:24 — with GitHub Actions Inactive

Roycethan approved these changes Mar 5, 2025

View reviewed changes

Roycethan added the Homepage SOT 👌 label Mar 5, 2025

Roycethan temporarily deployed to milo_pr_merge March 5, 2025 17:07 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge March 5, 2025 20:16 — with GitHub Actions Inactive

JackySun9 approved these changes Mar 6, 2025

View reviewed changes

JackySun9 added the MIQ SOT👌 label Mar 6, 2025

JackySun9 temporarily deployed to milo_pr_merge March 6, 2025 00:29 — with GitHub Actions Inactive

skumar09 self-requested a review March 6, 2025 00:30

mokimo temporarily deployed to milo_pr_merge March 6, 2025 01:11 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge March 6, 2025 04:17 — with GitHub Actions Inactive

sigadamvenkata approved these changes Mar 6, 2025

View reviewed changes

sigadamvenkata added the CC SOT 👌 label Mar 6, 2025

sigadamvenkata temporarily deployed to milo_pr_merge March 6, 2025 08:02 — with GitHub Actions Inactive

milo-pr-merge bot merged commit 8dbad8c into main Mar 6, 2025
35 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge March 6, 2025 08:02 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Release] Stage to Main #3772

[Release] Stage to Main #3772

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[Release] Stage to Main #3772

[Release] Stage to Main #3772

Uh oh!

Conversation

Uh oh!

common base root URLs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!