Revert "[MWPW-173470] - Korea free trial restrict" (main) #4236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 351cfe6.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
| @@ -102,7 +101,7 @@ export const logPerformance = ( | |||
| sampleRate: 0.01, | |||
| }); | |||
| } catch (e) { | |||
| // eslint-disable-next-line no-empty | |||
| console.error(e); | |||
There was a problem hiding this comment.
Unexpected console statement.
narcis-radu
approved these changes
May 23, 2025
robert-bogos
approved these changes
May 23, 2025
|
Testing details , ready for MAIN https://stage--milo--adobecom.aem.page/kr/drafts/dusan/test-cta-removal?martech=off |
sheridansunier
pushed a commit
to sheridansunier/milo
that referenced
this pull request
Jun 16, 2025
) Revert "[MWPW-173470] - Korea free trial restrict (adobecom#4185)" This reverts commit 351cfe6.
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 17, 2025
…on contrast / navigation title (#4355) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824) MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630) * updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error * changed a ; to a , * Removed the svg as it was unnecessary Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * Reduce gnav lana sampleRate to 0.01% (#4150) * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236) Revert "[MWPW-173470] - Korea free trial restrict (#4185)" This reverts commit 351cfe6. * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237) * MWPW-173875 direct to main * Korea free trial restrict (#4282) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)" This reverts commit 7b82821. * Update utilities.js (#4312) Making a change to the utilities file Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> * MWPW-173772 [merch-card-collection] introduce mobile filter text * MWPW-173772 fix for catalog * icon & display text mgt * fix * more fixes * add more unit test * fixing autoblock fill * MWPW-173772 bump sidenav h2 font size by 1px --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Jun 23, 2025
…nt (#4417) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [Release] Stage to Main (#3817) * ENB-7820: Add values for event95 (#3782) * Add values for event95 * Fix failing test case * Remove spaces * Minimal Impact: Add extra key for other features * Minimal Impact: change function name * [MWPW-168691] - Aside cta shrink JP (#3785) * [MWPW-168691] cta shrink fix * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] update * [MWPW-168691] updated solution * Revert "[MWPW-168691]" This reverts commit a70f9ca. Revert "[MWPW-168691] update" This reverts commit 6aac2bc. Revert "[MWPW-168691] update" This reverts commit c0c6a34. Revert "[MWPW-168691] update" This reverts commit 017edf0. Revert "[MWPW-168691] update" This reverts commit 219e5fd. Revert "[MWPW-168691] update" This reverts commit a7df2b5. Revert "[MWPW-168691] update" This reverts commit 299a7d7. Revert "[MWPW-168691] update" This reverts commit 6709515. Revert "[MWPW-168691] cta shrink fix" This reverts commit c90eea6. * MWPW-168691: Prevent cta jp word wrap on large screens * MWPW-168691: Fix notification jp cta * MWPW-168691: Hide wbr cta for tablet and desktop --------- Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> * MWPW-169371 : Adding countryCode config to UNav (#3793) * Adding countryCode config to UNav * Updating countryCode for uk * Updating for upperCase * Passing countryCode according to MAS mapping for UCv3 cart --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-167716 Remove await from both gnav and georouting (#3680) Made georouting and globalnavigation non blocking * Lnav title and headline text overflow support (#3781) * Lnav title text overflow support * Fix for chevron icon top position * Adding white space break for localnav menus * Adding white space break for localnav menus * Adding white space break for localnav list menus * Inclufing white spaces to non menu items * [MWPW-169500] SEO- Links check failing breaks Preflight (#3803) fixed preflight seo links check * MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813) * on prod federal content for the standalone gnav and footer needs to come from * handled situations where we're stage and when we're neither stage nor prod * MWPW-169416 [MEP] stop treating remove action differently in preview (#3789) * truly remove elements, even in preview * unit test update * fix for MWPW-169416, new remove action in MEP * lint clean-up --------- Co-authored-by: John Pratt <jpratt@adobe.com> --------- Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> * Revert "Improve carousel accessibility (#4103)" from prod (#4195) Revert "Improve carousel accessibility (#4103)" This reverts commit 34d2016. * Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236) Revert "[MWPW-173470] - Korea free trial restrict (#4185)" This reverts commit 351cfe6. * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237) * Korea free trial restrict (#4282) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)" This reverts commit 7b82821. * MWPW-74582: ensure that empty primaryCtas are not being sent through to caas * ugh rebasing stage is the worst * omg literally the worst * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * rebase weirdness * omg this whitespace will be the death of me * MWPW-74582: carlos revsion --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Swati Mukherjee <swati020494@gmail.com> Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com> Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: John Pratt <jpratt@adobe.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4185 from main