8000 MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix by st-angelo-adobe · Pull Request #4237 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix #4237

merged 1 commit into from
May 23, 2025

Conversation

st-angelo-adobe
Copy link
Contributor
@st-angelo-adobe st-angelo-adobe commented May 23, 2025 •
edited by mokimo
Loading

PR was already approved to stage: #4225 & this PR to main exists to fast-track this to production without affecting the current stage batch

Resolves: MWPW-173888, MWPW-173919

GWP staged content with 3in1 modals on Stage. Planned go live 5th June.
Warriors implemented feature flag "mas-ff-3in1", to enable GWP publish 3in1 modals before 5th June. Until metadata flag is removed/switched to "on", 3in1 modals will fallback to be shown as legacy Dexter Modals.

However we've identified 2 issues with fallback mechanism:

Issue 1

deeplinking with ms=e and cs=t is not working on fallback legacy modals

Issue 2

if there are multiple modals with same hash, then opening the page with hash will result in hanging modal and all of them opening at the same time.

This PR is blocking GWP from publishing content, so we will be requesting approval to merge it during RCP.

Test URLs:

Can be tested by overriding the source directly on these urls
https://www.adobe.com/cc-shared/fragments/drafts/mariia/3in1
https://www.stage.adobe.com/cc-shared/fragments/drafts/mariia/3in1

@st-angelo-adobe st-angelo-adobe requested a review from a team as a code owner May 23, 2025 07:52
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented May 23, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@st-angelo-adobe st-angelo-adobe changed the title MWPW-173888 + MWPW-173919: Appending extra options for relative urls … MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix May 23, 2025
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented May 23, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@afmicka afmicka added the verified PR has been E2E tested by a reviewer label May 23, 2025
@mokimo mokimo merged commit 4fb87b7 into main May 23, 2025
17 of 18 checks passed
@mokimo mokimo deleted the MWPW-173888 branch May 23, 2025 10:40
sheridansunier pushed a commit to sheridansunier/milo that referenced this pull request Jun 16, 2025
@st-angelo-adobe
MWPW-173888 + MWPW-173919: Appending extra options for relative urls …
9244603 
…& multiple cta reopen fix (adobecom#4237)
milo-pr-merge bot added a commit that referenced this pull request Jun 17, 2025
@npeltier @milo-pr-merge
@mokimo @sharmrj @swamu @DKos95 @zagi25 @sonawanesnehal3 @bandana147 @robert-bogos @vgoodric @chrischrischris @st-angelo-adobe @Blainegunn @overmyheadandbody @narcis-radu @salonijain3 @3ch023
MWPW-173772 [merch-card-collection] introduce mobile filter text / ic…
ddc63be 
…on contrast / navigation title (#4355)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* [Release] Stage to Main (#3817)

* ENB-7820: Add values for event95 (#3782)

* Add values for event95

* Fix failing test case

* Remove spaces

* Minimal Impact: Add extra key for  other features

* Minimal Impact: change function name

* [MWPW-168691] - Aside cta shrink JP (#3785)

* [MWPW-168691] cta shrink fix

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] updated solution

* Revert "[MWPW-168691]"

This reverts commit a70f9ca.

Revert "[MWPW-168691] update"

This reverts commit 6aac2bc.

Revert "[MWPW-168691] update"

This reverts commit c0c6a34.

Revert "[MWPW-168691] update"

This reverts commit 017edf0.

Revert "[MWPW-168691] update"

This reverts commit 219e5fd.

Revert "[MWPW-168691] update"

This reverts commit a7df2b5.

Revert "[MWPW-168691] update"

This reverts commit 299a7d7.

Revert "[MWPW-168691] update"

This reverts commit 6709515.

Revert "[MWPW-168691] cta shrink fix"

This reverts commit c90eea6.

* MWPW-168691: Prevent cta jp word wrap on large screens

* MWPW-168691: Fix notification jp cta

* MWPW-168691: Hide wbr cta for tablet and desktop

---------

Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>

* MWPW-169371 : Adding countryCode config to UNav (#3793)

* Adding countryCode config to UNav

* Updating countryCode for uk

* Updating for upperCase

* Passing countryCode according to MAS mapping for UCv3 cart

---------

Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>

* MWPW-167716 Remove await from both gnav and georouting (#3680)

Made georouting and globalnavigation non blocking

* Lnav title and headline text overflow support (#3781)

* Lnav title text overflow support

* Fix for chevron icon top position

* Adding white space break for localnav menus

* Adding white space break for localnav menus

* Adding white space break for localnav list menus

* Inclufing white spaces to non menu items

* [MWPW-169500] SEO- Links check failing breaks Preflight (#3803)

fixed preflight seo links check

* MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813)

* on prod federal content for the standalone gnav and footer needs to come from

* handled situations where we're stage and when we're neither stage nor prod

* MWPW-169416 [MEP] stop treating remove action differently in preview (#3789)

* truly remove elements, even in preview

* unit test update

* fix for MWPW-169416, new remove action in MEP

* lint clean-up

---------

Co-authored-by: John Pratt <jpratt@adobe.com>

---------

Co-authored-by: Swati Mukherjee <swati020494@gmail.com>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com>
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: John Pratt <jpratt@adobe.com>

* MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3824)

MWPW-167191 Removed an unnecessary css url() that was causing a console error (#3630)

* updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error

* changed a ; to a ,

* Removed the svg as it was unnecessary

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* Reduce gnav lana sampleRate to 0.01% (#4150)

* Revert "Improve carousel accessibility (#4103)" from prod (#4195)

Revert "Improve carousel accessibility (#4103)"

This reverts commit 34d2016.

* Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236)

Revert "[MWPW-173470] - Korea free trial restrict (#4185)"

This reverts commit 351cfe6.

* MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237)

* MWPW-173875 direct to main

* Korea free trial restrict (#4282)

* [MWPW-173016] - block korea free trial links/buttons

* [MWPW-173016] - korea text filter added

* [MWPW-173016] - update if

* [MWPW-173016] - code optimization

* [MWPW-173016] - improve import

* [MWPW-173016] - modal check, string check added

* [MWPW-173016] - strings added

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - remove whitespace

* [MWPW-173470] - optimize

* [MWPW-173470] - remove variable

* [MWPW-173016] - optimize code

* [MWPW-173016] - group logic

* [MWPW-173016] - merch solution added

* [MWPW-173016] - merch ref comment added

* [MWPW-173470] - null safe

* [MWPW-173470] - code optimization

* [MWPW-173470] - nav korea restrict coverage

* [MWPW-173470] - fix eslint console error

---------

Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com>

* Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)"

This reverts commit 7b82821.

* Update utilities.js (#4312)

Making a change to the utilities file

Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com>

* MWPW-173772 [merch-card-collection] introduce mobile filter text

* MWPW-173772 fix for catalog

* icon & display text mgt

* fix

* more fixes

* add more unit test

* fixing autoblock fill

* MWPW-173772 bump sidenav h2 font size by 1px

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Swati Mukherjee <swati020494@gmail.com>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com>
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: John Pratt <jpratt@adobe.com>
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
milo-pr-merge bot added a commit that referenced this pull request Jun 23, 2025
@sheridansunier @mokimo
@milo-pr-merge @sharmrj @swamu @DKos95 @zagi25 @sonawanesnehal3 @bandana147 @robert-bogos @vgoodric @st-angelo-adobe @overmyheadandbody @narcis-radu
MWPW-74582: add guardrails to prevent empty primaryCtas from being se…
4380afd 
…nt (#4417)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* [Release] Stage to Main (#3817)

* ENB-7820: Add values for event95 (#3782)

* Add values for event95

* Fix failing test case

* Remove spaces

* Minimal Impact: Add extra key for  other features

* Minimal Impact: change function name

* [MWPW-168691] - Aside cta shrink JP (#3785)

* [MWPW-168691] cta shrink fix

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] updated solution

* Revert "[MWPW-168691]"

This reverts commit a70f9ca.

Revert "[MWPW-168691] update"

This reverts commit 6aac2bc.

Revert "[MWPW-168691] update"

This reverts commit c0c6a34.

Revert "[MWPW-168691] update"

This reverts commit 017edf0.

Revert "[MWPW-168691] update"

This reverts commit 219e5fd.

Revert "[MWPW-168691] update"

This reverts commit a7df2b5.

Revert "[MWPW-168691] update"

This reverts commit 299a7d7.

Revert "[MWPW-168691] update"

This reverts commit 6709515.

Revert "[MWPW-168691] cta shrink fix"

This reverts commit c90eea6.

* MWPW-168691: Prevent cta jp word wrap on large screens

* MWPW-168691: Fix notification jp cta

* MWPW-168691: Hide wbr cta for tablet and desktop

---------

Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>

* MWPW-169371 : Addin
9B95
g countryCode config to UNav (#3793)

* Adding countryCode config to UNav

* Updating countryCode for uk

* Updating for upperCase

* Passing countryCode according to MAS mapping for UCv3 cart

---------

Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>

* MWPW-167716 Remove await from both gnav and georouting (#3680)

Made georouting and globalnavigation non blocking

* Lnav title and headline text overflow support (#3781)

* Lnav title text overflow support

* Fix for chevron icon top position

* Adding white space break for localnav menus

* Adding white space break for localnav menus

* Adding white space break for localnav list menus

* Inclufing white spaces to non menu items

* [MWPW-169500] SEO- Links check failing breaks Preflight (#3803)

fixed preflight seo links check

* MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813)

* on prod federal content for the standalone gnav and footer needs to come from

* handled situations where we're stage and when we're neither stage nor prod

* MWPW-169416 [MEP] stop treating remove action differently in preview (#3789)

* truly remove elements, even in preview

* unit test update

* fix for MWPW-169416, new remove action in MEP

* lint clean-up

---------

Co-authored-by: John Pratt <jpratt@adobe.com>

---------

Co-authored-by: Swati Mukherjee <swati020494@gmail.com>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com>
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: John Pratt <jpratt@adobe.com>

* Revert "Improve carousel accessibility (#4103)" from prod (#4195)

Revert "Improve carousel accessibility (#4103)"

This reverts commit 34d2016.

* Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236)

Revert "[MWPW-173470] - Korea free trial restrict (#4185)"

This reverts commit 351cfe6.

* MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237)

* Korea free trial restrict (#4282)

* [MWPW-173016] - block korea free trial links/buttons

* [MWPW-173016] - korea text filter added

* [MWPW-173016] - update if

* [MWPW-173016] - code optimization

* [MWPW-173016] - improve import

* [MWPW-173016] - modal check, string check added

* [MWPW-173016] - strings added

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - remove whitespace

* [MWPW-173470] - optimize

* [MWPW-173470] - remove variable

* [MWPW-173016] - optimize code

* [MWPW-173016] - group logic

* [MWPW-173016] - merch solution added

* [MWPW-173016] - merch ref comment added

* [MWPW-173470] - null safe

* [MWPW-173470] - code optimization

* [MWPW-173470] - nav korea restrict coverage

* [MWPW-173470] - fix eslint console error

---------

Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com>

* Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)"

This reverts commit 7b82821.

* MWPW-74582: ensure that empty primaryCtas are not being sent through to caas

* ugh rebasing stage is the worst

* omg literally the worst

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* omg this whitespace will be the death of me

* MWPW-74582: carlos revsion

---------

Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Swati Mukherjee <swati020494@gmail.com>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com>
Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: John Pratt <jpratt@adobe.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3ch023 3ch023 3ch023 approved these changes

@mokimo mokimo mokimo approved these changes

Assignees
No one assigned
Labels
verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@st-angelo-adobe @3ch023 @mokimo @afmicka
0