8000 [MWPW-167031] top tooltip rtl fix by DKos95 · Pull Request #3618 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MWPW-167031] top tooltip rtl fix #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 3, 2025
Merged

Conversation

DKos95
Copy link
Contributor
@DKos95 DKos95 commented Feb 4, 2025

This resolves the issue where the top tooltip was not properly displayed for right-to-left languages.

Resolves: MWPW-167031

Test URLs:

Copy link
Contributor
aem-code-sync bot commented Feb 4, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
aem-code-sync bot commented Feb 4, 2025

< 8000 /p>

@aem-code-sync aem-code-sync bot temporarily deployed to tooltip-rtl-position February 4, 2025 11:36 Inactive
Copy link
Contributor
@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it seems like we're adding too much overhead to get these to work. I had a look at tooltips outside of the table context and they seem to work just fine. I decided to disable all the tooltip overrides from the table.css file to see how tooltips behave and at a first glance things look good:
Screenshot 2025-02-04 at 18 28 17

Could we do an assessment to figure out why we need to override so many tooltip styles in the context of the table in the first place?

Copy link
Contributor
@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

Copy link
Contributor
@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@aem-code-sync aem-code-sync bot temporarily deployed to tooltip-rtl-position February 7, 2025 10:23 Inactive
@DKos95 DKos95 force-pushed the tooltip-rtl-position branch from 80a3890 to fe03f22 Compare February 7, 2025 12:18
Copy link
Contributor
github-actions bot commented Feb 8, 2025

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@aem-code-sync aem-code-sync bot temporarily deployed to tooltip-rtl-position February 10, 2025 14:29 Inactive
@DKos95 DKos95 force-pushed the tooltip-rtl-position branch from 76bd692 to 9693f6c Compare February 14, 2025 08:39
@aem-code-sync aem-code-sync bot temporarily deployed to tooltip-rtl-position February 14, 2025 08:39 Inactive
@DKos95
Copy link
Contributor Author
DKos95 commented Feb 14, 2025

Hi @DKos95 ! Please mark as resolved the conversations from Rares, which are implemented/resolved. It will be easier to review for others 👍

Thanks for the tip, will definitely do that for future PR's.

Regarding this PR, I think that this ticket has made this kind of overengineering, since it seems that with the tooltip width now reduced for Desktop it never seems to overflow, so a solution would only be needed for Mobile and Tablet which would be simpler.

Copy link
Contributor
@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip looks much smaller with these changes. I think that some styles aren't getting applied properly anymore.

Before:
image

After
image

I don't know the complexity of this task either , but I'd also say that a pure CSS solution seems like the right way to go for performance and simplicity, which is also what you originally did. So I'm mainly just curious why you've now opted for the JS approach?

Copy link
Contributor
@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@DKos95
Copy link
Contributor Author
DKos95 commented Feb 17, 2025

The tooltip looks much smaller with these changes. I think that some styles aren't getting applied properly anymore.

Before: image

After image

I don't know the complexity of this task either , but I'd also say that a pure CSS solution seems like the right way to go for performance and simplicity, which is also what you originally did. So I'm mainly just curious why you've now opted for the JS approach?

This is from another ticket already on stage: https://jira.corp.adobe.com/browse/MWPW-155282

Edit: The js approach is because there was a lot of stuff copied to table.css from icon.css for these overflow situations that happened with the old tooltip width, this way we don't have to copy over design to make the tooltip fit for a overflow situation and if in future icons change style we don't have to change at two places.

@SilviuLCF SilviuLCF requested a review from vhargrave February 17, 2025 08:36
6DAF
@vhargrave
Copy link
Contributor

The tooltip looks much smaller with these changes. I think that some styles aren't getting applied properly anymore.
Before: image
After image
I don't know the complexity of this task either , but I'd also say that a pure CSS solution seems like the right way to go for performance and simplicity, which is also what you originally did. So I'm mainly just curious why you've now opted for the JS approach?

This is from another ticket already on stage: https://jira.corp.adobe.com/browse/MWPW-155282

Got it, thanks!
@DKos95 one more thing that I'm noticing is that the default positioning of the tooltip on rtl pages is now covering the text.
I imagine that shouldn't be the case right?
image

@DKos95
Copy link
Contributor Author
DKos95 commented Feb 17, 2025

The tooltip looks much smaller with these changes. I think that some styles aren't getting applied properly anymore.
Before: image
After image
I don't know the complexity of this task either , but I'd also say that a pure CSS solution seems like the right way to go for performance and simplicity, which is also what you originally did. So I'm mainly just curious why you've now opted for the JS approach?

This is from another ticket already on stage: https://jira.corp.adobe.com/browse/MWPW-155282

Got it, thanks! @DKos95 one more thing that I'm noticing is that the default positioning of the tooltip on rtl pages is now covering the text. I imagine that shouldn't be the case right? image

Hmm, from what I can see on main branch, the right position was applied also to this situation but because of the size of the tooltip it went to left because it had no space to go right, now that the width is smaller it has space so it goes right where the author wants it.

Screenshot 2025-02-17 at 10 54 42

@vhargrave
Copy link
Contributor

The tooltip looks much smaller with these changes. I think that some styles aren't getting applied properly anymore.
Before: image
After image
I don't know the complexity of this task either , but I'd also say that a pure CSS solution seems like the right way to go for performance and simplicity, which is also what you originally did. So I'm mainly just curious why you've now opted for the JS approach?

This is from another ticket already on stage: https://jira.corp.adobe.com/browse/MWPW-155282

Got it, thanks! @DKos95 one more thing that I'm noticing is that the default positioning of the tooltip on rtl pages is now covering the text. I imagine that shouldn't be the case right? image

Hmm, from what I can see on main branch, the right position was applied also to this situation but because of the size of the tooltip it went to left because it had no space to go right, now that the width is smaller it has space so it goes right where the author wants it.

Screenshot 2025-02-17 at 10 54 42

@DKos95 Shouldn't it go left by default on rtl settings if no position has been set?
I looked on stage and it seems to be right there.

@DKos95
Copy link
Contributor Author
DKos95 commented Feb 17, 2025

The tooltip looks much smaller with these changes. I think that some styles aren't getting applied properly anymore.
Before: image
After image
I don't know the complexity of this task either , but I'd also say that a pure CSS solution seems like the right way to go for performance and simplicity, which is also what you originally did. So I'm mainly just curious why you've now opted for the JS approach?

This is from another ticket already on stage: https://jira.corp.adobe.com/browse/MWPW-155282

Got it, thanks! @DKos95 one more thing that I'm noticing is that the default positioning of the tooltip on rtl pages is now covering the text. I imagine that shouldn't be the case right? image

Hmm, from what I can see on main branch, the right position was applied also to this situation but because of the size of the tooltip it went to left because it had no space to go right, now that the width is smaller it has space so it goes right where the author wants it.
Screenshot 2025-02-17 at 10 54 42

@DKos95 Shouldn't it go left by default on rtl settings if no position has been set? I looked on stage and it seems to be right there.

From what I can see it has the class right by default, but it goes left because of these old css rules for that resolution which were probably implemented because if it went right it would overflow, which now is not an issue, in any case I will be syncing these concerns with Rares tomorrow.

@SilviuLCF SilviuLCF self-requested a review February 18, 2025 09:07
Copy link
Contributor
@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see we no longer have to duplicate the tooltip styles from the icons file! I noticed that we can once again trigger the tooltip by hovering around the icon, but without triggering the focus state. Didn't we fix this at one point?
Screenshot 2025-02-19 at 11 59 50

Not a big issue and not related to the changes from this PR, but we might want to look into this in the future.

@overmyheadandbody overmyheadandbody dismissed vhargrave’s stale review February 19, 2025 11:02

Reported issue is caused by other tooltip changes, unrelated to this PR.

@NadiiaSokolova NadiiaSokolova self-assigned this Feb 24, 2025
Copy link
@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-167031

@milo-pr-merge milo-pr-merge bot merged commit 8d7557a into stage Mar 3, 2025
16 checks passed
@milo-pr-merge milo-pr-merge bot deleted the tooltip-rtl-position branch March 3, 2025 10:27
@milo-pr-merge milo-pr-merge bot mentioned this pull request Mar 3, 2025
sanrai pushed a commit that referenced this pull request Mar 5, 2025
* [MWPW-167031] tooltip top rtl fix

* [MWPW-167031] spacing corrections

* [MWPW-167031] css optimization

* [MWPW-167031] replaced css with js logic

* [MWPW-167031] optimization

* [MWPW-167031] optimization
vgoodric pushed a commit that referenced this pull request Mar 6, 2025
… Tab as Android (#3766)

* [MWPW-159511] Create anchor (ID) elements (#3714)

* [MWPW-159511] Create anchor (ID) elements

* address feedback

* address feedback

* [MWPW-167031] top tooltip rtl fix (#3618)

* [MWPW-167031] tooltip top rtl fix

* [MWPW-167031] spacing corrections

* [MWPW-167031] css optimization

* [MWPW-167031] replaced css with js logic

* [MWPW-167031] optimization

* [MWPW-167031] optimization

* MWPW-164492: Plans Card via MAS (#3649)

* first draft

* add callout

* fix stock js issue

* fix plans variant

* remove sitemap

* fix unit tests

* add nala tests

* MWPW-167305 [Plans Milo] Callout grey block: authoring improvement (#3663)

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

* use consonant cta for plans

* add plans.md

* fix review comments

* fix merge issue

* revert obsolete change

* fix nala tests

* address review comments

* merge in stage

* Fix regression

* fix nala tests comments

---------

Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

* MWPW-160954 Marketo Multi-step (#3671)

* MWPW-160954 Marketo Multi-step

* PR Changes

* QA Fixes

* Next button fix

* Adding support for first localnav menu being a dropdown (#3693)

* Adding support for localnav item being a dropdown

* Fix for button text

* wip

* Updating title for dropdown

* Updating mock for localnav

* Fixing button text

* Lint fix

* Replacing button text after copying

* Lint fix

* [MWPW-162639] youtube block a tag fix (#3703)

* [MWPW-162639] youtube block a tag fix

* [MWPW-162639] condition update

* [MWPW-162639] clause fix

* [MWPW-162639] code removal

* Fix(mwpw-163031): Typo fix long-form (#3710)

* new event added for autoplay videos

* combining the fixe for 163031

* Update adobetv.js

* Upgrading standalone gnav version to 0.0.5 (#3712)

Upgrading gnav version to 0.0.5

* MWPW-167455: Remove node cloning (#3715)

* MWPW-167455: Remove node cloning

* MWPW-167455: Remove redundant code

* MWPW-167455: Remove video test

* MWPW-167455: Remove unnecessary code

* MWPW-167455: Change test name

* Add fix for galaxy tab

* [MWPW-167349] - Added a default logo for the 'A' icon displayed on the right side of GNAV. (#3728)

* Added default case adobe 'A' logo on right side for GNAV(Adobe logo block)

* Added default case adobe 'A' logo on right side for GNAV(Adobe logo block)

---------

Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>

* MWPW-164660: [3-in-1][Milo] Implement a link converter for CTAs using an iFrame (#3564)

* added 3-in-1 modal

* moved event listener

* updated tests

* addressed comments

* fixed unit test

* moved constants.js into mas.js

* added cli param

* MWPW-167928 Override Marketo POI (#3702)

* replace overflow x with contain layout (#3706)

* replace overflow x with contain layout

* add a fix for breaking mobile gnav

* move fix to existing media block

* [MWPW-168309] 2 small MEP button updates (#3719)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* Initial checkin.

* Remove white space.

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* MWPW-168334 Load georoutingv2.json and georoutingv2.js in parallel (#3720)

* load georoutingv2.json in parallel with georoutingv2.js

* remove performance marks

* fixed unit tests

* Small refactoring

* fallback for the jsonPromise

* fix unit tests

* [MWPW-167309] - Table h tags replace (#3721)

* [MWPW-167749] table h header replaced

* [MWPW-167749] optimization

* [MWPW-167749] naming changes

* [MWPW-167749] optimization

* [MWPW-167749] code optimization

* [MWPW-167749] col role removal

* [MWPW-167749] code style update

* [MWPW-167309] code improvement

* [MWPW-167309] - header role paragraph

* MWPW-166176 - Stop initial tabs click propagation (#3726)

* MWPW-166176 - Stop initial tabs click propagation

* PR feedback

---------

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* Fix(mwpw-168006): Viewport bug fix. (#3730)

viewport bug fix

* Remove file overlap condition from merge to stage workflow (#3736)

Remove file overlap condition

* Revert "replace overflow x with contain layout" (#3776)

Revert "replace overflow x with contain layout (#3706)"

This reverts commit 0f54535.

* Adding a class to convert group link title to a simple header instead of a link (#3769)

Adding a class to convert group link title to a simple header instead of link

* MWPW-164093: Adobe Home "Try Buy Widget" merch card (#3651)

* MWPW-164093: Adobe Home 'Pricing Widget' merch card

Co-Authored-By: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>

* styles

* cr fixes

* refactored swc cta creation

* wip

* Revert "wip"

This reverts commit ebede48.

* wip

* wip

* wip

* removed loading promise from race

* tacocat update

* new fragment mapping approach

* typo fix

* adobe home card improvements

* Enhance merch card background and border color handling

- Refactored background color processing to support custom color mapping
- Updated border color processing to use CSS custom properties
- Added more flexible color configuration for merch cards
- Improved test coverage for color-related functions
- Removed hardcoded color and border styling in favor of dynamic properties

* truncate fixes

* benchmarks duration update

* truncation error handling

* reubens comments

* updated deps

* unit test fix

* data-href for event capture

* Delete .cursor.zip

* Update .gitignore

* bubbled click event

* dataset url

* wip

* Move SWC buttons to light DOM (#3734)

* Move SWC buttons to light DOM

* fix doc

* css padding reset

* remove .cursor rules

* NALA tests

* improved nala tests

* lcp improvements on docs page

* lcp improvements

* Revert "lcp improvements"

This reverts commit bb26697.

* Revert "lcp improvements on docs page"

This reverts commit 936cf14.

* Update MAS package.json version

* fixed nala tests

* lint fixes

* nala test title fixed

* fixed test

* conflicts resolved for the nth time

* conflicts resolved

* no source maps

* right bg color for ah try card

* sp-button analytics

* data-analytics-id in sp-button

* MWPW-169143: AH Try/Buy Widget sizing fixes

* data-analytics-id on checkoutButton

* version bump

---------

Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>
Co-authored-by: astatescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Ilyas Türkben <ilyas@adobe.com>

* [MWPW-167752] Loop focus in modals containing iframes (#3716)

* MWPW-163228: Preflight svg issue (#3725)

* WIP: Pushing just for preview purposes

* Added messaging to clairfy the status of the SVG

* Strange issues with dev tools, removing fetch to avoid possible CORS, adding external url to show authors where content lives

* Updating tags and errortype for PEP lana logs (#3731)

Lana log message fix

* MWPW-151376: Check sharepoint url (#3733)

* [MWPW-167759] Hero marquee bg-bottom-tablet fix (#3735)

* MWPW-166689 Add video support to Article Header (#3737)

* MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav (#3739)

* MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav

* apply fix specific to button inside feds promo

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com>
Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com>
Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Prince Patel <prpatel0949@gmail.com>
Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>
Co-authored-by: astatescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Ilyas Türkben <ilyas@adobe.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Jason Slavin <slavin@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
milo-pr-merge bot added a commit that referenced this pull request Mar 10, 2025
* [MEP][AJO] POC to integrate AJO with MEP (#3654)

* Add ajo integration

* Remove AJO references from pznv2 for now

* Remove another ajo reference

* revert formatting

* Remove hard-coded url

* Add tests for enabling ajo

* MWPW-167217 [MEP] preserve hash in normalizePath (#3751)

* Update normalizePath to retain hash

* Revert change that will go in separate PR

* Update tests

* Update to align with getFederatedUrl

* Refactor

* MWPW-169117[MEP][MILO] Update Personalization Tabs to identity Galaxy Tab as Android (#3766)

* [MWPW-159511] Create anchor (ID) elements (#3714)

* [MWPW-159511] Create anchor (ID) elements

* address feedback

* address feedback

* [MWPW-167031] top tooltip rtl fix (#3618)

* [MWPW-167031] tooltip top rtl fix

* [MWPW-167031] spacing corrections

* [MWPW-167031] css optimization

* [MWPW-167031] replaced css with js logic

* [MWPW-167031] optimization

* [MWPW-167031] optimization

* MWPW-164492: Plans Card via MAS (#3649)

* first draft

* add callout

* fix stock js issue

* fix plans variant

* remove sitemap

* fix unit tests

* add nala tests

* MWPW-167305 [Plans Milo] Callout grey block: authoring improvement (#3663)

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

* use consonant cta for plans

* add plans.md

* fix review comments

* fix merge issue

* revert obsolete change

* fix nala tests

* address review comments

* merge in stage

* Fix regression

* fix nala tests comments

---------

Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

* MWPW-160954 Marketo Multi-step (#3671)

* MWPW-160954 Marketo Multi-step

* PR Changes

* QA Fixes

* Next button fix

* Adding support for first localnav menu being a dropdown (#3693)

* Adding support for localnav item being a dropdown

* Fix for button text

* wip

* Updating title for dropdown

* Updating mock for localnav

* Fixing button text

* Lint fix

* Replacing button text after copying

* Lint fix

* [MWPW-162639] youtube block a tag fix (#3703)

* [MWPW-162639] youtube block a tag fix

* [MWPW-162639] condition update

* [MWPW-162639] clause fix

* [MWPW-162639] code removal

* Fix(mwpw-163031): Typo fix long-form (#3710)

* new event added for autoplay videos

* combining the fixe for 163031

* Update adobetv.js

* Upgrading standalone gnav version to 0.0.5 (#3712)

Upgrading gnav version to 0.0.5

* MWPW-167455: Remove node cloning (#3715)

* MWPW-167455: Remove node cloning

* MWPW-167455: Remove redundant code

* MWPW-167455: Remove video test

* MWPW-167455: Remove unnecessary code

* MWPW-167455: Change test name

* Add fix for galaxy tab

* [MWPW-167349] - Added a default logo for the 'A' icon displayed on the right side of GNAV. (#3728)

* Added default case adobe 'A' logo on right side for GNAV(Adobe logo block)

* Added default case adobe 'A' logo on right side for GNAV(Adobe logo block)

---------

Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>

* MWPW-164660: [3-in-1][Milo] Implement a link converter for CTAs using an iFrame (#3564)

* added 3-in-1 modal

* moved event listener

* updated tests

* addressed comments

* fixed unit test

* moved constants.js into mas.js

* added cli param

* MWPW-167928 Override Marketo POI (#3702)

* replace overflow x with contain layout (#3706)

* replace overflow x with contain layout

* add a fix for breaking mobile gnav

* move fix to existing media block

* [MWPW-168309] 2 small MEP button updates (#3719)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* Initial checkin.

* Remove white space.

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* MWPW-168334 Load georoutingv2.json and georoutingv2.js in parallel (#3720)

* load georoutingv2.json in parallel with georoutingv2.js

* remove performance marks

* fixed unit tests

* Small refactoring

* fallback for the jsonPromise

* fix unit tests

* [MWPW-167309] - Table h tags replace (#3721)

* [MWPW-167749] table h header replaced

* [MWPW-167749] optimization

* [MWPW-167749] naming changes

* [MWPW-167749] optimization

* [MWPW-167749] code optimization

* [MWPW-167749] col role removal

* [MWPW-167749] code style update

* [MWPW-167309] code improvement

* [MWPW-167309] - header role paragraph

* MWPW-166176 - Stop initial tabs click propagation (#3726)

* MWPW-166176 - Stop initial tabs click propagation

* PR feedback

---------

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* Fix(mwpw-168006): Viewport bug fix. (#3730)

viewport bug fix

* Remove file overlap condition from merge to stage workflow (#3736)

Remove file overlap condition

* Revert "replace overflow x with contain layout" (#3776)

Revert "replace overflow x with contain layout (#3706)"

This reverts commit 0f54535.

* Adding a class to convert group link title to a simple header instead of a link (#3769)

Adding a class to convert group link title to a simple header instead of link

* MWPW-164093: Adobe Home "Try Buy Widget" merch card (#3651)

* MWPW-164093: Adobe Home 'Pricing Widget' merch card

Co-Authored-By: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>

* styles

* cr fixes

* refactored swc cta creation

* wip

* Revert "wip"

This reverts commit ebede48.

* wip

* wip

* wip

* removed loading promise from race

* tacocat update

* new fragment mapping approach

* typo fix

* adobe home card improvements

* Enhance merch card background and border color handling

- Refactored background color processing to support custom color mapping
- Updated border color processing to use CSS custom properties
- Added more flexible color configuration for merch cards
- Improved test coverage for color-related functions
- Removed hardcoded color and border styling in favor of dynamic properties

* truncate fixes

* benchmarks duration update

* truncation error handling

* reubens comments

* updated deps

* unit test fix

* data-href for event capture

* Delete .cursor.zip

* Update .gitignore

* bubbled click event

* dataset url

* wip

* Move SWC buttons to light DOM (#3734)

* Move SWC buttons to light DOM

* fix doc

* css padding reset

* remove .cursor rules

* NALA tests

* improved nala tests

* lcp improvements on docs page

* lcp improvements

* Revert "lcp improvements"

This reverts commit bb26697.

* Revert "lcp improvements on docs page"

This reverts commit 936cf14.

* Update MAS package.json version

* fixed nala tests

* lint fixes

* nala test title fixed

* fixed test

* conflicts resolved for the nth time

* conflicts resolved

* no source maps

* right bg color for ah try card

* sp-button analytics

* data-analytics-id in sp-button

* MWPW-169143: AH Try/Buy Widget sizing fixes

* data-analytics-id on checkoutButton

* version bump

---------

Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>
Co-authored-by: astatescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Ilyas Türkben <ilyas@adobe.com>

* [MWPW-167752] Loop focus in modals containing iframes (#3716)

* MWPW-163228: Preflight svg issue (#3725)

* WIP: Pushing just for preview purposes

* Added messaging to clairfy the status of the SVG

* Strange issues with dev tools, removing fetch to avoid possible CORS, adding external url to show authors where content lives

* Updating tags and errortype for PEP lana logs (#3731)

Lana log message fix

* MWPW-151376: Check sharepoint url (#3733)

* [MWPW-167759] Hero marquee bg-bottom-tablet fix (#3735)

* MWPW-166689 Add video support to Article Header (#3737)

* MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav (#3739)

* MWPW-163320 Gnav Promo CTA overflowing issue - BACOM Global Nav

* apply fix specific to button inside feds promo

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com>
Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com>
Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Prince Patel <prpatel0949@gmail.com>
Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>
Co-authored-by: astatescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Ilyas Türkben <ilyas@adobe.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Jason Slavin <slavin@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>

---------

Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Dušan Kosanović <dusan.kosanovic@hitthecode.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com>
Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com>
Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com>
Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com>
Co-authored-by: Prince Patel <prpatel0949@gmail.com>
Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <176400439+st-angelo-adobe@users.noreply.github.com>
Co-authored-by: astatescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Ilyas Türkben <ilyas@adobe.com>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Jason Slavin <slavin@adobe.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
0