MWPW-173966: Hide jarvis popup behind modal #4261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
narcis-radu
approved these changes
May 29, 2025
meganthecoder
approved these changes
May 29, 2025
|
Reminder to set the |
| @@ -464,6 +464,6 @@ | |||
| overflow: hidden; | |||
| } | |||
|
|
|||
| body:has(.dialog-modal) #adbMsgClientWrapper #adbmsgContainer #adbmsgCta { | |||
| body:has(.dialog-modal) #adbMsgClientWrapper #adbmsgContainer > * { | |||
There was a problem hiding this comment.
The story also mentions an .adbmsgSalesPopUpContainer element, is that covered by this rule as well? I haven't been able to quickly find a page using that particular element.
There was a problem hiding this comment.
Yes, .adbmsgSalesPopUpContainer is a direct child of a #adbmsgContainer. But maybe I can change it to all elements instead of strictly direct child, just in case if they decide to add something like
#adbmsgContainer > child with position: static > child with position:absolute and z-index:999999, wdyt ?
There was a problem hiding this comment.
I'd be a bit cautious, as that would override any z-index rules Jarvis needs to display properly, so we might affect their layout, even though it'd be under the modal curtain. The current solution should be a-ok, I just wanted to make sure that use-case is considered. Thanks for the confirmation!
overmyheadandbody
approved these changes
May 30, 2025
| @@ -464,6 +464,6 @@ | |||
| overflow: hidden; | |||
| } | |||
|
|
|||
| body:has(.dialog-modal) #adbMsgClientWrapper #adbmsgContainer #adbmsgCta { | |||
| body:has(.dialog-modal) #adbMsgClientWrapper #adbmsgContainer > * { | |||
There was a problem hiding this comment.
I'd be a bit cautious, as that would override any z-index rules Jarvis needs to display properly, so we might affect their layout, even though it'd be under the modal curtain. The current solution should be a-ok, I just wanted to make sure that use-case is considered. Thanks for the confirmation!
NadiiaSokolova
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-173966
skholkhojaev
added a commit
to skholkhojaev/milo
that referenced
this pull request
Jun 6, 2025
* [MWPW-173717] Hyphenate large headings on mobile (adobecom#4199) * MWPW-170520: 🍟 Merch Card (adobecom#4087) * wip * wip * wip * wip * unit tests + css * demo page * updated deps * tooltip * tooltip * Update popover.js * Update fries.html * Update fries.html * cta toggle text * wip * updated deps * wip * wip * updated deps * unit tests * ut fixes * updated deps * ut fix * Update merch-offer-select.test.js * NALA fix * conflicts resolved * fixes * text decoration * yellow color dark theme * Update fries.html * remove console log * font size addon confirmation * Update merch-card.fries.test.html.js * dark theme body color * dark theme * icon size * responsiveness * styles * body-s color * Update styles.css * Update fries.html * Updated CSS * color * updated deps * resolved conflicts * css * increased max count for fries card * MWPW-170535 - Ribbon Notification 'in-line' variant for mWeb (adobecom#4101) * ribbon in-line * ribbon in-line * ribbon in-line * review comment --------- Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> * MWPW-169410: Add download icon to sidekick (adobecom#4159) * MWPW-169410: Add download icon to sidekick * MWPW-169410: Remove title and description to avoid announcment duplication * MWPW-169410: Change title to Download icon * MWPW-173425: Allow container to expand based on line height (adobecom#4180) * Updating code owners for region nav and navigation folder (adobecom#4196) Updating codeowners for region nav and navigation folder * Wrapping the test urls for Gnav in a collapsed section (adobecom#4219) * Wrapping the test urls in a collapsed section * Update title * MWPW-173436 | Fix delay in split notification load (adobecom#4216) * Update notification z indexes with values * Update notification.css * Remove lana log error specific to localnav from non localnav gnav (adobecom#4058) * Logging only when it is sent as localnav but is not * Test fix * Lint fix * MWPW-170753 : [Mobile NAV][A11Y] | RWD Tablet Mobile (adobecom#4174) * Tab, ShiftTab, Escape fixes for mobile design * Updated for escape functionality * accommodating review comments --------- Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * [Mobile NAV][A11Y] | RWD Tablet Mobile -Able to browse outside modal with screen reader (adobecom#4205) * Fix for pagecontent reading * Fix for pagecontent reading * Fix for pagecontent reading --------- Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> * MWPW-171937: fix cta urls for bulk publisher (adobecom#4147) * MWPW-171937: fix cta urls for bulk publisher * MWPW-171937: fix cta urls for bulk publisher --------- Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local> * MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (adobecom#4225) * MWPW-173888: Appending extra options for relative urls * keep relative url * modal reopened logic * unit tests * Revert "[MWPW-173470] - Korea free trial restrict" (stage) (adobecom#4235) Revert "[MWPW-173470] - Korea free trial restrict (adobecom#4185)" This reverts commit 351cfe6. * MWPW-173875 (adobecom#4233) * MWPW-173875 Leadership wants these logs out before the RCP * [MWPW-173470] - Korea free trial restrict (adobecom#4264) * [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> * MWPW-174245: Add loc tests for CCD (adobecom#4271) * MWPW-170454 : Fixed visual list is not marked up as list and footer issue (adobecom#4177) * fixed visual list is not marked up as list a11y issue * fixed eslint * Fixed footer alignment * refactored the code * fixed review comments * Mwpw 169219 a11y aside (adobecom#4204) * MWPW-169219: Add tooltip to aside promo popup * MWPW-169219: Move tooltip icon to the right on mobile * MWPW-169219: Move tooltip icon on mobile to the left * MWPW-169219: Set tooltip font size to heading font size and align it * MWPW-169219: Add support for rtl * MWPW-169219: Pr update * MWPW-169219: PR feedback * MWPW-169219: Set tooltip height to 16px * MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when 67E6 Mega Menu fragment has not loaded (Desktop & Mobile) (adobecom#4213) * Parallelize the network calls required before the gnav becomes visible * corrected the logic for loading base styles for non-milo contexts * load aside.js in parallel if necessary * made the logic inside getGnavSource a little more fault tolerant * Fixed an issue with loading the dark mode gnav (standalone) * changed the gnav tests to reload the global-navigation.js module anew on each test to work correctly with the performance optimizations * Fixed a test for localnav inside bootstrapper.test.js * ignore eslint error on a test * added error handling to the style loading logic in gnav * changed error handling for loading gnav styles from throwing an error to rejecting a promise * removed some redundant code * changed e.message to e * implemented the loading state for desktop viewports * Change animation name as it was the same as one that the unav uses * implemented the loading state for mobile * Removed pointer events from the loading state; made the loading state closer to the specs * Finishing touches * Don't have a loading state for the legacy mobile gnav * add the loading state only on async Dropdowns; decorateLocalnav should be inside decorateMenu.then(...) * put the call to `decorateLocalNavItems` inside `finally` to make sure it runs * lint fixes * Sometimes mobileNavCleanup can be null * Removed an extraneous line * Cleaning up the merge conflict resolution * Make sure `transformTemplateToMobile` always returns a function * Revert "Revert "MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment has not loaded (Desktop & Mobile)" (adobecom#4210)" This reverts commit 430f850. * Fixed and issue where the gnav popup was emoty on the homepage when switching between mobile and desktop viewports * [MWPW-168998] - Fix for jarvis A11Y issue with tooltip (adobecom#4234) * Fix for jarvis A11Y issue with tooltip * lint fix --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * [MWPW-171938] - table header cell markup fix (adobecom#4248) * [MWPW-171938] - cell role fix * [MWPW-171938] - aria hidden added for empty cells * [MWPW-171938] - revert aria hidden * [MWPW-171938] - shorten code * [MWPW-173963] - table inside tabs sticky fix (adobecom#4249) * [MWPW-173963] - table inside tabs sticky fix * [MWPW-173963] - update logic * [MWPW-173963] - code optimization, variable name change * Fixing Missing/Mismatched attributes in PageView call payload (adobecom#4252) * fixing advertising and eventmergeid * fixing error * fixing error * fixing error * fixing error * fixing error * fixing error * Adding BACOM properties * Updating DS IDs for BACOM pages * Adding aem * fixing errors * fixing errors * fixing errors * fixing errors * fixing errors * fixing errors --------- Co-authored-by: Akansha Arora <> * [MWPW-170178] Table highlight a11y (adobecom#4254) * [MWPW-171062] Allow decorative images through image links (adobecom#4256) * [MWPW-174092] Authors cannot edit purpose of Play button (adobecom#4262) play aria fix Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> * Fix(MWPW-171006): Removed pill and Split notification block flattening feature (adobecom#3963) fixed with css * Gap is seen between promo banner and G-nav when page is scrolled fix (adobecom#4061) * Gap is seen between promo banner and G-nav when page is scrolled. * move the changes to global navigation css * add min height after 1 second * instead of 100% use 72px as an actually banner height * use --global-height-navPromo instead of static 72px * Centralized DA importer hosted within milo (adobecom#4255) * WP * WP * wp * Fix a few small issues * Set max length for finishing logs * Remove unused env var * Fix linting issues * add org * Add PR feedback * Add yaml to trigger bacom imports * Always log the first 500 successfully imported live paths * Add EOF (thx Rares) * Dont error if there are no logs * Remove double slack notification * Add Rares feedback * Set the correct path from which the workflow is running from (adobecom#4286) * Set the correct path from which the workflow is running from * Allow to set a local LAST_ISO_RUN for better debugging * [3in1] MWPW-173962 (adobecom#4258) * fix fallback deeplink * fix edu * fix * fix cs * fix tests * fix nala&unit tests * fix analytics * fix * fix flacky test * fix another flacky test * add fallback nala test * add test for iframe src * Accessibility carousel (adobecom#4203) * Improve carousel accessibility * add visibility hidden * clear timeout * update nala tests * set aria-hidden for non visible slides * PR feedback * PR feedback * Update css comments * MWPW-174220 | Accessibility | Changing table heading roles to not have them treated as text. (adobecom#4276) * Update table.js * Update table.js * Update table.js * Update table.js * MWPW-173109, 173937, 174288 [MEP][MMM] Batch (adobecom#4164) * Add personalization roc * Remove forced order and simplify tests * Remove unused json * Update createManifests func name * [MMM][MEP] "MMM data for last 7 days" should not appear in the MMM report (adobecom#4230) * Initial checkin. Good state. * Naming conventions. Fix sticky marquee logic. * Variant name update. * Alignment fix. * Update with hide at action area logic. * Updated as per PR comment. * Marquee updates, first pass. * Var1 marquee button rework. * Possible custom-hide fix. * Initial checkin. Fetch manifests API. Generate HTML. * Headers, divider logic, change events, hide selected, 'non' select option logic. * Update to duplicate manifest logic. * Remove console log. * Linting. * Unit test update. * Label/select rename. Don't update button for hidden experiences. Default MMM to none. * Hidden option button update fix. * Unit Testing. * Update libs/features/personalization/preview.js * Remove placeholder domain. * Update manifest option titles for clarity in preview.js * Update option title for clarity in getManifestListDomAndParameter function * Initial checkin. Remove 'more manifests' checkbox from MMM. --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * MWPW-174288 [MMM][MEP] Fix stying and DOM issue in new MMM report (adobecom#4260) [MMM]: Added styling fix for MMM variants Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * [MWPW-173125] Preflight SEO 404 / General tab fixes (adobecom#4197) * Making new nav true by default for standalone Gnav and giving font family to localnav (adobecom#4211) * Making new nav true by default for standalone gnav * Fixing test case * Ensuring feds promo renders behind app switcher component if on mobile and it overlaps (adobecom#4223) * Making aside z index 0 if appswitcher is open * Making z index to 11 if it switches back to desktop * Checking promo exist before calling updatePromoZIndex * Lint fix * MWPW-170548: Apply flex to metch action area (adobecom#4226) * [MWPW-170419] - aside std video stacking (adobecom#4228) [MWPW-170419] - width added to image container * MWPW-173864: Updates to milo Caas Configurator labels (adobecom#4232) * MWPW-173864: Updates milo Caas Configurator labels * Updates label * MWPW-173197 Allow loading of gnav on all graybox domains (adobecom#4239) * MWPW-173197 Allow loading of gnav on all graybox domains With graybox, there will be many different domains used - e.g: https://04-02-25-nab-gen-studio-mweb.graybox.adobe.com When domains without https:// are added to `cdnWhitelistedOrigins`, then an `endsWith` check is done to see if the domain is allowed. * Add test case * Small Perf Optimization * MWPW-173110 Fix fragment loading fail in iframe (adobecom#4241) When loading a milo page into an iframe, sometimes fragments would fail to load and would instead display as text. The reason for this is that `createTag` was using `instanceof HTMLElement`. However the instanceof Element check fails because the Element constructor we're checking against belongs to a different JavaScript realm (outside iframe) than the one where the element was created. Using myEl.nodeType === Node.ELEMENT_NODE is a more reliable, cross-context way to determine if an object is an HTML element. * Fix(Mwpw-173452): Console error for invalid url parse is fixed. (adobecom#4243) url parse error fix * MWPW-173966: Hide jarvis popup behind modal (adobecom#4261) * [NALA][MWPW-173773]Update the fleaky tests and aem.live url (adobecom#4201) * update the fleaky tests and aem.live url * all-elements * nested personalization * update to run.sh * skipping few more tests on webkit --------- Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local> Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@MacBookPro.attlocal.net> * Revert "[MWPW-173717] Hyphenate large headings on mobile" (adobecom#4303) Revert "[MWPW-173717] Hyphenate large headings on mobile (adobecom#4199)" This reverts commit 7b82821. * [Comment update PR] Update utilities.js (adobecom#4306) Update utilities.js Making a change to the utilities file * MWPW 173620 | Accessibility | Card-horizontal block heading role change for accessibility (adobecom#4257) * Update card-horizontal.js * Update card-horizontal.js * Update card-horizontal.js * Using productCode instead productFamily. (adobecom#4291) Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Localnav link group support (adobecom#4319) * Fixing css issue for localnav and showing linkgroup description on localnav * Css fix for description * subheader referred as a link (adobecom#4095) * remove href * check menu item * add log * add debugger * revert * fix accessibility * fix indent * undo spacings * remove indent * MWPW-171997 fix accessibility issue * undo unwanted changes * move fix specific to popupitems * remove href from subheader so nvda dont read it as clickable * remove tabindex -1 * undo last change * update anchor tag to div with heading level 3 role * keep a as selector * make heading 3 focusable * skip sub header from focus as it is no longer a link * [MWPW-170341] - table bold text break fix (adobecom#4106) * [MWPW-170341] - table bold text break fix * [MWPW-170341] - expand clause for text wrap * [MWPW-170341] - without timeout solution * [MWPW-170341] - shorten code * [MWPW-170341] - optimize * [MWPW-170341] - expand tag query * [MWPW-170341] - update logic * [MWPW-170341] - remove code * [MWPW-170341] - revert to previous solution, remove refs to curtain tags * [MWPW-170341] - logic optimization * [MWPW-170341] - shorten code * MWPW-173608 [M@S] Mnemonics filed disappear from card preview when … (adobecom#4170) * MWPW-173608 [M@S] Mnemonics filed disappear from card preview when editing card * MWPW-173608 [M@S] Mnemonics filed disappear from card preview when editing card * build mas * Trigger Build * Trigger Build * MWPW-173608 [M@S] Mnemonics filed disappear from card preview when editing card * Trigger Build * MWPW-173608 [M@S] Mnemonics filed disappear from card preview when editing card * MWPW-173608 [M@S] Mnemonics filed disappear from card preview when editing card * Build mas * Trigger Build * Trigger Build * Trigger Build --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> * Mwpw 173540 preflight preview publish (adobecom#4214) * fix: Preview and Publish column gets hidden because it gets rendered out of viewport * fix: Preflight general Tab now only shows unique links * added a max length to links * fixed the icon not appearing * changed the max-width * re added deleted lines * ignores the CaaS links and does not include it in the final raport * made css more specific & code improvment * Remove unnecessary whitespace in prefligh A3E2 t.css * Update grid layout in preflight.css * [MWPW-173984] - Added fix for dark theme for promo (adobecom#4245) * Added fix for promo in dark mode * Added fix for promo in dark mode * Revert previous commit --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * MWPW-174127 | Accessibility | Set heading role for half height card (adobecom#4263) Set heading role for half height card * MWPW-168547 Fix autofill on Marketo multi-step form (adobecom#4267) * MWPW-168547 Fix autofill on Marketo multi-step form * descriptive time variable * [MWPW-171655] - table icon missalignement fix (adobecom#4270) * [MWPW-174313] - Added missing parent role for localnav A11Y (adobecom#4285) Added missing parent role for localnav A11Y Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> * MWPW-170541: Add support for rtl (adobecom#4307) * MWPW-170541: Add support for rtl * MWPW-170541: PR feedback * Revert "Using productCode instead productFamily." (adobecom#4325) Revert "Using productCode instead productFamily. (adobecom#4291)" This reverts commit ac6cca9. --------- Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Drashti Modasara <drashti1712@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Aishwarya Mathuria <mathuria@adobe.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Himani Kuraware <hkuraware@adobe.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Prince Patel <prpatel0949@gmail.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Santoshkumar Nateekar <santoshkumar.sn@gmail.com> Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local> Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@MacBookPro.attlocal.net> Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com> Co-authored-by: Sean Choi <seanchoi@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com> Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> Co-authored-by: Megan Thomas <methomas@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Jarvis popup is not hidden behind the modal curtain
Resolves: MWPW-173966
Test URLs:
CC URLs:
DC URLs: