generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 190
[Release] Stage to Main #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Release] Stage to Main #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve carousel accessibility * add visibility hidden * clear timeout * update nala tests * set aria-hidden for non visible slides * PR feedback * PR feedback * Update css comments
…e them treated as text. (#4276) * Update table.js * Update table.js * Update table.js * Update table.js
* Add personalization roc * Remove forced order and simplify tests * Remove unused json * Update createManifests func name * [MMM][MEP] "MMM data for last 7 days" should not appear in the MMM report (#4230) * Initial checkin. Good state. * Naming conventions. Fix sticky marquee logic. * Variant name update. * Alignment fix. * Update with hide at action area logic. * Updated as per PR comment. * Marquee updates, first pass. * Var1 marquee button rework. * Possible custom-hide fix. * Initial checkin. Fetch manifests API. Generate HTML. * Headers, divider logic, change events, hide selected, 'non' select option logic. * Update to duplicate manifest logic. * Remove console log. * Linting. * Unit test update. * Label/select rename. Don't update button for hidden experiences. Default MMM to none. * Hidden option button update fix. * Unit Testing. * Update libs/features/personalization/preview.js * Remove placeholder domain. * Update manifest option titles for clarity in preview.js * Update option title for clarity in getManifestListDomAndParameter function * Initial checkin. Remove 'more manifests' checkbox from MMM. --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> * MWPW-174288 [MMM][MEP] Fix stying and DOM issue in new MMM report (#4260) [MMM]: Added styling fix for MMM variants Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> --------- Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com> Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
…mily to localnav (#4211) * Making new nav true by default for standalone gnav * Fixing test case
…e and it overlaps (#4223) * Making aside z index 0 if appswitcher is open * Making z index to 11 if it switches back to desktop * Checking promo exist before calling updatePromoZIndex * Lint fix
[MWPW-170419] - width added to image container
* MWPW-173864: Updates milo Caas Configurator labels * Updates label
* MWPW-173197 Allow loading of gnav on all graybox domains With graybox, there will be many different domains used - e.g: https://04-02-25-nab-gen-studio-mweb.graybox.adobe.com When domains without https:// are added to `cdnWhitelistedOrigins`, then an `endsWith` check is done to see if the domain is allowed. * Add test case * Small Perf Optimization
When loading a milo page into an iframe, sometimes fragments would fail to load and would instead display as text. The reason for this is that `createTag` was using `instanceof HTMLElement`. However the instanceof Element check fails because the Element constructor we're checking against belongs to a different JavaScript realm (outside iframe) than the one where the element was created. Using myEl.nodeType === Node.ELEMENT_NODE is a more reliable, cross-context way to determine if an object is an HTML element.
url parse error fix
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
* update the fleaky tests and aem.live url * all-elements * nested personalization * update to run.sh * skipping few more tests on webkit --------- Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local> Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@MacBookPro.attlocal.net>
JackySun9
approved these changes
Jun 3, 2025
Dli3
approved these changes
Jun 3, 2025
Update utilities.js Making a change to the utilities file
Merged
Roycethan
approved these changes
Jun 4, 2025
sigadamvenkata
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale