8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #4292 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 5, 2025
Merged

[Release] Stage to Main #4292

merged 16 commits into from
Jun 5, 2025

Conversation

milo-pr-merge[bot]
Copy link
Contributor
@milo-pr-merge milo-pr-merge bot commented Jun 3, 2025

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

zagi25 and others added 12 commits June 3, 2025 08:06
* Improve carousel accessibility

* add visibility hidden

* clear timeout

* update nala tests

* set aria-hidden for non visible slides

* PR feedback

* PR feedback

* Update css comments
…e them treated as text. (#4276)

* Update table.js

* Update table.js

* Update table.js

* Update table.js
* Add personalization roc

* Remove forced order and simplify tests

* Remove unused json

* Update createManifests func name

* [MMM][MEP] "MMM data for last 7 days" should not appear in the MMM report (#4230)

* Initial checkin. Good state.

* Naming conventions. Fix sticky marquee logic.

* Variant name update.

* Alignment fix.

* Update with hide at action area logic.

* Updated as per PR comment.

* Marquee updates, first pass.

* Var1 marquee button rework.

* Possible custom-hide fix.

* Initial checkin. Fetch manifests API. Generate HTML.

* Headers, divider logic, change events, hide selected, 'non' select option logic.

* Update to duplicate manifest logic.

* Remove console log.

* Linting.

* Unit test update.

* Label/select rename. Don't update button for hidden experiences. Default MMM to none.

* Hidden option button update fix.

* Unit Testing.

* Update libs/features/personalization/preview.js

* Remove placeholder domain.

* Update manifest option titles for clarity in preview.js

* Update option title for clarity in getManifestListDomAndParameter function

* Initial checkin. Remove 'more manifests' checkbox from MMM.

---------

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com>

* MWPW-174288 [MMM][MEP] Fix stying and DOM issue in new MMM report (#4260)

[MMM]: Added styling fix for MMM variants

Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com>

---------

Co-authored-by: Vivian A Goodrich <vgoodric@adobe.com>
Co-authored-by: Dave Linhart <132396886+AdobeLinhart@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
…mily to localnav (#4211)

* Making new nav true by default for standalone gnav

* Fixing test case
…e and it overlaps (#4223)

* Making aside z index 0 if appswitcher is open

* Making z index to 11 if it switches back to desktop

* Checking promo exist before calling updatePromoZIndex

* Lint fix
[MWPW-170419] - width added to image container
* MWPW-173864: Updates milo Caas Configurator labels

* Updates label
* MWPW-173197 Allow loading of gnav on all graybox domains

With graybox, there will be many different domains used - e.g:
https://04-02-25-nab-gen-studio-mweb.graybox.adobe.com

When domains without https:// are added to `cdnWhitelistedOrigins`, then an `endsWith` check is done to see if the domain is allowed.

* Add test case

* Small Perf Optimization
When loading a milo page into an iframe, sometimes fragments would fail to load and would instead display as text.

The reason for this is that `createTag` was using `instanceof HTMLElement`.  However the instanceof Element check fails because the Element constructor we're checking against belongs to a different JavaScript realm (outside iframe) than the one where the element was created. Using myEl.nodeType === Node.ELEMENT_NODE is a more reliable, cross-context way to determine if an object is an HTML element.
@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Jun 3, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor
aem-code-sync bot commented Jun 3, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

* update the fleaky tests and aem.live url

* all-elements

* nested personalization

* update to run.sh

* skipping few more tests on webkit

---------

Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local>
Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@MacBookPro.attlocal.net>
@mokimo mokimo temporarily deployed to milo_pr_merge June 4, 2025 01:20 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 4, 2025 04:23 — with GitHub Actions Inactive
< 9E88 /div>
Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)"

This reverts commit 7b82821.
Update utilities.js

Making a change to the utilities file
@mokimo mokimo temporarily deployed to milo_pr_merge June 4, 2025 20:14 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 5, 2025 01:19 &md F438 ash; with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 5, 2025 04:24 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 5, 2025 08:22 — with GitHub Actions Inactive
@milo-pr-merge milo-pr-merge bot merged commit 63351ef into main Jun 5, 2025
56 of 58 checks passed
@milo-pr-merge milo-pr-merge bot temporarily deployed to milo_pr_merge June 5, 2025 09:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0