8000 Incorrect Secondary CTA styling by patel-prince · Pull Request #4302 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Incorrect Secondary CTA styling #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 5, 2025
Merged

Incorrect Secondary CTA styling #4302

merged 19 commits into from
Jul 5, 2025

Conversation

patel-prince
Copy link
Contributor
@patel-prince patel-prince commented Jun 3, 2025 •
edited by github-actions bot
Loading

Incorrect Secondary CTA styling

Resolves: MWPW-164247, MWPW-175004

Test URLs:

QA URL:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 3, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 4, 2025

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

nishantka
nishantka reviewed Jun 5, 2025
View reviewed changes
nishantka
nishantka reviewed Jun 5, 2025
View reviewed changes
@spadmasa
Copy link
spadmasa commented Jun 9, 2025

Hi @patel-prince , do not see the button style reflecting correctly in darkmode without hover
https://adobecom.github.io/nav-consumer/navigation.html?env=stage&theme=dark&authoringpath=/federal/dev/soujanya&navbranch=mwpw-164247
image

@prativas22
Copy link

hi @patel-prince ,
In dark mode, the secondary CTA style does not appear on mobile devices.
https://adobecom.github.io/nav-consumer/navigation.html?env=stage&theme=dark&authoringpath=/federal/dev/soujanya&navbranch=mwpw-164247
image

@spadmasa spadmasa added the needs-verification PR requires E2E testing by a reviewer label Jun 11, 2025
@mokimo
Copy link
Contributor
mokimo commented Jun 16, 2025

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding?

@patel-prince patel-prince requested a review from a team as a code owner June 23, 2025 09:16
@github-actions GitHub Actions
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@prativas22
Copy link

Verified the secondary CTA styling and animation fix PR using the below URLs:

https://main--homepage--adobecom.aem.live/in/homepage/index-loggedout?milolibs=mwpw-164247--milo--patel-prince
image
on hover
image

https://adobecom.github.io/nav-consumer/navigation.html?env=stage&authoringpath=/federal/dev/prats/mobileredesign/secctatest&customlinks=home,apps,files,firefly,benefits,learn,discover&showUnavSectionDivider=true&unav=appswitcher,profile,notifications,help,cart&navbranch=mwpw-164247&newNav=true
image
on hover
image

Dark mode (Dan has confirmed that the following is the expected dark mode secondary CTA styling.)
image
image

For reference, QA test results have been added to the tickets below.
https://jira.corp.adobe.com/browse/MWPW-164247
https://jira.corp.adobe.com/browse/MWPW-175004

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jun 30, 2025
@milo-pr-merge milo-pr-merge bot merged commit aecd1c3 into adobecom:stage Jul 5, 2025
21 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deva309 Deva309 Deva309 approved these changes

@sharmrj sharmrj sharmrj approved these changes

@nishantka nishantka nishantka approved these changes

@bandana147 bandana147 Awaiting requested review from bandana147

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3

@salonijain3 salonijain3 Awaiting requested review from salonijain3

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@patel-prince @spadmasa @prativas22 @mokimo @salonijain3 @Deva309 @sharmrj @nishantka
0