-
Notifications
You must be signed in to change notification settings - Fork 190
[Release] Stage to Main #4502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Release] Stage to Main #4502
Conversation
prevents duplicate three-in-one
* Table flaky/failing tests fix * Table test beforeeach logic update
* abort error ignored * test * test * test * test * test * test * test * test * test * abort error * ready state with re-useable function
* Implement Arrow keyboard navigation for mobile gnav components * add navigation logic for promo links * remove consoles * keep focus on close button when menu open * add some review changes * use optional chaining as suggested in review * review changes and updates * refactoring to switch case as suggested in review changes * optimize as per the review changes * use optional chaining * Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices. * fix focus fedsnavlinks when sybheader level 3 is present * focus selected tab on submenu open if focus mode is on * add rtl support
* fix Incorrect Secondary CTA styling * remove unwanted styles for dark mode * remove unavailable variables * add dark mode styles * mobile dark mode fix and MWPW-175004 * Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices. * undo Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices. * bottom of mega menu scrolling up on A.com & AH * undo pointerdown
…dscape mode on the FF browser (#4341) * Fix is a gap at the bottom of the Megamenu * adding styles from css * bottom of mega menu scrolling up on A.com & AH * fix animation for feds cta in mobile gnav * undo * Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices. * undo * bottom of mega menu scrolling up on A.com & AH * add comments * landscape mode the overlapping of button with menu items * update the popup position when screen orientation changes * undo
* added darkmode css for the loader skeleton * Fix the more button showing up in the skeleton state * Fixed an issue where the desktop loading state gnav was showing on mobile viewports for a split second * Fixed an issue where the loading state in dark mode on mobile had the incorrect background color
…fix (#4452) * [MWPW-175093] - table heading sticky font size scale up fix * [MWPW-175093] - table heading sticky observer optimization * [MWPW-175093] - debounce added * [MWPW-175093] - table omit debounce default value
* Adding fixes for geo popup overflow issue * Lint fix * reuse modal from show modal method --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
Update self hosted dependency Co-authored-by: GitHub Action <action@github.com>
…seo and A11Y (#4480) Added fix for promo heading to work for both purpose seo and A11Y Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
* enable preview for stage * check updated * revert --------- Co-authored-by: Predrag Markovic <cod14230@adobe.com>
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
SNOW Change Request Transaction ID: 0000019746cb9d8a-3e2a8bd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
@bandana147 @patel-prince seeing the issue of promobar slightly visible intermittenly when the megamenu is opened in portrait mode in ghost state in android and iphone. Please take a look cc : @sigadamvenkata , @prativas22 , @salonijain3 |
@spadmasa This is happening on production as well under slow network and is not related to the current batch. We will be addressing this in a separate PR. cc: @salonijain3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA noticed issue and team working on PR reversal
https://jira.corp.adobe.com/browse/MWPW-176035
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale