8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #4502 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[Release] Stage to Main #4502

wants to merge 14 commits into from

Conversation

milo-pr-merge[bot]
Copy link
Contributor
@milo-pr-merge milo-pr-merge bot commented Jul 5, 2025

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

Axelcureno and others added 14 commits June 28, 2025 01:41
* Table flaky/failing tests fix

* Table test beforeeach logic update
* abort error ignored

* test

* test

* test

* test

* test

* test

* test

* test

* test

* abort error

* ready state with re-useable function
* Implement Arrow keyboard navigation for mobile gnav components

* add navigation logic for promo links

* remove consoles

* keep focus on close button when menu open

* add some review changes

* use optional chaining as suggested in review

* review changes and updates

* refactoring to switch case as suggested in review changes

* optimize as per the review changes

* use optional chaining

* Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices.

* fix focus fedsnavlinks when sybheader level 3 is present

* focus selected tab on submenu open if focus mode is on

* add rtl support
* fix Incorrect Secondary CTA styling

* remove unwanted styles for dark mode

* remove unavailable variables

* add dark mode styles

* mobile dark mode fix and MWPW-175004

* Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices.

* undo Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices.

* bottom of mega menu scrolling up on A.com & AH

* undo pointerdown
…dscape mode on the FF browser (#4341)

* Fix is a gap at the bottom of the Megamenu

* adding styles from css

* bottom of mega menu scrolling up on A.com & AH

* fix animation for feds cta in mobile gnav

* undo

* Shift-tab focus does not function for breadcrumbs on Tablet Mobile devices.

* undo

* bottom of mega menu scrolling up on A.com & AH

* add comments

* landscape mode the overlapping of button with menu items

* update the popup position when screen orientation changes

* undo
* added darkmode css for the loader skeleton

* Fix the more button showing up in the skeleton state

* Fixed an issue where the desktop loading state gnav was showing on mobile viewports for a split second

* Fixed an issue where the loading state in dark mode on mobile had the incorrect background color
…fix (#4452)

* [MWPW-175093] - table heading sticky font size scale up fix

* [MWPW-175093] - table heading sticky observer optimization

* [MWPW-175093] - debounce added

* [MWPW-175093] - table omit debounce default value
* Adding fixes for geo popup overflow issue

* Lint fix

* reuse modal from show modal method

---------

Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
Update self hosted dependency

Co-authored-by: GitHub Action <action@github.com>
…seo and A11Y (#4480)

Added fix for promo heading to work for both purpose seo and A11Y

Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
* enable preview for stage

* check updated

* revert

---------

Co-authored-by: Predrag Markovic <cod14230@adobe.com>
@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Jul 5, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot

@milo-pr-merge milo-pr-merge bot requested review from a team as code owners July 5, 2025 08:22
Copy link
Contributor
aem-code-sync bot commented Jul 5, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
aem-code-sync bot commented Jul 5, 2025

Copy link
Contributor
github-actions bot commented Jul 5, 2025

SNOW Change Request Transaction ID: 0000019746cb9d8a-3e2a8bd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@mokimo mokimo temporarily deployed to milo_pr_merge July 5, 2025 09:16 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 5, 2025 12:31 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 5, 2025 16:19 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 5, 2025 20:16 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 01:37 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 04:30 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 08:20 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 09:16 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 12:31 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 16:18 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 6, 2025 20:17 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 7, 2025 01:26 — with GitHub Actions Inactive
@spadmasa
Copy link
spadmasa commented Jul 7, 2025

@bandana147 @patel-prince seeing the issue of promobar slightly visible intermittenly when the megamenu is opened in portrait mode in ghost state in android and iphone. Please take a look
https://www.stage.adobe.com/de/creativecloud.html
IMG_20250707_092653301_HDR

cc : @sigadamvenkata , @prativas22 , @salonijain3

@mokimo mokimo temporarily deployed to milo_pr_merge July 7, 2025 04:31 — with GitHub Actions Inactive
@bandana147
Copy link
Contributor

@bandana147 @patel-prince seeing the issue of promobar slightly visible intermittenly when the megamenu is opened in portrait mode in ghost state in android and iphone. Please take a look https://www.stage.adobe.com/de/creativecloud.html IMG_20250707_092653301_HDR

cc : @sigadamvenkata , @prativas22 , @salonijain3

@spadmasa This is happening on production as well under slow network and is not related to the current batch. We will be addressing this in a separate PR.

cc: @salonijain3

@mokimo mokimo temporarily deployed to milo_pr_merge July 7, 2025 08:24 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 7, 2025 09:21 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 7, 2025 12:35 — with GitHub Actions Inactive
@3ch023 3ch023 temporarily deployed to milo_pr_merge July 7, 2025 12:59 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 7, 2025 16:21 — with GitHub Actions Inactive
@Dli3 Dli3 temporarily deployed to milo_pr_merge July 8, 2025 00:21 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge July 8, 2025 01:22 — with GitHub Actions Inactive
@mokimo mokimo deployed to milo_pr_merge July 8, 2025 04:27 — with GitHub Actions Active
Copy link
@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA noticed issue and team working on PR reversal
https://jira.corp.adobe.com/browse/MWPW-176035
{FB64034F-A4B1-4F62-B24A-E5EFD0A00419}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0