8000 [MWPW-146354] - Geo Popup content overflow issue fix by Deva309 · Pull Request #4455 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MWPW-146354] - Geo Popup content overflow issue fix #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 5, 2025
Merged

[MWPW-146354] - Geo Popup content overflow issue fix #4455

merged 6 commits into from
Jul 5, 2025
+39 −2

Conversation

Deva309
Copy link
Contributor
@Deva309 Deva309 commented Jun 24, 2025 •
edited by github-actions bot
Loading

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 24, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Deva309 Deva309 marked this pull request as ready for review June 24, 2025 05:20
@Deva309 Deva309 requested a review from a team as a code owner June 24, 2025 05:20
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@Deva309 Deva309 added the needs-verification PR requires E2E testing by a reviewer label Jun 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@prativas22
Copy link

Verified the Geo Modal Content overflow and locale option crop issue fix PR using the URLs below.

https://main--cc--adobecom.aem.live/jp/products/illustrator?milolibs=mwpw-146354-geo--milo--deva309
image

https://main--cc--adobecom.aem.live/mx/products/illustrator?milolibs=mwpw-146354-geo--milo--deva309
Firefox:
image
https://main--bacom--adobecom.aem.live/?milolibs=mwpw-146354-geo--milo--deva309
image

The results of the QA test are included in the ticket for reference: https://jira.corp.adobe.com/browse/MWPW-146354

8000

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jun 30, 2025
@milo-pr-merge milo-pr-merge bot merged commit b2a7719 into adobecom:stage Jul 5, 2025
26 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischrischris chrischrischris chrischrischris approved these changes

@nishantka nishantka nishantka approved these changes

@sonawanesnehal3 sonawanesnehal3 sonawanesnehal3 approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@bandana147 bandana147 Awaiting requested review from bandana147

@sharmrj sharmrj Awaiting requested review from sharmrj

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Deva309 @prativas22 @chrischrischris @nishantka @sonawanesnehal3 @spadmasa
0