8000 [MWPW-175629] - Added fix for promo heading to work for both purpose seo and A11Y by Deva309 · Pull Request #4480 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MWPW-175629] - Added fix for promo heading to work for both purpose seo and A11Y #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

[MWPW-175629] - Added fix for promo heading to work for both purpose seo and A11Y #4480

merged 1 commit into from
Jul 5, 2025

Conversation

Deva309
Copy link
Contributor
@Deva309 Deva309 commented Jun 27, 2025 •
edited by github-actions bot
Loading

Added fix for promo heading in GNAV to work for both purpose seo and A11Y.

Resolves: MWPW-175629

Test URLs:

QA
https://main--cc--adobecom.aem.page/products/catalog?milolibs=mwpw-175629--milo--deva309

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 27, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Deva309 Deva309 marked this pull request as ready for review June 27, 2025 05:27
@Deva309 Deva309 requested a review from a team as a code owner June 27, 2025 05:27
@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@spadmasa spadmasa added the needs-verification PR requires E2E testing by a reviewer label Jun 30, 2025
@spadmasa
Copy link

Validation done on the pr
https://main--cc--adobecom.aem.page/products/catalog?milolibs=mwpw-175629--milo--deva309
image
image

image
image
https://main--homepage--adobecom.aem.page/fr/homepage/index-loggedout?milolibs=mwpw-175629--milo--deva309
image

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jun 30, 2025
@milo-pr-merge milo-pr-merge bot merged commit 5b98183 into adobecom:stage Jul 5, 2025
26 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharmrj sharmrj sharmrj approved these changes

@nishantka nishantka nishantka approved these changes

@sonawanesnehal3 sonawanesnehal3 sonawanesnehal3 approved these changes

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Deva309 @spadmasa @sharmrj @nishantka @sonawanesnehal3 @prativas22
0